[PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error

[PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error

[Holger Brunck]

Remove the whitespace to fix the indentation.

Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>
---
 drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 09081f128a98..adf3863463f5 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -764,7 +764,7 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)
 		qe_muram_free(priv->ucc_pram_offset);
 		priv->ucc_pram = NULL;
 		priv->ucc_pram_offset = 0;
-	 }
+	}
 
 	kfree(priv->rx_skbuff);
 	priv->rx_skbuff = NULL;
-- 
2.47.3

Re: [PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error

[Christophe Leroy (CS GROUP)]

Hi,

Le 04/05/2026 à 18:07, Holger Brunck a écrit :
> Remove the whitespace to fix the indentation.

Do we really need a patch for that ? What's the added value of doing 
this change compared to the cost of doing it ?

> 
> Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
> Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>
> ---
>   drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 09081f128a98..adf3863463f5 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -764,7 +764,7 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)
>   		qe_muram_free(priv->ucc_pram_offset);
>   		priv->ucc_pram = NULL;
>   		priv->ucc_pram_offset = 0;
> -	 }
> +	}
>   
>   	kfree(priv->rx_skbuff);
>   	priv->rx_skbuff = NULL;

RE: [PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error

[Holger Brunck]

> 
> Le 04/05/2026 à 18:07, Holger Brunck a écrit :
> > Remove the whitespace to fix the indentation.
> 
> Do we really need a patch for that ? What's the added value of doing this change
> compared to the cost of doing it ?
> 

no not mandatory needed. I just saw that and thought that also such minor issues
should be fixed. Can be abandoned.

Best regards
Holger

Re: [PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error

[Jakub Kicinski]

On Tue, 5 May 2026 08:16:01 +0000 Holger Brunck wrote:
> no not mandatory needed. I just saw that and thought that also such minor issues
> should be fixed. Can be abandoned.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches