Re: [PATCH] dt-bindings: net: lan966x: Accept standard ethernet prefixes

[Rob Herring <robh@kernel.org>]

On Thu, May 07, 2026 at 01:40:43PM +0200, Herve Codina wrote:
> Hi Linus,
> 
> On Thu, 07 May 2026 11:26:01 +0200
> Linus Walleij <linusw@kernel.org> wrote:
> 
> > The dsa.yaml and ethernet-switch.yaml bindings recommend
> > prefixing ethernet switches and ports with "ethernet-" so
> > make the LAN966x do the same.
> > 
> > Reported-by: Herve Codina <herve.codina@bootlin.com>
> > Signed-off-by: Linus Walleij <linusw@kernel.org>
> > ---
> >  .../devicetree/bindings/net/microchip,lan966x-switch.yaml      | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > index 306ef9ecf2b9..0f0f35865ef4 100644
> > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > @@ -17,7 +17,7 @@ description: |
> >  
> >  properties:
> >    $nodename:
> > -    pattern: "^switch@[0-9a-f]+$"
> > +    pattern: "^(ethernet-)?switch@[0-9a-f]+$"
> >  
> >    compatible:
> >      const: microchip,lan966x-switch
> > @@ -70,7 +70,7 @@ properties:
> >      additionalProperties: false
> >  
> >      patternProperties:
> > -      "^port@[0-9a-f]+$":
> > +      "^(ethernet-)?port@[0-9a-f]+$":
> >          type: object
> >  
> >          $ref: /schemas/net/ethernet-controller.yaml#
> > @@ -138,7 +138,7 @@ additionalProperties: false
> >  examples:
> >    - |
> >      #include <dt-bindings/interrupt-controller/arm-gic.h>
> > -    switch: switch@e0000000 {
> > +    switch: ethernet-switch@e0000000 {
> >        compatible = "microchip,lan966x-switch";
> >        reg =  <0xe0000000 0x0100000>,
> >               <0xe2000000 0x0800000>;
> > @@ -151,14 +151,14 @@ examples:
> >          #address-cells = <1>;
> >          #size-cells = <0>;
> >  
> > -        port0: port@0 {
> > +        port0: ethernet-port@0 {
> >            reg = <0>;
> >            phy-handle = <&phy0>;
> >            phys = <&serdes 0 0>;
> >            phy-mode = "gmii";
> >          };
> >  
> > -        port1: port@1 {
> > +        port1: ethernet-port@1 {
> >            reg = <1>;
> >            sfp = <&sfp_eth1>;
> >            managed = "in-band-status";
> > 
> > ---
> > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
> > change-id: 20260507-lan966-binding-0df62a018509
> > 
> > Best regards,
> > --  
> > Linus Walleij <linusw@kernel.org>
> > 
> 
> With those changes, dtb_check will not be happy when following dtsi/dts are
> involved:
>   - arch/arm/boot/dts/microchip/lan966x.dtsi
>   - arch/arm/boot/dts/microchip/lan966x-kontron-kswitch-d10-mmt.dtsi
>   - arch/arm/boot/dts/microchip/lan966x-pcb8290.dts
>   - arch/arm/boot/dts/microchip/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts
>   - arch/arm/boot/dts/microchip/lan966x-kontron-kswitch-d10-mmt-8g.dts

How so? the added prefix is optional.

Rob