* [PATCH v1 1/6] dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control property
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
@ 2026-05-11 13:56 ` Svyatoslav Ryhel
2026-05-11 13:56 ` [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled Svyatoslav Ryhel
` (5 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-11 13:56 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, Svyatoslav Ryhel
Cc: netdev, devicetree, linux-kernel, linux-phy, linux-tegra,
linux-usb
Document the nvidia,external-control property required, for example, for
USB lines in HSIC mode connected to a modem, where the modem requires
precise control over the USB bus to properly enumerate all its stages and
intermediate devices.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
index 691d6cf02c27..a13c1ef49a57 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
@@ -75,6 +75,13 @@ properties:
type: boolean
deprecated: true
+ nvidia,external-control:
+ description:
+ Indicates that the controller is configured externally and that the host
+ should not attempt to touch it. Usually used by a modem which requires
+ precise bus configuration.
+ type: boolean
+
ulpi:
type: object
additionalProperties: false
--
2.51.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
2026-05-11 13:56 ` [PATCH v1 1/6] dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control property Svyatoslav Ryhel
@ 2026-05-11 13:56 ` Svyatoslav Ryhel
2026-05-12 1:15 ` Peter Chen (CIX)
2026-05-11 13:56 ` [PATCH v1 3/6] dt-bindings: net: Document Infineon/Intel XMM6260 modem Svyatoslav Ryhel
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-11 13:56 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, Svyatoslav Ryhel
Cc: netdev, devicetree, linux-kernel, linux-phy, linux-tegra,
linux-usb
If the USB controller and PHY are externally controlled, then the
registration of the controller and the PHY initialization should be
skipped, since these configurations must be done by the device that
controls the bus to work correctly.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/usb/chipidea/ci_hdrc_tegra.c | 36 +++++++++++++++++-----------
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
index 372788f0f970..593390a818d1 100644
--- a/drivers/usb/chipidea/ci_hdrc_tegra.c
+++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
@@ -32,6 +32,7 @@ struct tegra_usb {
struct clk *clk;
bool needs_double_reset;
+ bool externally_controlled;
};
struct tegra_usb_soc_info {
@@ -312,20 +313,25 @@ static int tegra_usb_probe(struct platform_device *pdev)
if (device_property_present(&pdev->dev, "nvidia,needs-double-reset"))
usb->needs_double_reset = true;
+ if (device_property_present(&pdev->dev, "nvidia,external-control"))
+ usb->externally_controlled = true;
+
err = tegra_usb_reset_controller(&pdev->dev);
if (err) {
dev_err_probe(&pdev->dev, err, "failed to reset controller");
goto fail_power_off;
}
- /*
- * USB controller registers shouldn't be touched before PHY is
- * initialized, otherwise CPU will hang because clocks are gated.
- * PHY driver controls gating of internal USB clocks on Tegra.
- */
- err = usb_phy_init(usb->phy);
- if (err)
- goto fail_power_off;
+ if (!usb->externally_controlled) {
+ /*
+ * USB controller registers shouldn't be touched before PHY is
+ * initialized, otherwise CPU will hang because clocks are gated.
+ * PHY driver controls gating of internal USB clocks on Tegra.
+ */
+ err = usb_phy_init(usb->phy);
+ if (err)
+ goto fail_power_off;
+ }
/* setup and register ChipIdea HDRC device */
usb->soc = soc;
@@ -342,12 +348,14 @@ static int tegra_usb_probe(struct platform_device *pdev)
if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
- usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
- pdev->num_resources, &usb->data);
- if (IS_ERR(usb->dev)) {
- err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
- "failed to add HDRC device");
- goto phy_shutdown;
+ if (!usb->externally_controlled) {
+ usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
+ pdev->num_resources, &usb->data);
+ if (IS_ERR(usb->dev)) {
+ err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
+ "failed to add HDRC device");
+ goto phy_shutdown;
+ }
}
return 0;
--
2.51.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled
2026-05-11 13:56 ` [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled Svyatoslav Ryhel
@ 2026-05-12 1:15 ` Peter Chen (CIX)
2026-05-12 6:13 ` Svyatoslav Ryhel
0 siblings, 1 reply; 13+ messages in thread
From: Peter Chen (CIX) @ 2026-05-12 1:15 UTC (permalink / raw)
To: Svyatoslav Ryhel
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, netdev, devicetree, linux-kernel, linux-phy,
linux-tegra, linux-usb
On 26-05-11 16:56:57, Svyatoslav Ryhel wrote:
> If the USB controller and PHY are externally controlled, then the
> registration of the controller and the PHY initialization should be
> skipped, since these configurations must be done by the device that
> controls the bus to work correctly.
>
I find you only control USB controller device add at PHY driver, most of USB drivers
has PHY control, for chipidea, it has PHY control at core.c, would please try to
adapt for it?
Peter
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
> drivers/usb/chipidea/ci_hdrc_tegra.c | 36 +++++++++++++++++-----------
> 1 file changed, 22 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> index 372788f0f970..593390a818d1 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -32,6 +32,7 @@ struct tegra_usb {
> struct clk *clk;
>
> bool needs_double_reset;
> + bool externally_controlled;
> };
>
> struct tegra_usb_soc_info {
> @@ -312,20 +313,25 @@ static int tegra_usb_probe(struct platform_device *pdev)
> if (device_property_present(&pdev->dev, "nvidia,needs-double-reset"))
> usb->needs_double_reset = true;
>
> + if (device_property_present(&pdev->dev, "nvidia,external-control"))
> + usb->externally_controlled = true;
> +
> err = tegra_usb_reset_controller(&pdev->dev);
> if (err) {
> dev_err_probe(&pdev->dev, err, "failed to reset controller");
> goto fail_power_off;
> }
>
> - /*
> - * USB controller registers shouldn't be touched before PHY is
> - * initialized, otherwise CPU will hang because clocks are gated.
> - * PHY driver controls gating of internal USB clocks on Tegra.
> - */
> - err = usb_phy_init(usb->phy);
> - if (err)
> - goto fail_power_off;
> + if (!usb->externally_controlled) {
> + /*
> + * USB controller registers shouldn't be touched before PHY is
> + * initialized, otherwise CPU will hang because clocks are gated.
> + * PHY driver controls gating of internal USB clocks on Tegra.
> + */
> + err = usb_phy_init(usb->phy);
> + if (err)
> + goto fail_power_off;
> + }
>
> /* setup and register ChipIdea HDRC device */
> usb->soc = soc;
> @@ -342,12 +348,14 @@ static int tegra_usb_probe(struct platform_device *pdev)
> if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
> usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
>
> - usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> - pdev->num_resources, &usb->data);
> - if (IS_ERR(usb->dev)) {
> - err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> - "failed to add HDRC device");
> - goto phy_shutdown;
> + if (!usb->externally_controlled) {
> + usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> + pdev->num_resources, &usb->data);
> + if (IS_ERR(usb->dev)) {
> + err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> + "failed to add HDRC device");
> + goto phy_shutdown;
> + }
> }
>
> return 0;
> --
> 2.51.0
>
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled
2026-05-12 1:15 ` Peter Chen (CIX)
@ 2026-05-12 6:13 ` Svyatoslav Ryhel
2026-05-12 7:51 ` Peter Chen (CIX)
0 siblings, 1 reply; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-12 6:13 UTC (permalink / raw)
To: Peter Chen (CIX)
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, netdev, devicetree, linux-kernel, linux-phy,
linux-tegra, linux-usb
вт, 12 трав. 2026 р. о 04:16 Peter Chen (CIX) <peter.chen@kernel.org> пише:
>
> On 26-05-11 16:56:57, Svyatoslav Ryhel wrote:
> > If the USB controller and PHY are externally controlled, then the
> > registration of the controller and the PHY initialization should be
> > skipped, since these configurations must be done by the device that
> > controls the bus to work correctly.
> >
>
> I find you only control USB controller device add at PHY driver, most of USB drivers
> has PHY control, for chipidea, it has PHY control at core.c, would please try to
> adapt for it?
>
Usually yes, but this is not the case for Tegra unfortunately. As you
can see Tegra specific section of Chipidea driver specifically
describes why it has to set PHY manually.
/*
* USB controller registers shouldn't be touched before PHY is
* initialized, otherwise CPU will hang because clocks are gated.
* PHY driver controls gating of internal USB clocks on Tegra.
*/
So in order to provide correct work of USB when set by an external
device, both PHY and controller init/add must be skipped.
> Peter
>
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > drivers/usb/chipidea/ci_hdrc_tegra.c | 36 +++++++++++++++++-----------
> > 1 file changed, 22 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > index 372788f0f970..593390a818d1 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > @@ -32,6 +32,7 @@ struct tegra_usb {
> > struct clk *clk;
> >
> > bool needs_double_reset;
> > + bool externally_controlled;
> > };
> >
> > struct tegra_usb_soc_info {
> > @@ -312,20 +313,25 @@ static int tegra_usb_probe(struct platform_device *pdev)
> > if (device_property_present(&pdev->dev, "nvidia,needs-double-reset"))
> > usb->needs_double_reset = true;
> >
> > + if (device_property_present(&pdev->dev, "nvidia,external-control"))
> > + usb->externally_controlled = true;
> > +
> > err = tegra_usb_reset_controller(&pdev->dev);
> > if (err) {
> > dev_err_probe(&pdev->dev, err, "failed to reset controller");
> > goto fail_power_off;
> > }
> >
> > - /*
> > - * USB controller registers shouldn't be touched before PHY is
> > - * initialized, otherwise CPU will hang because clocks are gated.
> > - * PHY driver controls gating of internal USB clocks on Tegra.
> > - */
> > - err = usb_phy_init(usb->phy);
> > - if (err)
> > - goto fail_power_off;
> > + if (!usb->externally_controlled) {
> > + /*
> > + * USB controller registers shouldn't be touched before PHY is
> > + * initialized, otherwise CPU will hang because clocks are gated.
> > + * PHY driver controls gating of internal USB clocks on Tegra.
> > + */
> > + err = usb_phy_init(usb->phy);
> > + if (err)
> > + goto fail_power_off;
> > + }
> >
> > /* setup and register ChipIdea HDRC device */
> > usb->soc = soc;
> > @@ -342,12 +348,14 @@ static int tegra_usb_probe(struct platform_device *pdev)
> > if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
> > usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
> >
> > - usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > - pdev->num_resources, &usb->data);
> > - if (IS_ERR(usb->dev)) {
> > - err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> > - "failed to add HDRC device");
> > - goto phy_shutdown;
> > + if (!usb->externally_controlled) {
> > + usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > + pdev->num_resources, &usb->data);
> > + if (IS_ERR(usb->dev)) {
> > + err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> > + "failed to add HDRC device");
> > + goto phy_shutdown;
> > + }
> > }
> >
> > return 0;
> > --
> > 2.51.0
> >
>
> --
>
> Best regards,
> Peter
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled
2026-05-12 6:13 ` Svyatoslav Ryhel
@ 2026-05-12 7:51 ` Peter Chen (CIX)
2026-05-12 9:14 ` Svyatoslav Ryhel
0 siblings, 1 reply; 13+ messages in thread
From: Peter Chen (CIX) @ 2026-05-12 7:51 UTC (permalink / raw)
To: Svyatoslav Ryhel
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, netdev, devicetree, linux-kernel, linux-phy,
linux-tegra, linux-usb
On 26-05-12 09:13:40, Svyatoslav Ryhel wrote:
> вт, 12 трав. 2026 р. о 04:16 Peter Chen (CIX) <peter.chen@kernel.org> пише:
> >
> > On 26-05-11 16:56:57, Svyatoslav Ryhel wrote:
> > > If the USB controller and PHY are externally controlled, then the
> > > registration of the controller and the PHY initialization should be
> > > skipped, since these configurations must be done by the device that
> > > controls the bus to work correctly.
> > >
> >
> > I find you only control USB controller device add at PHY driver, most of USB drivers
> > has PHY control, for chipidea, it has PHY control at core.c, would please try to
> > adapt for it?
> >
>
> Usually yes, but this is not the case for Tegra unfortunately. As you
> can see Tegra specific section of Chipidea driver specifically
> describes why it has to set PHY manually.
>
> /*
> * USB controller registers shouldn't be touched before PHY is
> * initialized, otherwise CPU will hang because clocks are gated.
> * PHY driver controls gating of internal USB clocks on Tegra.
> */
>
> So in order to provide correct work of USB when set by an external
> device, both PHY and controller init/add must be skipped.
You could call generic PHY APIs at ci_hdrc_tegra.c, after PHY init or power on,
call controller initialization.
>
> > Peter
> >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > ---
> > > drivers/usb/chipidea/ci_hdrc_tegra.c | 36 +++++++++++++++++-----------
> > > 1 file changed, 22 insertions(+), 14 deletions(-)
> > >
> > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > index 372788f0f970..593390a818d1 100644
> > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > @@ -32,6 +32,7 @@ struct tegra_usb {
> > > struct clk *clk;
> > >
> > > bool needs_double_reset;
> > > + bool externally_controlled;
> > > };
> > >
> > > struct tegra_usb_soc_info {
> > > @@ -312,20 +313,25 @@ static int tegra_usb_probe(struct platform_device *pdev)
> > > if (device_property_present(&pdev->dev, "nvidia,needs-double-reset"))
> > > usb->needs_double_reset = true;
> > >
> > > + if (device_property_present(&pdev->dev, "nvidia,external-control"))
> > > + usb->externally_controlled = true;
> > > +
> > > err = tegra_usb_reset_controller(&pdev->dev);
> > > if (err) {
> > > dev_err_probe(&pdev->dev, err, "failed to reset controller");
> > > goto fail_power_off;
> > > }
> > >
> > > - /*
> > > - * USB controller registers shouldn't be touched before PHY is
> > > - * initialized, otherwise CPU will hang because clocks are gated.
> > > - * PHY driver controls gating of internal USB clocks on Tegra.
> > > - */
> > > - err = usb_phy_init(usb->phy);
> > > - if (err)
> > > - goto fail_power_off;
> > > + if (!usb->externally_controlled) {
> > > + /*
> > > + * USB controller registers shouldn't be touched before PHY is
> > > + * initialized, otherwise CPU will hang because clocks are gated.
> > > + * PHY driver controls gating of internal USB clocks on Tegra.
> > > + */
> > > + err = usb_phy_init(usb->phy);
> > > + if (err)
> > > + goto fail_power_off;
> > > + }
> > >
> > > /* setup and register ChipIdea HDRC device */
> > > usb->soc = soc;
> > > @@ -342,12 +348,14 @@ static int tegra_usb_probe(struct platform_device *pdev)
> > > if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
> > > usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
> > >
> > > - usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > > - pdev->num_resources, &usb->data);
> > > - if (IS_ERR(usb->dev)) {
> > > - err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> > > - "failed to add HDRC device");
> > > - goto phy_shutdown;
> > > + if (!usb->externally_controlled) {
> > > + usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > > + pdev->num_resources, &usb->data);
> > > + if (IS_ERR(usb->dev)) {
> > > + err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> > > + "failed to add HDRC device");
> > > + goto phy_shutdown;
> > > + }
> > > }
> > >
> > > return 0;
> > > --
> > > 2.51.0
> > >
> >
> > --
> >
> > Best regards,
> > Peter
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled
2026-05-12 7:51 ` Peter Chen (CIX)
@ 2026-05-12 9:14 ` Svyatoslav Ryhel
0 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-12 9:14 UTC (permalink / raw)
To: Peter Chen (CIX)
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, netdev, devicetree, linux-kernel, linux-phy,
linux-tegra, linux-usb
вт, 12 трав. 2026 р. о 10:51 Peter Chen (CIX) <peter.chen@kernel.org> пише:
>
> On 26-05-12 09:13:40, Svyatoslav Ryhel wrote:
> > вт, 12 трав. 2026 р. о 04:16 Peter Chen (CIX) <peter.chen@kernel.org> пише:
> > >
> > > On 26-05-11 16:56:57, Svyatoslav Ryhel wrote:
> > > > If the USB controller and PHY are externally controlled, then the
> > > > registration of the controller and the PHY initialization should be
> > > > skipped, since these configurations must be done by the device that
> > > > controls the bus to work correctly.
> > > >
> > >
> > > I find you only control USB controller device add at PHY driver, most of USB drivers
> > > has PHY control, for chipidea, it has PHY control at core.c, would please try to
> > > adapt for it?
> > >
> >
> > Usually yes, but this is not the case for Tegra unfortunately. As you
> > can see Tegra specific section of Chipidea driver specifically
> > describes why it has to set PHY manually.
> >
> > /*
> > * USB controller registers shouldn't be touched before PHY is
> > * initialized, otherwise CPU will hang because clocks are gated.
> > * PHY driver controls gating of internal USB clocks on Tegra.
> > */
> >
> > So in order to provide correct work of USB when set by an external
> > device, both PHY and controller init/add must be skipped.
>
> You could call generic PHY APIs at ci_hdrc_tegra.c, after PHY init or power on,
> call controller initialization.
>
And what it will give? Modem used in Tegra devices exposes its output
as USB device on an HSIC line. At the same time modem requires a
precise control when USB should be registered, to be able to register
and unregister it. This cannot be done by linking modem's phy to usb
controller, quite the opposite, controller must be linked to modem's
phy.
> >
> > > Peter
> > >
> > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > > ---
> > > > drivers/usb/chipidea/ci_hdrc_tegra.c | 36 +++++++++++++++++-----------
> > > > 1 file changed, 22 insertions(+), 14 deletions(-)
> > > >
> > > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > > index 372788f0f970..593390a818d1 100644
> > > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > > @@ -32,6 +32,7 @@ struct tegra_usb {
> > > > struct clk *clk;
> > > >
> > > > bool needs_double_reset;
> > > > + bool externally_controlled;
> > > > };
> > > >
> > > > struct tegra_usb_soc_info {
> > > > @@ -312,20 +313,25 @@ static int tegra_usb_probe(struct platform_device *pdev)
> > > > if (device_property_present(&pdev->dev, "nvidia,needs-double-reset"))
> > > > usb->needs_double_reset = true;
> > > >
> > > > + if (device_property_present(&pdev->dev, "nvidia,external-control"))
> > > > + usb->externally_controlled = true;
> > > > +
> > > > err = tegra_usb_reset_controller(&pdev->dev);
> > > > if (err) {
> > > > dev_err_probe(&pdev->dev, err, "failed to reset controller");
> > > > goto fail_power_off;
> > > > }
> > > >
> > > > - /*
> > > > - * USB controller registers shouldn't be touched before PHY is
> > > > - * initialized, otherwise CPU will hang because clocks are gated.
> > > > - * PHY driver controls gating of internal USB clocks on Tegra.
> > > > - */
> > > > - err = usb_phy_init(usb->phy);
> > > > - if (err)
> > > > - goto fail_power_off;
> > > > + if (!usb->externally_controlled) {
> > > > + /*
> > > > + * USB controller registers shouldn't be touched before PHY is
> > > > + * initialized, otherwise CPU will hang because clocks are gated.
> > > > + * PHY driver controls gating of internal USB clocks on Tegra.
> > > > + */
> > > > + err = usb_phy_init(usb->phy);
> > > > + if (err)
> > > > + goto fail_power_off;
> > > > + }
> > > >
> > > > /* setup and register ChipIdea HDRC device */
> > > > usb->soc = soc;
> > > > @@ -342,12 +348,14 @@ static int tegra_usb_probe(struct platform_device *pdev)
> > > > if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
> > > > usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
> > > >
> > > > - usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > > > - pdev->num_resources, &usb->data);
> > > > - if (IS_ERR(usb->dev)) {
> > > > - err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> > > > - "failed to add HDRC device");
> > > > - goto phy_shutdown;
> > > > + if (!usb->externally_controlled) {
> > > > + usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > > > + pdev->num_resources, &usb->data);
> > > > + if (IS_ERR(usb->dev)) {
> > > > + err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
> > > > + "failed to add HDRC device");
> > > > + goto phy_shutdown;
> > > > + }
> > > > }
> > > >
> > > > return 0;
> > > > --
> > > > 2.51.0
> > > >
> > >
> > > --
> > >
> > > Best regards,
> > > Peter
>
> --
>
> Best regards,
> Peter
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 3/6] dt-bindings: net: Document Infineon/Intel XMM6260 modem
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
2026-05-11 13:56 ` [PATCH v1 1/6] dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control property Svyatoslav Ryhel
2026-05-11 13:56 ` [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled Svyatoslav Ryhel
@ 2026-05-11 13:56 ` Svyatoslav Ryhel
2026-05-11 13:56 ` [PATCH v1 4/6] net: usb: Add Infineon XMM6260 Baseband modem support Svyatoslav Ryhel
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-11 13:56 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, Svyatoslav Ryhel
Cc: netdev, devicetree, linux-kernel, linux-phy, linux-tegra,
linux-usb
Describe the Infineon/Intel XMM6260, a 3G-focused, slim modem platform
designed for smartphones, data cards, and Machine-to-Machine (M2M)
applications.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
.../bindings/net/infineon,xmm6260.yaml | 72 +++++++++++++++++++
1 file changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/infineon,xmm6260.yaml
diff --git a/Documentation/devicetree/bindings/net/infineon,xmm6260.yaml b/Documentation/devicetree/bindings/net/infineon,xmm6260.yaml
new file mode 100644
index 000000000000..d34d7125274f
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/infineon,xmm6260.yaml
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/infineon,xmm6260.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Infineon/Intel XMM6260 embedded USB modem
+
+description:
+ The Infineon/Intel XMM6260 is a 3G-focused, slim modem platform designed
+ for smartphones, data cards, and Machine-to-Machine (M2M) applications.
+ The modem is usually connected via the application processor's USB line
+ in HSIC mode; however, to work properly, the modem must control this line
+
+maintainers:
+ - Svyatoslav Ryhel <clamor95@gmail.com>
+
+properties:
+ compatible:
+ const: infineon,xmm6260
+
+ interrupts:
+ maxItems: 1
+
+ enable-gpios:
+ description: GPIO connected to the ON1 pin
+ maxItems: 1
+
+ reset-gpios:
+ description: GPIO connected to the RESET_PWRDWN_N pin
+ maxItems: 1
+
+ ap-wake-gpios:
+ description: GPIO connected to the EINT3 pin
+ maxItems: 1
+
+ cp-wake-gpios:
+ description: GPIO connected to the EINT2 pin
+ maxItems: 1
+
+ phys:
+ maxItems: 1
+
+ vbat-supply:
+ description: Supply connected to the VBAT lines.
+
+required:
+ - compatible
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ modem {
+ compatible = "infineon,xmm6260";
+
+ interrupt-parent = <&gpio>;
+ interrupts = <168 IRQ_TYPE_EDGE_BOTH>;
+
+ enable-gpios = <&gpio 112 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio 169 GPIO_ACTIVE_LOW>;
+
+ cp-wake-gpios = <&gpio 151 GPIO_ACTIVE_HIGH>;
+ ap-wake-gpios = <&gpio 168 GPIO_ACTIVE_HIGH>;
+
+ phys = <&xmm6260_phy>;
+ vbat-supply = <&vdd_3v3_vbat>;
+ };
--
2.51.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 4/6] net: usb: Add Infineon XMM6260 Baseband modem support
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
` (2 preceding siblings ...)
2026-05-11 13:56 ` [PATCH v1 3/6] dt-bindings: net: Document Infineon/Intel XMM6260 modem Svyatoslav Ryhel
@ 2026-05-11 13:56 ` Svyatoslav Ryhel
2026-05-11 13:57 ` [PATCH v1 5/6] dt-bindings: phy: tegra: Document Nvidia Tegra XMM6260 PHY Svyatoslav Ryhel
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-11 13:56 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, Svyatoslav Ryhel
Cc: netdev, devicetree, linux-kernel, linux-phy, linux-tegra,
linux-usb
The Infineon/Intel XMM6260 is a 3G-focused, slim modem platform designed
for smartphones, data cards, and Machine-to-Machine (M2M) applications.
The modem is usually connected via the application processor's USB line
in HSIC mode; however, to work properly, the modem must control this line
Dmesg with modem appearing on LG Optimus Vu (P895):
[ 9.427014] ci_hdrc ci_hdrc.1: EHCI Host Controller
[ 9.431488] ci_hdrc ci_hdrc.1: new USB bus registered, assigned bus number 1
[ 9.457197] ci_hdrc ci_hdrc.1: USB 2.0 started, EHCI 1.00
[ 9.460370] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.16
[ 9.468470] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[ 9.475597] usb usb1: Product: EHCI Host Controller
[ 9.480508] usb usb1: Manufacturer: Linux 6.16.0+ ehci_hcd
[ 9.485913] usb usb1: SerialNumber: ci_hdrc.1
[ 9.490862] hub 1-0:1.0: USB hub found
[ 9.494005] hub 1-0:1.0: 1 port detected
[ 9.657191] usb 1-1: new high-speed USB device number 2 using ci_hdrc
[ 9.844726] usb 1-1: New USB device found, idVendor=1519, idProduct=0020, bcdDevice=12.74
[ 9.850530] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 9.857594] usb 1-1: Product: HSIC Device
[ 9.861606] usb 1-1: Manufacturer: Comneon
[ 9.865627] usb 1-1: SerialNumber: 0123456789
[ 9.908739] cdc_acm 1-1:1.0: ttyACM0: USB ACM device
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/net/usb/Kconfig | 15 ++
drivers/net/usb/Makefile | 1 +
drivers/net/usb/baseband-xmm6260.c | 335 +++++++++++++++++++++++++++++
3 files changed, 351 insertions(+)
create mode 100644 drivers/net/usb/baseband-xmm6260.c
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 52a5c0922c79..503f24a3cfa6 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -642,4 +642,19 @@ config USB_RTL8153_ECM
CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
supported by r8152 driver.
+config USB_NET_XMM6260
+ tristate "Infineon XMM626X Baseband HSPA/HSUPA modem"
+ depends on GPIOLIB && OF && USB_CHIPIDEA
+ help
+ Select this if you want to use an Infineon XMM626X modem, found in
+ devices such as the LG Optimus 4X P880, LG Optimus Vu P895, Samsung
+ Galaxy S II (GT-I9100), and Galaxy Nexus (GT-I9250). This driver
+ handles the modem configuration and provides a stable way to expose
+ the modem's USB interface. To establish a connection, you will first
+ need a userspace program to send the correct commands to the modem
+ through its CDC ACM port, as well as a DHCP client.
+
+ To compile this driver as a module, choose M here: the module will
+ be called baseband-xmm6260.
+
endif # USB_NET_DRIVERS
diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
index 4964f7b326fb..ffa532c7d7d6 100644
--- a/drivers/net/usb/Makefile
+++ b/drivers/net/usb/Makefile
@@ -42,3 +42,4 @@ obj-$(CONFIG_USB_NET_CDC_MBIM) += cdc_mbim.o
obj-$(CONFIG_USB_NET_CH9200) += ch9200.o
obj-$(CONFIG_USB_NET_AQC111) += aqc111.o
obj-$(CONFIG_USB_RTL8153_ECM) += r8153_ecm.o
+obj-$(CONFIG_USB_NET_XMM6260) += baseband-xmm6260.o
diff --git a/drivers/net/usb/baseband-xmm6260.c b/drivers/net/usb/baseband-xmm6260.c
new file mode 100644
index 000000000000..658f5351fab7
--- /dev/null
+++ b/drivers/net/usb/baseband-xmm6260.c
@@ -0,0 +1,335 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2011 NVIDIA Corporation
+ * Copyright (C) 2023 Svyatoslav Ryhel <clamor95@gmail.com>
+ */
+
+#include <linux/array_size.h>
+#include <linux/devm-helpers.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/gpio/consumer.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/notifier.h>
+#include <linux/phy/phy.h>
+#include <linux/platform_device.h>
+#include <linux/property.h>
+#include <linux/regulator/consumer.h>
+#include <linux/rfkill.h>
+#include <linux/usb.h>
+
+#define BASEBAND_XMM_INIT_DELAY 5000
+
+#define BASEBAND_PRODUCT_ID_XMM6260 0x0020
+#define BASEBAND_VENDOR_ID_COMNEON 0x1519
+
+enum ipc_ap_wake_state {
+ IPC_AP_WAKE_IRQ_READY,
+ IPC_AP_WAKE_INIT1,
+ IPC_AP_WAKE_INIT2,
+ IPC_AP_WAKE_L,
+ IPC_AP_WAKE_H,
+ IPC_AP_WAKE_UNINIT,
+};
+
+struct baseband_xmm_data {
+ struct device *dev;
+ struct rfkill *rfkill_dev;
+ struct phy *mphy;
+
+ struct gpio_desc *reset_gpio;
+ struct gpio_desc *enable_gpio;
+
+ struct gpio_desc *ipc_cp_gpio;
+ struct gpio_desc *ipc_ap_gpio;
+
+ struct regulator *vbat_supply;
+
+ struct delayed_work modem_work;
+ struct notifier_block nb;
+
+ enum ipc_ap_wake_state ap_state;
+
+ bool powered; /* tracks usb bus state */
+ bool inited; /* tracks modem state */
+};
+
+static int baseband_xmm_usb_notifier_call(struct notifier_block *nb,
+ unsigned long action, void *data)
+{
+ struct baseband_xmm_data *priv =
+ container_of(nb, struct baseband_xmm_data, nb);
+ struct usb_device *udev = data;
+ u16 product = le16_to_cpu(udev->descriptor.idProduct);
+ u16 vendor = le16_to_cpu(udev->descriptor.idVendor);
+
+ switch (action) {
+ case USB_DEVICE_ADD:
+ /* Infineon XMM6260 ID 1519:0020 */
+ if (vendor == BASEBAND_VENDOR_ID_COMNEON &&
+ product == BASEBAND_PRODUCT_ID_XMM6260) {
+ cancel_delayed_work_sync(&priv->modem_work);
+ priv->inited = true;
+ }
+ break;
+ }
+
+ return NOTIFY_OK;
+}
+
+static void baseband_xmm_reset(struct baseband_xmm_data *priv)
+{
+ int ret;
+
+ ret = regulator_enable(priv->vbat_supply);
+ if (ret)
+ dev_err(priv->dev, "failed to enable vbat power supply\n");
+
+ gpiod_set_value_cansleep(priv->enable_gpio, 0);
+ msleep(50);
+
+ gpiod_set_value_cansleep(priv->reset_gpio, 1);
+ msleep(200);
+ gpiod_set_value_cansleep(priv->reset_gpio, 0);
+
+ msleep(50);
+
+ /* falling edge trigger to CP */
+ gpiod_set_value_cansleep(priv->enable_gpio, 1);
+ usleep_range(50, 100);
+ gpiod_set_value_cansleep(priv->enable_gpio, 0);
+ msleep(20);
+}
+
+static int baseband_xmm_set_block(void *data, bool blocked)
+{
+ struct baseband_xmm_data *priv = data;
+
+ if (blocked) {
+ if (priv->inited && priv->powered) {
+ phy_power_off(priv->mphy);
+
+ msleep(500);
+
+ gpiod_set_value_cansleep(priv->reset_gpio, 1);
+ regulator_disable(priv->vbat_supply);
+
+ priv->powered = false;
+ priv->inited = false;
+ }
+ } else {
+ if (priv->inited)
+ return 0;
+
+ priv->ap_state = IPC_AP_WAKE_IRQ_READY;
+ baseband_xmm_reset(priv);
+
+ priv->powered = false;
+ priv->inited = false;
+ }
+
+ return 0;
+}
+
+static const struct rfkill_ops baseband_xmm_rfkill_ops = {
+ .set_block = baseband_xmm_set_block,
+};
+
+static void baseband_xmm_work(struct work_struct *work)
+{
+ struct baseband_xmm_data *priv =
+ container_of(work, struct baseband_xmm_data, modem_work.work);
+
+ switch (priv->ap_state) {
+ case IPC_AP_WAKE_INIT1:
+ if (priv->powered)
+ return;
+
+ phy_power_on(priv->mphy);
+ priv->powered = true;
+ break;
+
+ case IPC_AP_WAKE_INIT2:
+ priv->ap_state = IPC_AP_WAKE_IRQ_READY;
+
+ phy_power_off(priv->mphy);
+
+ priv->powered = false;
+ priv->inited = false;
+
+ msleep(500);
+ break;
+
+ default:
+ break;
+ }
+};
+
+static irqreturn_t baseband_hostwake_interrupt(int irq, void *dev_id)
+{
+ struct baseband_xmm_data *priv = dev_id;
+ int state = gpiod_get_value(priv->ipc_ap_gpio);
+
+ switch (priv->ap_state) {
+ case IPC_AP_WAKE_IRQ_READY:
+ if (!state) {
+ priv->ap_state = IPC_AP_WAKE_INIT1;
+ schedule_delayed_work(&priv->modem_work, 0);
+ }
+
+ break;
+
+ case IPC_AP_WAKE_INIT1:
+ if (state) {
+ priv->ap_state = IPC_AP_WAKE_INIT2;
+ schedule_delayed_work(&priv->modem_work,
+ msecs_to_jiffies(BASEBAND_XMM_INIT_DELAY));
+ }
+
+ break;
+
+ default:
+ break;
+ }
+
+ return IRQ_HANDLED;
+}
+
+static int baseband_xmm_probe(struct platform_device *pdev)
+{
+ struct baseband_xmm_data *priv;
+ struct device *dev = &pdev->dev;
+ unsigned long irqflags;
+ int irq, ret;
+
+ priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+ if (!priv)
+ return -ENOMEM;
+
+ priv->dev = dev;
+ platform_set_drvdata(pdev, priv);
+
+ priv->vbat_supply = devm_regulator_get(dev, "vbat");
+ if (IS_ERR(priv->vbat_supply))
+ return dev_err_probe(dev, PTR_ERR(priv->vbat_supply),
+ "failed to get vbat regulator\n");
+
+ /* Own modem gpios */
+ priv->reset_gpio = devm_gpiod_get_optional(dev, "reset",
+ GPIOD_OUT_LOW);
+ if (IS_ERR(priv->reset_gpio))
+ return dev_err_probe(dev, PTR_ERR(priv->reset_gpio),
+ "failed to get reset GPIO\n");
+
+ priv->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+ GPIOD_OUT_LOW);
+ if (IS_ERR(priv->enable_gpio))
+ return dev_err_probe(dev, PTR_ERR(priv->enable_gpio),
+ "failed to get enable GPIO\n");
+
+ /* CP - AP connections */
+ priv->ipc_cp_gpio = devm_gpiod_get_optional(dev, "cp-wake",
+ GPIOD_OUT_LOW);
+ if (IS_ERR(priv->ipc_cp_gpio))
+ return dev_err_probe(dev, PTR_ERR(priv->ipc_cp_gpio),
+ "failed to get CP wake GPIO\n");
+
+ priv->ipc_ap_gpio = devm_gpiod_get_optional(dev, "ap-wake", GPIOD_IN);
+ if (IS_ERR(priv->ipc_ap_gpio))
+ return dev_err_probe(dev, PTR_ERR(priv->ipc_ap_gpio),
+ "failed to get AP wake GPIO\n");
+
+ /* Modem PHY */
+ priv->mphy = devm_phy_optional_get(dev, NULL);
+ if (IS_ERR(priv->mphy))
+ return dev_err_probe(dev, PTR_ERR(priv->mphy),
+ "failed to get modem PHY");
+
+ /*
+ * Strting from ver 1145 modem starts in READY state. AP wake
+ * interrupt keeps low util CP starts to initiate HSIC hw. AP
+ * wake interrupt goes up during CP HSIC init and then it goes
+ * down when CP HSIC is ready.
+ */
+ priv->ap_state = IPC_AP_WAKE_IRQ_READY;
+ priv->inited = false;
+
+ devm_delayed_work_autocancel(dev, &priv->modem_work, baseband_xmm_work);
+
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return dev_err_probe(dev, irq, "failed to get IRQ\n");
+
+ /*
+ * Systems using device tree should set up interrupt via DT,
+ * the rest will use the default edge both interrupt.
+ */
+ irqflags = dev->of_node ? 0 : IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING;
+
+ ret = devm_request_threaded_irq(dev, irq, NULL,
+ &baseband_hostwake_interrupt,
+ IRQF_ONESHOT | irqflags,
+ "modem-hostwake", priv);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to register IRQ %d\n", irq);
+
+ priv->rfkill_dev = rfkill_alloc("xmm-modem", dev, RFKILL_TYPE_WWAN,
+ &baseband_xmm_rfkill_ops, priv);
+ if (priv->rfkill_dev) {
+ ret = rfkill_register(priv->rfkill_dev);
+ if (ret < 0) {
+ rfkill_destroy(priv->rfkill_dev);
+ return dev_err_probe(dev, ret,
+ "failed to register WWAN rfkill\n");
+ }
+ } else {
+ return dev_err_probe(dev, PTR_ERR(priv->rfkill_dev),
+ "failed to allocate WWAN rfkill\n");
+ }
+
+ priv->nb.notifier_call = baseband_xmm_usb_notifier_call;
+ usb_register_notify(&priv->nb);
+
+ baseband_xmm_reset(priv);
+ priv->powered = false;
+
+ return 0;
+}
+
+static void baseband_xmm_remove(struct platform_device *pdev)
+{
+ struct baseband_xmm_data *priv = platform_get_drvdata(pdev);
+
+ rfkill_unregister(priv->rfkill_dev);
+ rfkill_destroy(priv->rfkill_dev);
+
+ usb_unregister_notify(&priv->nb);
+ phy_power_off(priv->mphy);
+
+ gpiod_set_value_cansleep(priv->reset_gpio, 1);
+ regulator_disable(priv->vbat_supply);
+}
+
+static const struct of_device_id baseband_xmm_match[] = {
+ { .compatible = "infineon,xmm6260" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, baseband_xmm_match);
+
+static struct platform_driver baseband_xmm_driver = {
+ .driver = {
+ .name = "baseband-xmm6260",
+ .of_match_table = baseband_xmm_match,
+ },
+ .probe = baseband_xmm_probe,
+ .remove = baseband_xmm_remove,
+};
+module_platform_driver(baseband_xmm_driver);
+
+MODULE_AUTHOR("Svyatolsav Ryhel <clamor95@gmail.com>");
+MODULE_DESCRIPTION("Baseband Infineon XMM6260 driver");
+MODULE_LICENSE("GPL");
--
2.51.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 5/6] dt-bindings: phy: tegra: Document Nvidia Tegra XMM6260 PHY
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
` (3 preceding siblings ...)
2026-05-11 13:56 ` [PATCH v1 4/6] net: usb: Add Infineon XMM6260 Baseband modem support Svyatoslav Ryhel
@ 2026-05-11 13:57 ` Svyatoslav Ryhel
2026-05-11 13:57 ` [PATCH v1 6/6] phy: tegra: Add support for " Svyatoslav Ryhel
2026-05-12 0:05 ` [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Jakub Kicinski
6 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-11 13:57 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, Svyatoslav Ryhel
Cc: netdev, devicetree, linux-kernel, linux-phy, linux-tegra,
linux-usb
Document the XMM6260 PHY used by various devices based on the Nvidia Tegra
SoC, describing its usage
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
.../bindings/phy/nvidia,tegra-xmm6260.yaml | 58 +++++++++++++++++++
1 file changed, 58 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/nvidia,tegra-xmm6260.yaml
diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra-xmm6260.yaml b/Documentation/devicetree/bindings/phy/nvidia,tegra-xmm6260.yaml
new file mode 100644
index 000000000000..0346433c9772
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/nvidia,tegra-xmm6260.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/nvidia,tegra-xmm6260.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nvidia Tegra PHY for XMM6260 modem
+
+description:
+ A hardware configuration used in Tegra SoCs to provide proper interaction
+ between the application processor and the modem, as well as control over
+ one of the SoC's USB lines for the modem.
+
+maintainers:
+ - Svyatoslav Ryhel <clamor95@gmail.com>
+
+properties:
+ compatible:
+ const: nvidia,tegra-xmm6260
+
+ enable-gpios:
+ description: GPIO connected to the EINT1 pin
+ maxItems: 1
+
+ nvidia,usb-bus:
+ description:
+ Contains two phandles; the first is pointing to the Host's USB controller
+ and the second linking to the controller's PHY.
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ minItems: 2
+ maxItems: 2
+
+ phy-supply:
+ description: Supply powering the PHY.
+
+ "#phy-cells":
+ const: 0
+
+required:
+ - compatible
+ - nvidia,usb-bus
+ - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ phy {
+ compatible = "nvidia,tegra-xmm6260";
+
+ enable-gpios = <&gpio 165 GPIO_ACTIVE_HIGH>;
+ phy-supply = <&vdd_3v3_vbat>;
+
+ nvidia,usb-bus = <&hsic_usb>, <&phy2>;
+ #phy-cells = <0>;
+ };
--
2.51.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v1 6/6] phy: tegra: Add support for Nvidia Tegra XMM6260 PHY
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
` (4 preceding siblings ...)
2026-05-11 13:57 ` [PATCH v1 5/6] dt-bindings: phy: tegra: Document Nvidia Tegra XMM6260 PHY Svyatoslav Ryhel
@ 2026-05-11 13:57 ` Svyatoslav Ryhel
2026-05-12 0:05 ` [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Jakub Kicinski
6 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-11 13:57 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, Svyatoslav Ryhel
Cc: netdev, devicetree, linux-kernel, linux-phy, linux-tegra,
linux-usb
Nvidia Tegra XMM6260 PHY is a hardware configuration used in Tegra SoCs
to provide proper interaction between the application processor and the
modem, as well as control over one of the SoC's USB lines for the modem.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/phy/tegra/Kconfig | 12 +++
drivers/phy/tegra/Makefile | 1 +
drivers/phy/tegra/phy-tegra-xmm6260.c | 144 ++++++++++++++++++++++++++
3 files changed, 157 insertions(+)
create mode 100644 drivers/phy/tegra/phy-tegra-xmm6260.c
diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
index 342fb736da4b..41b5ce460f37 100644
--- a/drivers/phy/tegra/Kconfig
+++ b/drivers/phy/tegra/Kconfig
@@ -18,3 +18,15 @@ config PHY_TEGRA194_P2U
help
Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x
and 234 SOCs.
+
+config PHY_TEGRA_XMM6260
+ tristate "NVIDIA Tegra XMM6260 PHY driver"
+ depends on ARCH_TEGRA && USB_NET_XMM6260 && USB_SUPPORT
+ select GENERIC_PHY
+ help
+ Enable this to support XMM6260 modem found in various Tegra devices
+ with cellular capabilities, like LG Optimus 4X P880, LG Optimus Vu
+ P895, Google Nexus 7 (2012) 3G and ASUS Transformer Pad 3G TF300TG.
+
+ To compile this driver as a module, choose M here: the module will
+ be called phy-tegra-xmm6260.
diff --git a/drivers/phy/tegra/Makefile b/drivers/phy/tegra/Makefile
index eeeea72de117..829e298ee56c 100644
--- a/drivers/phy/tegra/Makefile
+++ b/drivers/phy/tegra/Makefile
@@ -9,3 +9,4 @@ phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_186_SOC) += xusb-tegra186.o
phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_194_SOC) += xusb-tegra186.o
phy-tegra-xusb-$(CONFIG_ARCH_TEGRA_234_SOC) += xusb-tegra186.o
obj-$(CONFIG_PHY_TEGRA194_P2U) += phy-tegra194-p2u.o
+obj-$(CONFIG_PHY_TEGRA_XMM6260) += phy-tegra-xmm6260.o
diff --git a/drivers/phy/tegra/phy-tegra-xmm6260.c b/drivers/phy/tegra/phy-tegra-xmm6260.c
new file mode 100644
index 000000000000..7511de1333aa
--- /dev/null
+++ b/drivers/phy/tegra/phy-tegra-xmm6260.c
@@ -0,0 +1,144 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/gpio/consumer.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/phy/phy.h>
+#include <linux/platform_device.h>
+#include <linux/regulator/consumer.h>
+#include <linux/usb.h>
+#include <linux/usb/chipidea.h>
+#include <linux/usb/phy.h>
+
+struct tegra_usb_device {
+ struct ci_hdrc_platform_data data;
+ struct platform_device *dev;
+};
+
+struct tegra_xmm6260_phy {
+ struct device *dev;
+ struct platform_device *usb_dev;
+ struct usb_phy *usb_phy;
+ struct gpio_desc *enable_gpio;
+};
+
+static int tegra_xmm6260_phy_power_on(struct phy *phy)
+{
+ struct tegra_xmm6260_phy *mphy = phy_get_drvdata(phy);
+ struct tegra_usb_device *usb = platform_get_drvdata(mphy->usb_dev);
+ int ret;
+
+ gpiod_set_value_cansleep(mphy->enable_gpio, 1);
+
+ ret = usb_phy_init(mphy->usb_phy);
+ if (ret) {
+ gpiod_set_value_cansleep(mphy->enable_gpio, 0);
+ return dev_err_probe(mphy->dev, ret,
+ "failed to init USB PHY\n");
+ }
+
+ usb->dev = ci_hdrc_add_device(&mphy->usb_dev->dev,
+ mphy->usb_dev->resource,
+ mphy->usb_dev->num_resources,
+ &usb->data);
+ if (IS_ERR(usb->dev)) {
+ gpiod_set_value_cansleep(mphy->enable_gpio, 0);
+ usb_phy_shutdown(mphy->usb_phy);
+ return dev_err_probe(mphy->dev, PTR_ERR(usb->dev),
+ "failed to register USB controller\n");
+ }
+
+ return 0;
+}
+
+static int tegra_xmm6260_phy_power_off(struct phy *phy)
+{
+ struct tegra_xmm6260_phy *mphy = phy_get_drvdata(phy);
+ struct tegra_usb_device *usb = platform_get_drvdata(mphy->usb_dev);
+
+ ci_hdrc_remove_device(usb->dev);
+ usb_phy_shutdown(mphy->usb_phy);
+
+ gpiod_set_value_cansleep(mphy->enable_gpio, 0);
+
+ return 0;
+}
+
+static const struct phy_ops tegra_xmm6260_phy_ops = {
+ .power_on = tegra_xmm6260_phy_power_on,
+ .power_off = tegra_xmm6260_phy_power_off,
+ .owner = THIS_MODULE,
+};
+
+static int tegra_xmm6260_phy_probe(struct platform_device *pdev)
+{
+ struct phy_provider *phy_provider;
+ struct device *dev = &pdev->dev;
+ struct device_node *usb_node;
+ struct phy *generic_phy;
+ struct tegra_xmm6260_phy *mphy;
+
+ mphy = devm_kzalloc(dev, sizeof(*mphy), GFP_KERNEL);
+ if (!mphy)
+ return -ENOMEM;
+
+ mphy->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+ GPIOD_OUT_LOW);
+ if (IS_ERR(mphy->enable_gpio))
+ return dev_err_probe(dev, PTR_ERR(mphy->enable_gpio),
+ "failed to get enable GPIO\n");
+
+ usb_node = of_parse_phandle(dev->of_node, "nvidia,usb-bus", 0);
+ if (IS_ERR(usb_node))
+ return dev_err_probe(dev, PTR_ERR(usb_node),
+ "failed to parse modem USB bus\n");
+
+ mphy->usb_dev = of_find_device_by_node(usb_node);
+ of_node_put(usb_node);
+ if (!mphy->usb_dev)
+ return dev_err_probe(dev, -ENODEV,
+ "failed to get modem USB bus\n");
+
+ mphy->usb_phy = devm_usb_get_phy_by_phandle(dev, "nvidia,usb-bus", 1);
+ if (IS_ERR(mphy->usb_phy))
+ return dev_err_probe(dev, PTR_ERR(mphy->usb_phy),
+ "failed to get USB PHY");
+
+ generic_phy = devm_phy_create(dev, NULL, &tegra_xmm6260_phy_ops);
+ if (IS_ERR(generic_phy))
+ return dev_err_probe(dev, PTR_ERR(generic_phy),
+ "failed to create PHY\n");
+
+ phy_set_drvdata(generic_phy, mphy);
+ mphy->dev = dev;
+
+ phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+ if (IS_ERR(phy_provider))
+ return dev_err_probe(dev, PTR_ERR(phy_provider),
+ "failed to register PHY\n");
+
+ return 0;
+}
+
+static const struct of_device_id tegra_xmm6260_phy_match[] = {
+ { .compatible = "nvidia,tegra-xmm6260" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, tegra_xmm6260_phy_match);
+
+static struct platform_driver tegra_xmm6260_phy_driver = {
+ .driver = {
+ .name = "tegra-xmm6260-phy",
+ .of_match_table = tegra_xmm6260_phy_match,
+ },
+ .probe = tegra_xmm6260_phy_probe,
+};
+module_platform_driver(tegra_xmm6260_phy_driver);
+
+MODULE_AUTHOR("Svyatolsav Ryhel <clamor95@gmail.com>");
+MODULE_DESCRIPTION("Tegra XMM6260 PHY driver");
+MODULE_LICENSE("GPL");
--
2.51.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem
2026-05-11 13:56 [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Svyatoslav Ryhel
` (5 preceding siblings ...)
2026-05-11 13:57 ` [PATCH v1 6/6] phy: tegra: Add support for " Svyatoslav Ryhel
@ 2026-05-12 0:05 ` Jakub Kicinski
2026-05-12 6:05 ` Svyatoslav Ryhel
6 siblings, 1 reply; 13+ messages in thread
From: Jakub Kicinski @ 2026-05-12 0:05 UTC (permalink / raw)
To: Svyatoslav Ryhel
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, netdev, devicetree, linux-kernel,
linux-phy, linux-tegra, linux-usb
On Mon, 11 May 2026 16:56:55 +0300 Svyatoslav Ryhel wrote:
> dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control
> property
> usb: chipidea: tegra: Avoid controller/PHY init if bus is externally
> controlled
> dt-bindings: net: Document Infineon/Intel XMM6260 modem
> net: usb: Add Infineon XMM6260 Baseband modem support
> dt-bindings: phy: tegra: Document Nvidia Tegra XMM6260 PHY
> phy: tegra: Add support for Nvidia Tegra XMM6260 PHY
You need to split this more on subsystem boundaries.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem
2026-05-12 0:05 ` [PATCH v1 0/6] Add support for Infineon/Intel XMM6260 modem Jakub Kicinski
@ 2026-05-12 6:05 ` Svyatoslav Ryhel
0 siblings, 0 replies; 13+ messages in thread
From: Svyatoslav Ryhel @ 2026-05-12 6:05 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
Neil Armstrong, Thierry Reding, Jonathan Hunter,
Greg Kroah-Hartman, Peter Chen, netdev, devicetree, linux-kernel,
linux-phy, linux-tegra, linux-usb
вт, 12 трав. 2026 р. о 03:05 Jakub Kicinski <kuba@kernel.org> пише:
>
> On Mon, 11 May 2026 16:56:55 +0300 Svyatoslav Ryhel wrote:
> > dt-bindings: usb: ci-hdrc-usb2: Document nvidia,external-control
> > property
> > usb: chipidea: tegra: Avoid controller/PHY init if bus is externally
> > controlled
> > dt-bindings: net: Document Infineon/Intel XMM6260 modem
> > net: usb: Add Infineon XMM6260 Baseband modem support
> > dt-bindings: phy: tegra: Document Nvidia Tegra XMM6260 PHY
> > phy: tegra: Add support for Nvidia Tegra XMM6260 PHY
>
> You need to split this more on subsystem boundaries.
Yes, I will in v2. I needed an initial patchset combined to have a
reference point and show that all patches are logically linked.
^ permalink raw reply [flat|nested] 13+ messages in thread