From: Jakub Kicinski <kuba@kernel.org>
To: "Nitka, Grzegorz" <grzegorz.nitka@intel.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Oros, Petr" <poros@redhat.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Prathosh.Satish@microchip.com" <Prathosh.Satish@microchip.com>,
"Vecera, Ivan" <ivecera@redhat.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>,
"vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>,
"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
"horms@kernel.org" <horms@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>
Subject: Re: [PATCH v14 net-next 03/13] dpll: fix stale iteration in dpll_pin_on_pin_unregister()
Date: Sat, 13 Jun 2026 13:27:53 -0700 [thread overview]
Message-ID: <20260613132753.2b3d1f07@kernel.org> (raw)
In-Reply-To: <IA1PR11MB6219B836E61D44198B0FB5AF921B2@IA1PR11MB6219.namprd11.prod.outlook.com>
On Thu, 11 Jun 2026 18:36:14 +0000 Nitka, Grzegorz wrote:
> For v14 patchset, I got only comments from Arek and Paolo.
> In my opinion, after rethinking, Arek's concerns are not valid (explained in
> the responses). Maybe I could squash some changes, but the final code would
> remain the same as for v14.
>
> Paolo raised 'Fixes' tags which I added and critical divide-by-zero panic
> Regarding 'Fixes' tag, It might be my fault or misunderstanding.
> I can remove them if we want and re-send the series.
> Regarding div-by-zero - see my comments about AI concern list below.
>
> Also, what was raised by AI, I unintentionally changed WARN_ON to WARN_ON_ONCE
> in patch 2. I'd restore it to WARN_ON.
Alright, let me apply this.
But please investigate the situation with the notifications.
Maybe there are two create notifications because we add more info
to the second one? If not we should drop the duplicates.. YNL can
monitor the notifications during tests if you need a repro.
You can follow up with the fixes during the merge window.
next prev parent reply other threads:[~2026-06-13 20:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 18:30 [PATCH v14 net-next 00/13] dpll/ice: Add generic DPLL type and full TX reference clock control for E825 Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 01/13] dpll: add generic DPLL type Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 02/13] dpll: allow registering FW-identified pin with a different DPLL Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 03/13] dpll: fix stale iteration in dpll_pin_on_pin_unregister() Grzegorz Nitka
2026-06-08 16:51 ` Kubalewski, Arkadiusz
2026-06-09 6:50 ` Nitka, Grzegorz
2026-06-11 8:50 ` Paolo Abeni
2026-06-11 10:01 ` Nitka, Grzegorz
2026-06-11 14:41 ` Paolo Abeni
2026-06-11 17:41 ` Jakub Kicinski
2026-06-11 18:36 ` Nitka, Grzegorz
2026-06-13 20:27 ` Jakub Kicinski [this message]
2026-06-07 18:30 ` [PATCH v14 net-next 04/13] dpll: send delete notification before unregister in on-pin rollback Grzegorz Nitka
2026-06-08 16:45 ` Kubalewski, Arkadiusz
2026-06-09 7:09 ` Nitka, Grzegorz
2026-06-10 19:42 ` Nitka, Grzegorz
2026-06-10 21:27 ` Nitka, Grzegorz
2026-06-07 18:30 ` [PATCH v14 net-next 05/13] dpll: emit per-dpll delete notifications in dpll_pin_on_pin_unregister() Grzegorz Nitka
2026-06-08 16:40 ` Kubalewski, Arkadiusz
2026-06-07 18:30 ` [PATCH v14 net-next 06/13] dpll: guard sync-pair removal on full pin unregister Grzegorz Nitka
2026-06-08 16:38 ` Kubalewski, Arkadiusz
2026-06-07 18:30 ` [PATCH v14 net-next 07/13] dpll: balance create/delete notifications in __dpll_pin_(un)register Grzegorz Nitka
2026-06-08 16:35 ` Kubalewski, Arkadiusz
2026-06-07 18:30 ` [PATCH v14 net-next 08/13] dpll: extend pin notifier with notification source ID Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 09/13] dpll: allow fwnode pins to attempt state change without capability bit Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 10/13] ice: introduce TXC DPLL device and TX ref clock pin framework for E825 Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 11/13] ice: implement CPI support for E825C Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 12/13] ice: add Tx reference clock index handling to AN restart command Grzegorz Nitka
2026-06-07 18:30 ` [PATCH v14 net-next 13/13] ice: implement E825 TX ref clock control and TXC hardware sync status Grzegorz Nitka
2026-06-13 20:40 ` [PATCH v14 net-next 00/13] dpll/ice: Add generic DPLL type and full TX reference clock control for E825 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613132753.2b3d1f07@kernel.org \
--to=kuba@kernel.org \
--cc=Prathosh.Satish@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=grzegorz.nitka@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox