* [PATCH] e1000: Remove redundant else after return
@ 2026-06-16 21:00 Lovekesh Solanki
2026-06-16 21:51 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Lovekesh Solanki @ 2026-06-16 21:00 UTC (permalink / raw)
To: anthony.l.nguyen
Cc: przemyslaw.kitszel, andrew+netdev, davem, edumazet, kuba, pabeni,
netdev, Lovekesh Solanki
The else branch is needless because the preceding branch
unconditionally returns -ENOMEM
Reduce nesting by removing unnecessary else
Signed-off-by: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 9b09eb144b81..3d97e952c916 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -1546,11 +1546,10 @@ static int e1000_setup_tx_resources(struct e1000_adapter *adapter,
"for the transmit descriptor ring\n");
vfree(txdr->buffer_info);
return -ENOMEM;
- } else {
+ }
/* Free old allocation, new allocation was successful */
dma_free_coherent(&pdev->dev, txdr->size, olddesc,
olddma);
- }
}
memset(txdr->desc, 0, txdr->size);
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] e1000: Remove redundant else after return
2026-06-16 21:00 [PATCH] e1000: Remove redundant else after return Lovekesh Solanki
@ 2026-06-16 21:51 ` Andrew Lunn
2026-06-17 7:58 ` Lovekesh Solanki
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2026-06-16 21:51 UTC (permalink / raw)
To: Lovekesh Solanki
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, netdev
On Wed, Jun 17, 2026 at 02:30:08AM +0530, Lovekesh Solanki wrote:
> The else branch is needless because the preceding branch
> unconditionally returns -ENOMEM
>
> Reduce nesting by removing unnecessary else
>
> Signed-off-by: Lovekesh Solanki <lovekeshsolanki00@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 9b09eb144b81..3d97e952c916 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -1546,11 +1546,10 @@ static int e1000_setup_tx_resources(struct e1000_adapter *adapter,
> "for the transmit descriptor ring\n");
> vfree(txdr->buffer_info);
> return -ENOMEM;
> - } else {
> + }
> /* Free old allocation, new allocation was successful */
> dma_free_coherent(&pdev->dev, txdr->size, olddesc,
> olddma);
> - }
Hi Lovekesh
Please review this patch yourself and tell us what is wrong with it.
Also, please read
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew
---
pw-bot: cr
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] e1000: Remove redundant else after return
2026-06-16 21:51 ` Andrew Lunn
@ 2026-06-17 7:58 ` Lovekesh Solanki
2026-06-17 9:36 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Lovekesh Solanki @ 2026-06-17 7:58 UTC (permalink / raw)
To: andrew
Cc: andrew+netdev, anthony.l.nguyen, davem, edumazet, kuba,
lovekeshsolanki00, netdev, pabeni, przemyslaw.kitszel
Hi Andrew,
I read the documentation you linked and understand simple standalone
cleanups are discouraged.
Thanks for the review, I will drop this patch.
Regards,
Lovekesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] e1000: Remove redundant else after return
2026-06-17 7:58 ` Lovekesh Solanki
@ 2026-06-17 9:36 ` Andrew Lunn
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2026-06-17 9:36 UTC (permalink / raw)
To: Lovekesh Solanki
Cc: andrew+netdev, anthony.l.nguyen, davem, edumazet, kuba, netdev,
pabeni, przemyslaw.kitszel
On Wed, Jun 17, 2026 at 01:28:55PM +0530, Lovekesh Solanki wrote:
> Hi Andrew,
>
> I read the documentation you linked and understand simple standalone
> cleanups are discouraged.
You also said in the commit message it reduced the indentation level,
but you did not actually reduce the indentation!
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-17 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 21:00 [PATCH] e1000: Remove redundant else after return Lovekesh Solanki
2026-06-16 21:51 ` Andrew Lunn
2026-06-17 7:58 ` Lovekesh Solanki
2026-06-17 9:36 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox