Netdev List
 help / color / mirror / Atom feed
From: Ali Rouhi <arouhi@sitime.com>
To: "jiri@resnulli.us" <jiri@resnulli.us>,
	"vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>,
	"ivecera@redhat.com" <ivecera@redhat.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"arkadiusz.kubalewski@intel.com" <arkadiusz.kubalewski@intel.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"cjubran@nvidia.com" <cjubran@nvidia.com>,
	"Oleg.Zadorozhnyi@devoxsoftware.com"
	<Oleg.Zadorozhnyi@devoxsoftware.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver
Date: Tue, 25 Aug 2026 21:55:24 +0000	[thread overview]
Message-ID: <20260825215523.84195-1-arouhi@sitime.com> (raw)
In-Reply-To: <ao1Zh0uHO0mWj-2t@FV6GYCPJ69>

On 25/08/2026 11:00, Jiri Pirko wrote:
> It's a new driver. Linear review in one hunk. I think it is better that
> way as you see the whole thing right away.

Jiri, Vadim, Ivan - the reviews point in opposite directions, so I would
rather ask than guess.

Vadim asked for a split. Ivan agreed with him, suggested low-level ops,
then core ops, then features one by one, and pointed at the zl3073x git
history as the example to follow. I agreed to that, and the plan for v8
was 13 patches on that shape, each building and working on its own, with
the end state identical to v7. Jiri would rather it stayed one patch.

The breakdown is in my reply of 21 August, in case it did not reach your
mailbox:

https://lore.kernel.org/netdev/20260821010556.95192-1-arouhi@sitime.com/

Tell me which you would rather have and I will do that. My default is to
go ahead with the split.

Thanks,
Ali

  reply	other threads:[~2026-08-25 21:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 22:19 [PATCH net-next v7 0/3] dpll: add SiTime SiT9531x DPLL clock driver Ali Rouhi
2026-08-15 22:19 ` [PATCH net-next v7 2/3] dt-bindings: dpll: add SiTime SiT95316 clock generator Ali Rouhi
2026-08-15 22:19 ` [PATCH net-next v7 1/3] dt-bindings: vendor-prefixes: add SiTime Corporation Ali Rouhi
2026-08-15 22:19 ` [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver Ali Rouhi
2026-08-18 17:06   ` Jakub Kicinski
2026-08-19 21:16   ` Vadim Fedorenko
2026-08-20 17:27     ` Ivan Vecera
2026-08-21  1:06       ` Ali Rouhi
2026-08-21  1:05     ` Ali Rouhi
2026-08-25  9:00     ` Jiri Pirko
2026-08-25 21:55       ` Ali Rouhi [this message]
2026-08-27 17:12         ` Jiri Pirko
2026-08-20 17:57   ` Ivan Vecera
2026-08-21  1:06     ` Ali Rouhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825215523.84195-1-arouhi@sitime.com \
    --to=arouhi@sitime.com \
    --cc=Oleg.Zadorozhnyi@devoxsoftware.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=cjubran@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox