[PATCH net-next v2] tcp: fix mdev comment in tcp_rtt_estimator()

[PATCH net-next v2] tcp: fix mdev comment in tcp_rtt_estimator()

[Ziran Zhang]

The old comment "mdev = 3/4 mdev + 1/4 new" only describes the
common case. However, when RTT decreases and |rtt - srtt| > mdev/4,
the code applies a finer gain of 1/32 instead of 1/4, resulting in:
mdev = 31/32 mdev + 1/32 * new.

Express both cases with a unified formula using variable
gain g.

Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>
---
 net/ipv4/tcp_input.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 0f60a1dbf..b4a6aba21 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1108,7 +1108,11 @@ static void tcp_rtt_estimator(struct sock *sk, long mrtt_us)
 		} else {
 			m -= (tp->mdev_us >> 2);   /* similar update on mdev */
 		}
-		tp->mdev_us += m;		/* mdev = 3/4 mdev + 1/4 new */
+		tp->mdev_us += m;		/*
+						 * mdev = (1-g)*mdev + g*new, g=1/4 normally,
+						 * g=1/32 on RTT decrease when
+						 * abs(rtt - srtt) > mdev/4
+						 */
 		if (tp->mdev_us > tp->mdev_max_us) {
 			tp->mdev_max_us = tp->mdev_us;
 			if (tp->mdev_max_us > tp->rttvar_us)
-- 
2.51.0

Re: [PATCH net-next v2] tcp: fix mdev comment in tcp_rtt_estimator()

[Eric Dumazet]

On Thu, Sep 3, 2026 at 12:13 PM Ziran Zhang <zhangcoder@yeah.net> wrote:
>
> The old comment "mdev = 3/4 mdev + 1/4 new" only describes the
> common case. However, when RTT decreases and |rtt - srtt| > mdev/4,
> the code applies a finer gain of 1/32 instead of 1/4, resulting in:
> mdev = 31/32 mdev + 1/32 * new.
>
> Express both cases with a unified formula using variable
> gain g.
>
> Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>

We asked you to leave this comment as it is. Thank you.

pw-bot: rejected

Re: [PATCH net-next v2] tcp: fix mdev comment in tcp_rtt_estimator()

[Ziran Zhang]

On Thu, 3 Sep 2026 12:21:45 +0200, Eric Dumazet <edumazet@google.com> wrote:
> We asked you to leave this comment as it is. Thank you.

> pw-bot: rejected

Hi Eric,

Thanks for your final decision. I understand and will respect it.

I learned a lot about the RTO estimator logic through this discussion,
so the time was well spent.

Best,
Ziran Zhang