From: Kuniyuki Iwashima <kuniyu@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Ido Schimmel <idosch@nvidia.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH v2 net 0/4] neighbour: Small fixes for RTM_{GET,SET}NEIGHTBL.
Date: Tue, 8 Sep 2026 21:12:44 +0000 [thread overview]
Message-ID: <20260908211419.882954-1-kuniyu@google.com> (raw)
While working on the follow-up suggested here,
https://lore.kernel.org/netdev/20260902143023.GA3966681@shredder/
I found a few bugs in RTM_GETNEIGHTBL and RTM_SETNEIGHTBL,
which this series fixes.
Patch 1, 3, 4 will conflict with net-next in neightbl_dump_info()
due to removal of net_eq() below:
p = list_next_entry(&tbl->parms, list);
list_for_each_entry_from_rcu(p, &tbl->parms_list, list) {
if (!net_eq(neigh_parms_net(p), net))
continue;
Note also that currently neigh_proc_dointvec_ms_jiffies_positive()
is buggy and does not enforce min/max, and it needs this fix:
https://lore.kernel.org/linux-fsdevel/20260905233819.1064529-2-kuniyu@google.com/
Changes:
v2:
* Patch 1
* Use list_for_each_entry_rcu() and skip the default parms
* Patch 2
* Clarify the attribute is for NTF_MANAGED
* Update docs, rt-neigh.yaml and ip-sysctl.rst
v1: https://lore.kernel.org/netdev/20260907215853.3709987-1-kuniyu@google.com/
Kuniyuki Iwashima (4):
neighbour: Add missing RCU annotation for neightbl_dump_info().
neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS.
neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL.
neighbour: Skip default parms when resumed in neightbl_dump_info().
Documentation/netlink/specs/rt-neigh.yaml | 2 ++
Documentation/networking/ip-sysctl.rst | 2 +-
net/core/neighbour.c | 35 +++++++++++++++++------
3 files changed, 29 insertions(+), 10 deletions(-)
--
2.55.0.979.g7e5102b832-goog
next reply other threads:[~2026-09-08 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 21:12 Kuniyuki Iwashima [this message]
2026-09-08 21:12 ` [PATCH v2 net 1/4] neighbour: Add missing RCU annotation for neightbl_dump_info() Kuniyuki Iwashima
2026-09-09 6:42 ` Ido Schimmel
2026-09-08 21:12 ` [PATCH v2 net 2/4] neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS Kuniyuki Iwashima
2026-09-09 6:51 ` Ido Schimmel
2026-09-09 6:55 ` Ido Schimmel
2026-09-09 16:44 ` Kuniyuki Iwashima
2026-09-08 21:12 ` [PATCH v2 net 3/4] neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL Kuniyuki Iwashima
2026-09-09 6:42 ` Ido Schimmel
2026-09-08 21:12 ` [PATCH v2 net 4/4] neighbour: Skip default parms when resumed in neightbl_dump_info() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908211419.882954-1-kuniyu@google.com \
--to=kuniyu@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox