From: Ido Schimmel <idosch@nvidia.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org, Xin Long <lucien.xin@gmail.com>
Subject: Re: [PATCH v2 net 3/4] neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL.
Date: Wed, 9 Sep 2026 09:42:36 +0300 [thread overview]
Message-ID: <20260909064236.GB1183641@shredder> (raw)
In-Reply-To: <20260908211419.882954-4-kuniyu@google.com>
On Tue, Sep 08, 2026 at 09:12:47PM +0000, Kuniyuki Iwashima wrote:
> The cited commits started to initialise blackhole_netdev with
> neigh_parms_alloc().
>
> This is visible in init_net as the ifindex==0 entries via
> RTM_GETNEIGHTBL:
>
> # ynl --family rt-neigh --dump getneightbl --output-json \
> | jq '.[] | select(.parms.ifindex == 0)
> | {name: .name, ifindex: .parms.ifindex}'
> {
> "name": "arp_cache",
> "ifindex": 0
> }
> {
> "name": "ndisc_cache",
> "ifindex": 0
> }
>
> For RTM_SETNEIGHTBL, ifindex being 0 means wildcard.
>
> Let's skip blackhole_netdev's parms in neightbl_dump_info().
>
> Note that lookup_neigh_parms() does not need the same change
> because the default parms is always the first entry and matches
> with ifindex == 0.
>
> Fixes: e5f80fcf869a ("ipv6: give an IPv6 dev to blackhole_netdev")
> Fixes: 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-09-09 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 21:12 [PATCH v2 net 0/4] neighbour: Small fixes for RTM_{GET,SET}NEIGHTBL Kuniyuki Iwashima
2026-09-08 21:12 ` [PATCH v2 net 1/4] neighbour: Add missing RCU annotation for neightbl_dump_info() Kuniyuki Iwashima
2026-09-09 6:42 ` Ido Schimmel
2026-09-08 21:12 ` [PATCH v2 net 2/4] neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS Kuniyuki Iwashima
2026-09-09 6:51 ` Ido Schimmel
2026-09-09 6:55 ` Ido Schimmel
2026-09-09 16:44 ` Kuniyuki Iwashima
2026-09-08 21:12 ` [PATCH v2 net 3/4] neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL Kuniyuki Iwashima
2026-09-09 6:42 ` Ido Schimmel [this message]
2026-09-08 21:12 ` [PATCH v2 net 4/4] neighbour: Skip default parms when resumed in neightbl_dump_info() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909064236.GB1183641@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox