From: Ido Schimmel <idosch@nvidia.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org, Yuwei Wang <wangyuweihx@gmail.com>
Subject: Re: [PATCH v2 net 2/4] neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS.
Date: Wed, 9 Sep 2026 09:55:46 +0300 [thread overview]
Message-ID: <20260909065546.GA1205208@shredder> (raw)
In-Reply-To: <20260909065116.GC1183641@shredder>
On Wed, Sep 09, 2026 at 09:51:16AM +0300, Ido Schimmel wrote:
> On Tue, Sep 08, 2026 at 09:12:46PM +0000, Kuniyuki Iwashima wrote:
> > diff --git a/Documentation/netlink/specs/rt-neigh.yaml b/Documentation/netlink/specs/rt-neigh.yaml
> > index 0f46ef313590..5ec57d95d7f6 100644
> > --- a/Documentation/netlink/specs/rt-neigh.yaml
> > +++ b/Documentation/netlink/specs/rt-neigh.yaml
> > @@ -341,6 +341,8 @@ attribute-sets:
> > -
> > name: interval-probe-time-ms
> > type: u64
> > + min: 1
> > + max: 86400000
>
> This differs from what I suggested [1] and fails validation:
>
> $ tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/rt-neigh.yaml \
> --schema Documentation/netlink/netlink-raw.yaml --validate
> [...]
> jsonschema.exceptions.ValidationError: Additional properties are not allowed ('max', 'min' were unexpected)
> [...]
> On instance['attribute-sets'][2]['attributes'][18]:
> {'name': 'interval-probe-time-ms',
> 'type': 'u64',
> 'min': 1,
> 'max': 86400000}
>
> Works fine with this diff [2]:
>
> $ tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/rt-neigh.yaml \
> --schema Documentation/netlink/netlink-raw.yaml --validate
> $ echo $?
> 0
BTW, patch LGTM otherwise, so you can add my tag to v3. Thanks!
next prev parent reply other threads:[~2026-09-09 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 21:12 [PATCH v2 net 0/4] neighbour: Small fixes for RTM_{GET,SET}NEIGHTBL Kuniyuki Iwashima
2026-09-08 21:12 ` [PATCH v2 net 1/4] neighbour: Add missing RCU annotation for neightbl_dump_info() Kuniyuki Iwashima
2026-09-09 6:42 ` Ido Schimmel
2026-09-08 21:12 ` [PATCH v2 net 2/4] neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS Kuniyuki Iwashima
2026-09-09 6:51 ` Ido Schimmel
2026-09-09 6:55 ` Ido Schimmel [this message]
2026-09-09 16:44 ` Kuniyuki Iwashima
2026-09-08 21:12 ` [PATCH v2 net 3/4] neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL Kuniyuki Iwashima
2026-09-09 6:42 ` Ido Schimmel
2026-09-08 21:12 ` [PATCH v2 net 4/4] neighbour: Skip default parms when resumed in neightbl_dump_info() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909065546.GA1205208@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangyuweihx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox