Netdev List
 help / color / mirror / Atom feed
* [PATCH net 0/4] eth: fbnic: queue stop fixes
@ 2026-11-21  3:32 Dimitri Daskalakis
  2026-11-21  3:32 ` [PATCH net 1/4] eth: fbnic: restart queues in place when fbnic_queue_stop() fails Dimitri Daskalakis
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Dimitri Daskalakis @ 2026-11-21  3:32 UTC (permalink / raw)
  To: David S. Miller
  Cc: Alexander Duyck, Jakub Kicinski, kernel-team, Andrew Lunn,
	Eric Dumazet, Paolo Abeni, Willem de Bruijn, Simon Horman,
	Björn Töpel, Bobby Eshleman, Mina Almasry,
	Dimitri Daskalakis, netdev, Dimitri Daskalakis

From: Dimitri Daskalakis <daskald@meta.com>

AI uncovered some pre-existing issues with fbnic's queue stop handling.
If the idle wait fails in fbnic_queue_stop(), queues can be reset with
in-flight DMAs and completions. fbnic_queue_stop() did not wait for in-flight
xmits to complete before tearing down queues. And fbnic_wait_queue_idle()
waited on the wrong idle bits for Tx queues.

Patches 1 and 3 were verified on HW, and patch 4 was verified in QEMU.

Dimitri Daskalakis (4):
  eth: fbnic: restart queues in place when fbnic_queue_stop() fails
  net: add netif_disable_subqueue()
  eth: fbnic: wait for in-flight xmit in fbnic_queue_stop()
  eth: fbnic: wait for both TWQs of a Tx queue to go idle

 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 84 ++++++++++++++++----
 include/linux/netdevice.h                    | 36 ++++++---
 2 files changed, 91 insertions(+), 29 deletions(-)

-- 
2.52.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-21  3:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  3:32 [PATCH net 0/4] eth: fbnic: queue stop fixes Dimitri Daskalakis
2026-11-21  3:32 ` [PATCH net 1/4] eth: fbnic: restart queues in place when fbnic_queue_stop() fails Dimitri Daskalakis
2026-11-21  3:32 ` [PATCH net 2/4] net: add netif_disable_subqueue() Dimitri Daskalakis
2026-11-21  3:32 ` [PATCH net 3/4] eth: fbnic: wait for in-flight xmit in fbnic_queue_stop() Dimitri Daskalakis
2026-11-21  3:32 ` [PATCH net 4/4] eth: fbnic: wait for both TWQs of a Tx queue to go idle Dimitri Daskalakis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox