Netdev List
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Willem de Bruijn <willemb@google.com>,
	matttbe@kernel.org, intel-wired-lan@lists.osuosl.org,
	netdev@vger.kernel.org, thomas.petazzoni@bootlin.com
Subject: [PATCH iwl-next 0/3] igb: Align the flow-control behaviour with ethtool's specs
Date: Sat, 21 Nov 2026 11:36:09 +0100	[thread overview]
Message-ID: <20261121103613.166611-1-maxime.chevallier@bootlin.com> (raw)

Hi,

This series makes a few changes in IGB's ethtool flow-control
configuration to align it with the ethtool expectations.

This was found while upgrading the board farm that runs the stmmac netdev
CI tests. I've upgraded the HW and I'm now using a bunch of I350-T4 PCIe
cards (running igb) as peers for my tests. Since then, the flow-control
tests have started failing:

https://netdevci.bootlin.com/stmmac/outputs/920328-bootlin-stmmac-sun7i-a20/test-outputs/18-pause-py/stdout

This shows 2 things. First, the Pause test is weak to the test peer not
behaving as expected, but we can't do much but assume that kselftest
peers can be trusted.

Second, the igb driver doesn't behave as we expect w.r.t pause:

 - It overrides the pause configuration when we toggle link autoneg
 - It doesn't take the FC user intent (rx on/off tx on/off) into account
   when pause aneg in on,
 - It advertises Pause + Asym when we have "rx on tx on", where it
   should be just Pause (it's not an asym config).

This series addresses that in igb. I think e100e and igc have the same
class of issues, but I don't have any HW to test that on.

Also, this behaviour has been in igb for quite a while (2008 it seems
?) and this is a user-visible change so it may just be too late for
these patches to land, I'll let the Intel folks decide on that, anyways
I'll have these 3 patches running locally in the stmmac farm.

Thanks,

Maxime

Maxime Chevallier (3):
  igb: don't change the pause config when changing the link ksettings
  igb: take the user intent into account when pause autoneg is on
  igb: advertise symmetric pause only for full flow control

 drivers/net/ethernet/intel/igb/e1000_phy.c   |  3 ++-
 drivers/net/ethernet/intel/igb/igb_ethtool.c | 21 +++++++++-----------
 2 files changed, 11 insertions(+), 13 deletions(-)

-- 
2.56.1


             reply	other threads:[~2026-11-21 10:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 10:36 Maxime Chevallier [this message]
2026-11-21 10:36 ` [PATCH iwl-next 1/3] igb: don't change the pause config when changing the link ksettings Maxime Chevallier
2026-11-21 10:36 ` [PATCH iwl-next 2/3] igb: take the user intent into account when pause autoneg is on Maxime Chevallier
2026-11-21 10:36 ` [PATCH iwl-next 3/3] igb: advertise symmetric pause only for full flow control Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121103613.166611-1-maxime.chevallier@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox