Netdev List
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Willem de Bruijn <willemb@google.com>,
	matttbe@kernel.org, intel-wired-lan@lists.osuosl.org,
	netdev@vger.kernel.org, thomas.petazzoni@bootlin.com
Subject: [PATCH iwl-next 1/3] igb: don't change the pause config when changing the link ksettings
Date: Sat, 21 Nov 2026 11:36:10 +0100	[thread overview]
Message-ID: <20261121103613.166611-2-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20261121103613.166611-1-maxime.chevallier@bootlin.com>

When enabling link autoneg, or changing any setting while link autoneg
is on, the flow control configuration is reset to the e1000_fc_default
mode.

Flow-control config should be changed through the .set_pauseparams()
ops, let the configuration as-is in the .set_ksettings() path.

Tested on i350-T4 cards.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
 drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index ccc7302dc7bd..cfa36eab8b0a 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -322,8 +322,6 @@ static int igb_set_link_ksettings(struct net_device *netdev,
 						     ADVERTISED_Autoneg;
 		}
 		advertising = hw->phy.autoneg_advertised;
-		if (adapter->fc_autoneg)
-			hw->fc.requested_mode = e1000_fc_default;
 	} else {
 		u32 speed = cmd->base.speed;
 		/* calling this overrides forced MDI setting */
-- 
2.56.1


  reply	other threads:[~2026-11-21 10:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 10:36 [PATCH iwl-next 0/3] igb: Align the flow-control behaviour with ethtool's specs Maxime Chevallier
2026-11-21 10:36 ` Maxime Chevallier [this message]
2026-11-21 10:36 ` [PATCH iwl-next 2/3] igb: take the user intent into account when pause autoneg is on Maxime Chevallier
2026-11-21 10:36 ` [PATCH iwl-next 3/3] igb: advertise symmetric pause only for full flow control Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121103613.166611-2-maxime.chevallier@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox