From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
matttbe@kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, thomas.petazzoni@bootlin.com
Subject: [PATCH iwl-next 3/3] igb: advertise symmetric pause only for full flow control
Date: Sat, 21 Nov 2026 11:36:12 +0100 [thread overview]
Message-ID: <20261121103613.166611-4-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20261121103613.166611-1-maxime.chevallier@bootlin.com>
When flow-control is "rx on, tx on", the "Pause" bit alone should be
advertised, as per te linkmode_set_pause() implementation, which follows
the 802.3 specs.
The Asym bit is for asymetric configs, such as "rx on tx off" or
"rx off tx on". Let's align with the specs and not advertise ASYM for
full flow control.
Tested on I350-T4 PCIe cards.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/ethernet/intel/igb/e1000_phy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
index cd65008c7ef5..98dda73d507b 100644
--- a/drivers/net/ethernet/intel/igb/e1000_phy.c
+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
@@ -1043,7 +1043,8 @@ static s32 igb_phy_setup_autoneg(struct e1000_hw *hw)
/* Flow control (both RX and TX) is enabled by a software
* over-ride.
*/
- mii_autoneg_adv_reg |= (NWAY_AR_ASM_DIR | NWAY_AR_PAUSE);
+ mii_autoneg_adv_reg |= NWAY_AR_PAUSE;
+ mii_autoneg_adv_reg &= ~NWAY_AR_ASM_DIR;
break;
default:
hw_dbg("Flow control param set incorrectly\n");
--
2.56.1
prev parent reply other threads:[~2026-11-21 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 10:36 [PATCH iwl-next 0/3] igb: Align the flow-control behaviour with ethtool's specs Maxime Chevallier
2026-11-21 10:36 ` [PATCH iwl-next 1/3] igb: don't change the pause config when changing the link ksettings Maxime Chevallier
2026-11-21 10:36 ` [PATCH iwl-next 2/3] igb: take the user intent into account when pause autoneg is on Maxime Chevallier
2026-11-21 10:36 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121103613.166611-4-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox