From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <netdev@vger.kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] net: page_pool: fix warning code
Date: Fri, 5 Jul 2024 14:37:00 +0200 [thread overview]
Message-ID: <228b8f6a-55a8-4e8b-85de-baf7593cf2c9@intel.com> (raw)
In-Reply-To: <ac90ee8aa46a8d6dd9710a981545c14bf881f918.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 05 Jul 2024 14:33:31 +0200
> On Fri, 2024-07-05 at 14:32 +0200, Alexander Lobakin wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Date: Fri, 5 Jul 2024 13:42:06 +0200
>>
>>> From: Johannes Berg <johannes.berg@intel.com>
>>>
>>> WARN_ON_ONCE("string") doesn't really do what appears to
>>> be intended, so fix that.
>>>
>>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>
>> "Fixes:" tag?
>
> There keep being discussions around this so I have no idea what's the
> guideline-du-jour ... It changes the code but it's not really an issue?
Hmm, it's an incorrect usage of WARN_ON() (a string is passed instead of
a warning condition), so I do believe this should go as a fix.
Maybe let the maintainers respond what they think.
>
> johannes
Thanks,
Olek
next prev parent reply other threads:[~2024-07-05 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 11:42 [PATCH net-next] net: page_pool: fix warning code Johannes Berg
2024-07-05 12:32 ` Alexander Lobakin
2024-07-05 12:33 ` Johannes Berg
2024-07-05 12:37 ` Alexander Lobakin [this message]
2024-07-05 12:39 ` Johannes Berg
2024-07-05 13:14 ` Przemek Kitszel
2024-07-05 13:28 ` Alexander Lobakin
2024-07-05 13:38 ` Przemek Kitszel
2024-07-05 14:19 ` Andrew Lunn
2024-07-05 14:23 ` Johannes Berg
2024-07-05 14:33 ` Alexander Lobakin
2024-07-05 14:36 ` Johannes Berg
2024-07-05 14:44 ` Alexander Lobakin
2024-07-09 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=228b8f6a-55a8-4e8b-85de-baf7593cf2c9@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox