Re: [PATCH net-next] net: page_pool: fix warning code

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 05 Jul 2024 16:36:28 +0200

> On Fri, 2024-07-05 at 16:33 +0200, Alexander Lobakin wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Date: Fri, 05 Jul 2024 16:23:43 +0200
>>
>>> On Fri, 2024-07-05 at 16:19 +0200, Andrew Lunn wrote:
>>>> On Fri, Jul 05, 2024 at 02:33:31PM +0200, Johannes Berg wrote:
>>>>> On Fri, 2024-07-05 at 14:32 +0200, Alexander Lobakin wrote:
>>>>>> From: Johannes Berg <johannes@sipsolutions.net>
>>>>>> Date: Fri,  5 Jul 2024 13:42:06 +0200
>>>>>>
>>>>>>> From: Johannes Berg <johannes.berg@intel.com>
>>>>>>>
>>>>>>> WARN_ON_ONCE("string") doesn't really do what appears to
>>>>>>> be intended, so fix that.
>>>>>>>
>>>>>>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>>>>>
>>>>>> "Fixes:" tag?
>>>>>
>>>>> There keep being discussions around this so I have no idea what's the
>>>>> guideline-du-jour ... It changes the code but it's not really an issue?
>>>>
>>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>>>
>>> And ... by referring to that you just made a guideline(-du-jour!) that
>>> "Fixes" tag must be accompanied by "Cc: stable@" (because Fixes
>>> _doesn't_ imply stable backport!), and then you apply the stable rules
>>
>> The netdev ML is an exception, IIRC we never add "Cc: stable@" and then
>> after hitting Linus' tree at least some commits with "Fixes:" appears
>> magically in the stable trees :D
> 
> See, all the policy changes are confusing people, but not adding Cc:
> stable@ for netdev is not true! :)
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#stable-tree

Aaaah, this was changed recently, right. Sorry for confusion :z

> 
> johannes

Thanks,
Olek