Re: [PATCH net-next] net: page_pool: fix warning code

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri,  5 Jul 2024 13:42:06 +0200

> From: Johannes Berg <johannes.berg@intel.com>
> 
> WARN_ON_ONCE("string") doesn't really do what appears to
> be intended, so fix that.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

"Fixes:" tag?

> ---
>  net/core/page_pool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 3927a0a7fa9a..97914a9e2a85 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -445,7 +445,7 @@ static bool page_pool_dma_map(struct page_pool *pool, struct page *page)
>  	return true;
>  
>  unmap_failed:
> -	WARN_ON_ONCE("unexpected DMA address, please report to netdev@");
> +	WARN_ONCE(1, "unexpected DMA address, please report to netdev@");
>  	dma_unmap_page_attrs(pool->p.dev, dma,
>  			     PAGE_SIZE << pool->p.order, pool->p.dma_dir,
>  			     DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING);

Thanks,
Olek