From: Birger Koblitz <mail@birger-koblitz.de>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] ax88179_178a: Add support for AX88179A MMD access
Date: Wed, 8 Jul 2026 20:33:13 +0200 [thread overview]
Message-ID: <2567e897-87d3-4afa-844a-53980658dfec@birger-koblitz.de> (raw)
In-Reply-To: <b01b4c18-bb2d-413b-a993-4a9cf4d50549@bootlin.com>
Thanks Maxime for reviewing this patch!
On 7/1/26 11:53, Maxime Chevallier wrote:
> ADVERTISE_RESV isn't an unknown bit, it's been added in 802.3 as ADVERTISE_XNP
> for Extended Next Page, see :
>
> commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")
>
> we shoudln't use ADVERTISE_RESV anymore in-kernel (there are a few callsites left).
>
> As this seems to be a vendor-specific behaviour for that bit, please add a
> local #define for it in this driver, to make it clear that this is a device-specific
> value.
Will fix as suggested in v2 call it AX_ADVERTISE_2500.
And btw, I have to mention that I used the cross-referencing of bootlin
a lot for writing this patch-series, and it was enormously helpful. Thanks for that tool!
Birger
next prev parent reply other threads:[~2026-07-08 18:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 5:42 [PATCH 0/9] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-07-01 5:42 ` [PATCH 1/9] ax88179_178a: Fix endianness of pause watermark register Birger Koblitz
2026-07-01 14:57 ` Andrew Lunn
2026-07-08 18:23 ` Birger Koblitz
2026-07-01 5:42 ` [PATCH 2/9] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-07-01 15:05 ` Andrew Lunn
2026-07-08 18:27 ` Birger Koblitz
2026-07-07 9:11 ` Paolo Abeni
2026-07-08 18:37 ` Birger Koblitz
2026-07-01 5:42 ` [PATCH 3/9] ax88179_178a: Add support for AX88179A MMD access Birger Koblitz
2026-07-01 9:53 ` Maxime Chevallier
2026-07-08 18:33 ` Birger Koblitz [this message]
2026-07-01 5:42 ` [PATCH 4/9] ax88179_178a: Obtain speed and duplex from Interrupt URB Birger Koblitz
2026-07-01 5:42 ` [PATCH 5/9] ax88179_178a: Add support for ethtool pause parameter configuration Birger Koblitz
2026-07-01 10:04 ` Maxime Chevallier
2026-07-01 15:08 ` Andrew Lunn
2026-07-01 16:22 ` Birger Koblitz
2026-07-01 17:05 ` Andrew Lunn
2026-07-01 17:45 ` Birger Koblitz
2026-07-01 18:41 ` Andrew Lunn
2026-07-06 6:28 ` Birger Koblitz
2026-07-07 15:27 ` Andrew Lunn
2026-07-08 18:35 ` Birger Koblitz
2026-07-01 5:42 ` [PATCH 6/9] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-07-01 5:42 ` [PATCH 7/9] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-07-01 5:42 ` [PATCH 8/9] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-07-01 5:42 ` [PATCH 9/9] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2567e897-87d3-4afa-844a-53980658dfec@birger-koblitz.de \
--to=mail@birger-koblitz.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox