* [PATCH net-next] sfc: remove napi_hash_del() call
@ 2016-11-16 14:01 Eric Dumazet
2016-11-16 14:15 ` Bert Kenward
2016-11-16 22:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2016-11-16 14:01 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Edward Cree, Bert Kenward
From: Eric Dumazet <edumazet@google.com>
Calling napi_hash_del() after netif_napi_del() is pointless.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Edward Cree <ecree@solarflare.com>
Cc: Bert Kenward <bkenward@solarflare.com>
---
drivers/net/ethernet/sfc/efx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 649bc508fa4b9ea42aa08331c50335e1a51f9259..52ca0404c49121f1c86126ab7d443b1144f20720 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2113,10 +2113,9 @@ static void efx_init_napi(struct efx_nic *efx)
static void efx_fini_napi_channel(struct efx_channel *channel)
{
- if (channel->napi_dev) {
+ if (channel->napi_dev)
netif_napi_del(&channel->napi_str);
- napi_hash_del(&channel->napi_str);
- }
+
channel->napi_dev = NULL;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] sfc: remove napi_hash_del() call
2016-11-16 14:01 [PATCH net-next] sfc: remove napi_hash_del() call Eric Dumazet
@ 2016-11-16 14:15 ` Bert Kenward
2016-11-16 22:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bert Kenward @ 2016-11-16 14:15 UTC (permalink / raw)
To: Eric Dumazet, David Miller; +Cc: netdev, Edward Cree
On 16/11/16 14:01, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Calling napi_hash_del() after netif_napi_del() is pointless.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Edward Cree <ecree@solarflare.com>
> Cc: Bert Kenward <bkenward@solarflare.com>
> ---
> drivers/net/ethernet/sfc/efx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Acked-by: Bert Kenward <bkenward@solarflare.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sfc: remove napi_hash_del() call
2016-11-16 14:01 [PATCH net-next] sfc: remove napi_hash_del() call Eric Dumazet
2016-11-16 14:15 ` Bert Kenward
@ 2016-11-16 22:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-16 22:05 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, ecree, bkenward
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 Nov 2016 06:01:47 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Calling napi_hash_del() after netif_napi_del() is pointless.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-16 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 14:01 [PATCH net-next] sfc: remove napi_hash_del() call Eric Dumazet
2016-11-16 14:15 ` Bert Kenward
2016-11-16 22:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox