From: Andrew Lunn <andrew@lunn.ch>
To: Romain Gantois <romain.gantois@bootlin.com>
Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Luka Perkov <luka.perkov@sartura.hr>,
Robert Marko <robert.marko@sartura.hr>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next 2/5] net: dsa: qca: Make the QCA8K hardware library available globally
Date: Mon, 23 Oct 2023 18:40:35 +0200 [thread overview]
Message-ID: <3f279720-5386-4ea2-b54c-ffc44277b1cc@lunn.ch> (raw)
In-Reply-To: <20231023155013.512999-3-romain.gantois@bootlin.com>
> @@ -62,21 +61,37 @@ const struct qca8k_mib_desc ar8327_mib[] = {
> MIB_DESC(1, 0xa8, "RXUnicast"),
> MIB_DESC(1, 0xac, "TXUnicast"),
> };
> +EXPORT_SYMBOL(ar8327_mib);
Christian should decide, since he wrote most of this code, but i would
prefer EXPORT_SYMBOL_GPL().
> --- a/drivers/net/dsa/qca/qca8k.h
> +++ b/include/linux/dsa/qca8k.h
> @@ -13,6 +13,7 @@
> #include <linux/gpio.h>
> #include <linux/leds.h>
> #include <linux/dsa/tag_qca.h>
> +#include <net/dsa.h>
>
> #define QCA8K_ETHERNET_MDIO_PRIORITY 7
> #define QCA8K_ETHERNET_PHY_PRIORITY 6
> @@ -265,6 +266,7 @@
> #define QCA8K_PORT_LOOKUP_STATE_LEARNING QCA8K_PORT_LOOKUP_STATE(0x3)
> #define QCA8K_PORT_LOOKUP_STATE_FORWARD QCA8K_PORT_LOOKUP_STATE(0x4)
> #define QCA8K_PORT_LOOKUP_LEARN BIT(20)
> +#define QCA8K_PORT_LOOKUP_LOOPBACK_EN BIT(21)
Maybe do the move first, and then add new features in another patch?
Andrew
next prev parent reply other threads:[~2023-10-23 16:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 15:50 [PATCH net-next 0/5] net: ipqess: introduce Qualcomm IPQESS driver Romain Gantois
2023-10-23 15:50 ` [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet switch Romain Gantois
2023-10-23 17:37 ` Krzysztof Kozlowski
2023-10-24 8:01 ` Romain Gantois
2023-10-23 17:40 ` Rob Herring
2023-10-24 9:54 ` Romain Gantois
2023-10-24 9:56 ` Krzysztof Kozlowski
2023-10-24 10:05 ` Romain Gantois
2023-10-24 10:54 ` Krzysztof Kozlowski
2023-10-24 12:13 ` Romain Gantois
2023-10-23 15:50 ` [PATCH net-next 2/5] net: dsa: qca: Make the QCA8K hardware library available globally Romain Gantois
2023-10-23 16:40 ` Andrew Lunn [this message]
2023-10-23 15:50 ` [PATCH net-next 3/5] net: ipqess: introduce the Qualcomm IPQESS driver Romain Gantois
2023-10-23 17:50 ` Andrew Lunn
2023-10-24 9:16 ` Romain Gantois
2023-10-24 14:08 ` Andrew Lunn
2023-10-24 16:23 ` Robert Marko
2023-10-24 16:48 ` Andrew Lunn
2023-10-24 11:44 ` Wojciech Drewek
2023-10-24 15:55 ` kernel test robot
2023-10-23 15:50 ` [PATCH net-next 4/5] net: ipqess: add a PSGMII calibration procedure to the " Romain Gantois
2023-10-23 18:01 ` Andrew Lunn
2023-10-24 9:03 ` Romain Gantois
2023-10-24 14:13 ` Andrew Lunn
2023-10-24 16:49 ` Robert Marko
2023-10-23 15:50 ` [PATCH net-next 5/5] dts: qcom: ipq4019: Add description for the IPQ4019 ESS EDMA and switch Romain Gantois
2023-10-23 17:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f279720-5386-4ea2-b54c-ffc44277b1cc@lunn.ch \
--to=andrew@lunn.ch \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox