From: Andrew Lunn <andrew@lunn.ch>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: George Moussalem <george.moussalem@outlook.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support
Date: Tue, 27 May 2025 17:12:17 +0200 [thread overview]
Message-ID: <44988e1e-3ccb-4840-aa39-f28331d3c340@lunn.ch> (raw)
In-Reply-To: <061032a4-5774-482e-ba2e-96c3c81c0e3a@oss.qualcomm.com>
> does this sound like a generic enough problem to contemplate something
> common, or should we go with something like qcom,dac-preset-short-cable
I've seen a few other boards with back to back PHYs like this, and
they did not need any properties.
It could be this PHY does not conform to the standard, does not have
the needed dynamic range, and is getting saturated.
What we do have is:
tx-amplitude-100base-tx-percent:
description:
Transmit amplitude gain applied for 100BASE-TX. 100% matches 2V
peak-to-peak specified in ANSI X3.263. When omitted, the PHYs default
will be left as is.
This is intended for actually boosting the amplitude, to deal with
losses between the PHY and the RJ-45 connector. So this is the
opposite.
The description of what the magic value does on this PHY suggests it
does more, and it cannot be represented as a percent. So i think a
vendor property is O.K.
Andrew
next prev parent reply other threads:[~2025-05-27 15:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 17:56 [PATCH 0/5] Add support for the IPQ5018 Internal GE PHY George Moussalem via B4 Relay
2025-05-25 17:56 ` [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support George Moussalem via B4 Relay
2025-05-25 19:35 ` Andrew Lunn
2025-05-26 4:27 ` George Moussalem
2025-05-26 13:34 ` Andrew Lunn
2025-05-26 13:43 ` George Moussalem
2025-05-26 4:17 ` Krzysztof Kozlowski
2025-05-26 6:43 ` George Moussalem
2025-05-26 12:55 ` Krzysztof Kozlowski
2025-05-27 10:59 ` Konrad Dybcio
2025-05-27 11:28 ` George Moussalem
2025-05-27 11:31 ` Konrad Dybcio
2025-05-27 12:13 ` George Moussalem
2025-05-27 13:00 ` Konrad Dybcio
2025-05-27 13:03 ` George Moussalem
2025-05-27 13:08 ` Andrew Lunn
2025-05-27 13:15 ` Konrad Dybcio
2025-05-27 15:12 ` Andrew Lunn [this message]
2025-05-25 17:56 ` [PATCH 2/5] clk: qcom: gcc-ipq5018: fix GE PHY reset George Moussalem via B4 Relay
2025-05-27 11:00 ` Konrad Dybcio
2025-05-27 11:14 ` George Moussalem
2025-05-27 11:19 ` Konrad Dybcio
2025-05-25 17:56 ` [PATCH 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support George Moussalem via B4 Relay
2025-05-25 19:42 ` Andrew Lunn
2025-05-26 4:28 ` George Moussalem
2025-05-25 17:56 ` [PATCH 4/5] arm64: dts: qcom: ipq5018: add MDIO buses George Moussalem via B4 Relay
2025-05-27 11:07 ` Konrad Dybcio
2025-05-27 11:23 ` George Moussalem
2025-05-25 17:56 ` [PATCH 5/5] arm64: dts: qcom: ipq5018: Add GE PHY to internal mdio bus George Moussalem via B4 Relay
2025-05-27 13:34 ` Konrad Dybcio
2025-05-27 13:36 ` George Moussalem
2025-05-27 17:56 ` [PATCH 0/5] Add support for the IPQ5018 Internal GE PHY Rob Herring (Arm)
2025-05-28 4:57 ` George Moussalem
2025-05-28 12:00 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44988e1e-3ccb-4840-aa39-f28331d3c340@lunn.ch \
--to=andrew@lunn.ch \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=george.moussalem@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox