From: Andrew Lunn <andrew@lunn.ch>
To: george.moussalem@outlook.com
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support
Date: Sun, 25 May 2025 21:42:06 +0200 [thread overview]
Message-ID: <40b427b8-b0d0-474b-a7c6-46641d1940b9@lunn.ch> (raw)
In-Reply-To: <20250525-ipq5018-ge-phy-v1-3-ddab8854e253@outlook.com>
> + phy_write_mmd(phydev, MDIO_MMD_PCS, IPQ5018_PHY_MMD3_AZ_CTRL1,
> + IPQ5018_PHY_MMD3_AZ_CTRL1_VAL);
Using MMD3 in the name is a good idea, but PCS would be better. Not
everybody knows MDIO_MMD_PCS == 3.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-05-25 19:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 17:56 [PATCH 0/5] Add support for the IPQ5018 Internal GE PHY George Moussalem via B4 Relay
2025-05-25 17:56 ` [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support George Moussalem via B4 Relay
2025-05-25 19:35 ` Andrew Lunn
2025-05-26 4:27 ` George Moussalem
2025-05-26 13:34 ` Andrew Lunn
2025-05-26 13:43 ` George Moussalem
2025-05-26 4:17 ` Krzysztof Kozlowski
2025-05-26 6:43 ` George Moussalem
2025-05-26 12:55 ` Krzysztof Kozlowski
2025-05-27 10:59 ` Konrad Dybcio
2025-05-27 11:28 ` George Moussalem
2025-05-27 11:31 ` Konrad Dybcio
2025-05-27 12:13 ` George Moussalem
2025-05-27 13:00 ` Konrad Dybcio
2025-05-27 13:03 ` George Moussalem
2025-05-27 13:08 ` Andrew Lunn
2025-05-27 13:15 ` Konrad Dybcio
2025-05-27 15:12 ` Andrew Lunn
2025-05-25 17:56 ` [PATCH 2/5] clk: qcom: gcc-ipq5018: fix GE PHY reset George Moussalem via B4 Relay
2025-05-27 11:00 ` Konrad Dybcio
2025-05-27 11:14 ` George Moussalem
2025-05-27 11:19 ` Konrad Dybcio
2025-05-25 17:56 ` [PATCH 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support George Moussalem via B4 Relay
2025-05-25 19:42 ` Andrew Lunn [this message]
2025-05-26 4:28 ` George Moussalem
2025-05-25 17:56 ` [PATCH 4/5] arm64: dts: qcom: ipq5018: add MDIO buses George Moussalem via B4 Relay
2025-05-27 11:07 ` Konrad Dybcio
2025-05-27 11:23 ` George Moussalem
2025-05-25 17:56 ` [PATCH 5/5] arm64: dts: qcom: ipq5018: Add GE PHY to internal mdio bus George Moussalem via B4 Relay
2025-05-27 13:34 ` Konrad Dybcio
2025-05-27 13:36 ` George Moussalem
2025-05-27 17:56 ` [PATCH 0/5] Add support for the IPQ5018 Internal GE PHY Rob Herring (Arm)
2025-05-28 4:57 ` George Moussalem
2025-05-28 12:00 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40b427b8-b0d0-474b-a7c6-46641d1940b9@lunn.ch \
--to=andrew@lunn.ch \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=george.moussalem@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox