* Re: [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats()
2009-10-06 19:54 [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats() Roel Kluin
@ 2009-10-06 19:53 ` Manuel Lauss
2009-10-07 10:44 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Manuel Lauss @ 2009-10-06 19:53 UTC (permalink / raw)
To: Roel Kluin; +Cc: netdev, Andrew Morton, manuel.lauss, David S. Miller
On Tue, Oct 6, 2009 at 9:54 PM, Roel Kluin <roel.kluin@gmail.com> wrote:
> in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT.
> in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> please review, I merely guessed it should be RX_RUNT.
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index fdf5937..04f63c7 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -721,7 +721,7 @@ static inline void update_rx_stats(struct net_device *dev, u32 status)
> ps->rx_errors++;
> if (status & RX_MISSED_FRAME)
> ps->rx_missed_errors++;
> - if (status & (RX_OVERLEN | RX_OVERLEN | RX_LEN_ERROR))
> + if (status & (RX_OVERLEN | RX_RUNT | RX_LEN_ERROR))
> ps->rx_length_errors++;
> if (status & RX_CRC_ERROR)
> ps->rx_crc_errors++;
> @@ -794,8 +794,6 @@ static int au1000_rx(struct net_device *dev)
> printk("rx len error\n");
> if (status & RX_U_CNTRL_FRAME)
> printk("rx u control frame\n");
> - if (status & RX_MISSED_FRAME)
> - printk("rx miss\n");
Yeah, looks right.
Acked-by: Manuel Lauss <manuel.lauss@gmail.com>
Manuel Lauss
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats()
@ 2009-10-06 19:54 Roel Kluin
2009-10-06 19:53 ` Manuel Lauss
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-10-06 19:54 UTC (permalink / raw)
To: netdev, Andrew Morton, manuel.lauss, David S. Miller
in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT.
in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
please review, I merely guessed it should be RX_RUNT.
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index fdf5937..04f63c7 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -721,7 +721,7 @@ static inline void update_rx_stats(struct net_device *dev, u32 status)
ps->rx_errors++;
if (status & RX_MISSED_FRAME)
ps->rx_missed_errors++;
- if (status & (RX_OVERLEN | RX_OVERLEN | RX_LEN_ERROR))
+ if (status & (RX_OVERLEN | RX_RUNT | RX_LEN_ERROR))
ps->rx_length_errors++;
if (status & RX_CRC_ERROR)
ps->rx_crc_errors++;
@@ -794,8 +794,6 @@ static int au1000_rx(struct net_device *dev)
printk("rx len error\n");
if (status & RX_U_CNTRL_FRAME)
printk("rx u control frame\n");
- if (status & RX_MISSED_FRAME)
- printk("rx miss\n");
}
}
prxd->buff_stat = (u32)(pDB->dma_addr | RX_DMA_ENABLE);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats()
2009-10-06 19:53 ` Manuel Lauss
@ 2009-10-07 10:44 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-10-07 10:44 UTC (permalink / raw)
To: manuel.lauss; +Cc: roel.kluin, netdev, akpm, manuel.lauss
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Tue, 6 Oct 2009 21:53:50 +0200
> On Tue, Oct 6, 2009 at 9:54 PM, Roel Kluin <roel.kluin@gmail.com> wrote:
>> in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT.
>> in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
...
>
> Yeah, looks right.
>
> Acked-by: Manuel Lauss <manuel.lauss@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-07 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-06 19:54 [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats() Roel Kluin
2009-10-06 19:53 ` Manuel Lauss
2009-10-07 10:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox