* [Patch] Correct assignment of uid to gid in credentials
@ 2011-08-08 22:08 Tim Chen
2011-08-09 2:43 ` Eric Dumazet
0 siblings, 1 reply; 7+ messages in thread
From: Tim Chen @ 2011-08-08 22:08 UTC (permalink / raw)
To: Eric W. Biederman, Eric Dumazet, David S. Miller, Al Viro
Cc: ak, Al Viro, linux-kernel, netdev
This patch corrects an erroneous assignment of uid to gid in credentials
update.
Tim
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
diff --git a/net/core/scm.c b/net/core/scm.c
index 4c1ef02..811b53f 100644
--- a/net/core/scm.c
+++ b/net/core/scm.c
@@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr
*msg, struct scm_cookie *p)
goto error;
cred->uid = cred->euid = p->creds.uid;
- cred->gid = cred->egid = p->creds.uid;
+ cred->gid = cred->egid = p->creds.gid;
put_cred(p->cred);
p->cred = cred;
}
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Patch] Correct assignment of uid to gid in credentials
2011-08-08 22:08 [Patch] Correct assignment of uid to gid in credentials Tim Chen
@ 2011-08-09 2:43 ` Eric Dumazet
2011-08-09 16:48 ` [Patch] scm: Capture the full credentials of the scm sender Tim Chen
0 siblings, 1 reply; 7+ messages in thread
From: Eric Dumazet @ 2011-08-09 2:43 UTC (permalink / raw)
To: Tim Chen
Cc: Eric W. Biederman, David S. Miller, Al Viro, ak, linux-kernel,
netdev
Le lundi 08 août 2011 à 15:08 -0700, Tim Chen a écrit :
> This patch corrects an erroneous assignment of uid to gid in credentials
> update.
>
> Tim
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
> diff --git a/net/core/scm.c b/net/core/scm.c
> index 4c1ef02..811b53f 100644
> --- a/net/core/scm.c
> +++ b/net/core/scm.c
> @@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr
> *msg, struct scm_cookie *p)
> goto error;
>
> cred->uid = cred->euid = p->creds.uid;
> - cred->gid = cred->egid = p->creds.uid;
> + cred->gid = cred->egid = p->creds.gid;
> put_cred(p->cred);
> p->cred = cred;
> }
>
>
Good catch Tim.
BTW your patch is a bit flawed : one wrapped line and "---" marker
missing.
Could you add in Changelog bug came from commit 257b5358b32f17
(scm: Capture the full credentials of the scm sender) to ease stable
teams work ?
(linux-2.6.36 was the first kernel to include this commit)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Patch] scm: Capture the full credentials of the scm sender
2011-08-09 2:43 ` Eric Dumazet
@ 2011-08-09 16:48 ` Tim Chen
2011-08-09 18:06 ` Andi Kleen
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Tim Chen @ 2011-08-09 16:48 UTC (permalink / raw)
To: Eric Dumazet
Cc: Eric W. Biederman, David S. Miller, Al Viro, ak, linux-kernel,
netdev
On Tue, 2011-08-09 at 04:43 +0200, Eric Dumazet wrote:
> Good catch Tim.
>
> BTW your patch is a bit flawed : one wrapped line and "---" marker
> missing.
>
> Could you add in Changelog bug came from commit 257b5358b32f17
> (scm: Capture the full credentials of the scm sender) to ease stable
> teams work ?
> (linux-2.6.36 was the first kernel to include this commit)
>
>
>
Updated the log as requested. Thanks.
Tim
------------
This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
---
diff --git a/net/core/scm.c b/net/core/scm.c
index 4c1ef02..811b53f 100644
--- a/net/core/scm.c
+++ b/net/core/scm.c
@@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *p)
goto error;
cred->uid = cred->euid = p->creds.uid;
- cred->gid = cred->egid = p->creds.uid;
+ cred->gid = cred->egid = p->creds.gid;
put_cred(p->cred);
p->cred = cred;
}
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Patch] scm: Capture the full credentials of the scm sender
2011-08-09 16:48 ` [Patch] scm: Capture the full credentials of the scm sender Tim Chen
@ 2011-08-09 18:06 ` Andi Kleen
2011-08-09 18:12 ` Eric Dumazet
2011-08-09 23:20 ` James Morris
2011-08-11 12:51 ` David Miller
2 siblings, 1 reply; 7+ messages in thread
From: Andi Kleen @ 2011-08-09 18:06 UTC (permalink / raw)
To: Tim Chen
Cc: Eric Dumazet, Eric W. Biederman, David S. Miller, Al Viro,
linux-kernel, netdev
> This patch corrects an erroneous update of credential's gid with uid
> introduced in commit 257b5358b32f17 since 2.6.36.
Please also add a Cc: stable@kernel.org
-Andi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch] scm: Capture the full credentials of the scm sender
2011-08-09 18:06 ` Andi Kleen
@ 2011-08-09 18:12 ` Eric Dumazet
0 siblings, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2011-08-09 18:12 UTC (permalink / raw)
To: Andi Kleen
Cc: Tim Chen, Eric W. Biederman, David S. Miller, Al Viro,
linux-kernel, netdev
Le mardi 09 août 2011 à 11:06 -0700, Andi Kleen a écrit :
> > This patch corrects an erroneous update of credential's gid with uid
> > introduced in commit 257b5358b32f17 since 2.6.36.
>
>
> Please also add a Cc: stable@kernel.org
>
David handles stable submission himself, a priori.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch] scm: Capture the full credentials of the scm sender
2011-08-09 16:48 ` [Patch] scm: Capture the full credentials of the scm sender Tim Chen
2011-08-09 18:06 ` Andi Kleen
@ 2011-08-09 23:20 ` James Morris
2011-08-11 12:51 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: James Morris @ 2011-08-09 23:20 UTC (permalink / raw)
To: Tim Chen
Cc: Eric Dumazet, Eric W. Biederman, David S. Miller, Al Viro, ak,
linux-kernel, netdev
On Tue, 9 Aug 2011, Tim Chen wrote:
> This patch corrects an erroneous update of credential's gid with uid
> introduced in commit 257b5358b32f17 since 2.6.36.
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
Reviewed-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch] scm: Capture the full credentials of the scm sender
2011-08-09 16:48 ` [Patch] scm: Capture the full credentials of the scm sender Tim Chen
2011-08-09 18:06 ` Andi Kleen
2011-08-09 23:20 ` James Morris
@ 2011-08-11 12:51 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2011-08-11 12:51 UTC (permalink / raw)
To: tim.c.chen; +Cc: eric.dumazet, ebiederm, viro, ak, linux-kernel, netdev
From: Tim Chen <tim.c.chen@linux.intel.com>
Date: Tue, 09 Aug 2011 09:48:32 -0700
> This patch corrects an erroneous update of credential's gid with uid
> introduced in commit 257b5358b32f17 since 2.6.36.
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-08-11 12:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-08 22:08 [Patch] Correct assignment of uid to gid in credentials Tim Chen
2011-08-09 2:43 ` Eric Dumazet
2011-08-09 16:48 ` [Patch] scm: Capture the full credentials of the scm sender Tim Chen
2011-08-09 18:06 ` Andi Kleen
2011-08-09 18:12 ` Eric Dumazet
2011-08-09 23:20 ` James Morris
2011-08-11 12:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox