* [net-next:master 20/25] warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
@ 2012-11-26 4:56 kbuild test robot
2012-11-26 6:13 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2012-11-26 4:56 UTC (permalink / raw)
To: viresh kumar; +Cc: netdev
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 53d6841d225b93c20d561878637c3cd307c11648
commit: 82167cb8c6b2f8166d5c7532e5ef4b5e0cc46a72 [20/25] net: dsa/slave: Fix compilation warnings
config: make ARCH=s390 allmodconfig
All warnings:
warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
--
warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-next:master 20/25] warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
2012-11-26 4:56 [net-next:master 20/25] warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390) kbuild test robot
@ 2012-11-26 6:13 ` Viresh Kumar
2012-11-26 18:50 ` [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390 Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2012-11-26 6:13 UTC (permalink / raw)
To: kbuild test robot, Ben Hutchings, davem; +Cc: netdev
Hi Ben/Dave,
On 26 November 2012 10:26, kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head: 53d6841d225b93c20d561878637c3cd307c11648
> commit: 82167cb8c6b2f8166d5c7532e5ef4b5e0cc46a72 [20/25] net: dsa/slave: Fix compilation warnings
> config: make ARCH=s390 allmodconfig
>
> All warnings:
>
> warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
> warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
> --
> warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390)
I am not really sure how to fix this up. Can you help?
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390
2012-11-26 6:13 ` Viresh Kumar
@ 2012-11-26 18:50 ` Randy Dunlap
2012-11-26 18:57 ` Ben Hutchings
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2012-11-26 18:50 UTC (permalink / raw)
To: Viresh Kumar; +Cc: kbuild test robot, Ben Hutchings, davem, netdev
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig dependency warning by making DSA support depend on the
same kconfig symbols that NET_DSA depend on.
warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && NETDEVICES && !S390)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
net/dsa/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20121126.orig/net/dsa/Kconfig
+++ linux-next-20121126/net/dsa/Kconfig
@@ -9,6 +9,7 @@ config NET_DSA
menu "Distributed Switch Architecture support"
+ depends on NETDEVICES && !S390
# tagging formats
config NET_DSA_TAG_DSA
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390
2012-11-26 18:50 ` [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390 Randy Dunlap
@ 2012-11-26 18:57 ` Ben Hutchings
0 siblings, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2012-11-26 18:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Viresh Kumar, kbuild test robot, davem, netdev
On Mon, 2012-11-26 at 10:50 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig dependency warning by making DSA support depend on the
> same kconfig symbols that NET_DSA depend on.
>
> warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && NETDEVICES && !S390)
This perhaps ought to be abstracted into a HAVE_NET_DSA rather than
reepated here. Also, in net-next NET_DSA still depends on EXPERIMENTAL,
which should be removed.
Ben.
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> net/dsa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20121126.orig/net/dsa/Kconfig
> +++ linux-next-20121126/net/dsa/Kconfig
> @@ -9,6 +9,7 @@ config NET_DSA
>
>
> menu "Distributed Switch Architecture support"
> + depends on NETDEVICES && !S390
>
> # tagging formats
> config NET_DSA_TAG_DSA
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-26 18:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-26 4:56 [net-next:master 20/25] warning: (NET_DSA_TAG_DSA && NET_DSA_TAG_EDSA && NET_DSA_TAG_TRAILER) selects NET_DSA which has unmet direct dependencies (NET && EXPERIMENTAL && NETDEVICES && !S390) kbuild test robot
2012-11-26 6:13 ` Viresh Kumar
2012-11-26 18:50 ` [PATCH net-next:master 20/25] net/dsa: make DSA tagging depend on NETDEVICES and !S390 Randy Dunlap
2012-11-26 18:57 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox