Re: [PATCH v2 net-next 6/6] net: phy: realtek: create rtl8211f_config_phy_eee() helper

[Andrew Lunn <andrew@lunn.ch>]

On Fri, Nov 07, 2025 at 01:08:17PM +0200, Vladimir Oltean wrote:
> To simplify the rtl8211f_config_init() control flow and get rid of
> "early" returns for PHYs where the PHYCR2 register is absent, move the
> entire logic sub-block that deals with disabling PHY-mode EEE to a
> separate function. There, it is much more obvious what the early
> "return 0" skips, and it becomes more difficult to accidentally skip
> unintended stuff.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> v1->v2: patch is new
> 
>  drivers/net/phy/realtek/realtek_main.c | 29 ++++++++++++++++----------
>  1 file changed, 18 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c
> index 4501b8923aad..6e75e124f27a 100644
> --- a/drivers/net/phy/realtek/realtek_main.c
> +++ b/drivers/net/phy/realtek/realtek_main.c
> @@ -684,6 +684,23 @@ static int rtl8211f_config_aldps(struct phy_device *phydev)
>  				mask, mask);
>  }
>  
> +static int rtl8211f_config_phy_eee(struct phy_device *phydev)
> +{
> +	int ret;
> +
> +	/* RTL8211FVD has no PHYCR2 register */
> +	if (phydev->drv->phy_id == RTL_8211FVD_PHYID)
> +		return 0;
> +
> +	/* Disable PHY-mode EEE so LPI is passed to the MAC */
> +	ret = phy_modify_paged(phydev, RTL8211F_PHYCR_PAGE, RTL8211F_PHYCR2,
> +			       RTL8211F_PHYCR2_PHY_EEE_ENABLE, 0);
> +	if (ret)
> +		return ret;
> +
> +	return genphy_soft_reset(phydev);

Is this soft reset only required for EEE? None of the other
configuration needs it?

For the Marvell PHYs, lots of registers need a soft reset to put
changes into effect. I would not want to hide the soft reset inside a
helper, because of the danger more calls to helps are added
afterwards.

	Andrew