From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Marek Vasut <marex@denx.de>, Wei Fang <wei.fang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>
Subject: Re: [PATCH v2 net-next 1/6] net: phy: realtek: create rtl8211f_config_rgmii_delay()
Date: Fri, 7 Nov 2025 14:27:04 +0100 [thread overview]
Message-ID: <02ad7418-7043-4968-b34a-6fa9142e85ea@lunn.ch> (raw)
In-Reply-To: <20251107110817.324389-2-vladimir.oltean@nxp.com>
On Fri, Nov 07, 2025 at 01:08:12PM +0200, Vladimir Oltean wrote:
> The control flow in rtl8211f_config_init() has some pitfalls which were
> probably unintended. Specifically it has an early return:
>
> switch (phydev->interface) {
> ...
> default: /* the rest of the modes imply leaving delay as is. */
> return 0;
> }
>
> which exits the entire config_init() function. This means it also skips
> doing things such as disabling CLKOUT or disabling PHY-mode EEE.
>
> For the RTL8211FS, which uses PHY_INTERFACE_MODE_SGMII, this might be a
> problem. However, I don't know that it is, so there is no Fixes: tag.
> The issue was observed through code inspection.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Pulling this out into a helper makes sense.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-11-07 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 11:08 [PATCH v2 net-next 0/6] Disable CLKOUT on RTL8211F(D)(I)-VD-CG Vladimir Oltean
2025-11-07 11:08 ` [PATCH v2 net-next 1/6] net: phy: realtek: create rtl8211f_config_rgmii_delay() Vladimir Oltean
2025-11-07 13:27 ` Andrew Lunn [this message]
2025-11-07 11:08 ` [PATCH v2 net-next 2/6] net: phy: realtek: eliminate priv->phycr2 variable Vladimir Oltean
2025-11-07 13:27 ` Andrew Lunn
2025-11-07 11:08 ` [PATCH v2 net-next 3/6] net: phy: realtek: eliminate has_phycr2 variable Vladimir Oltean
2025-11-07 11:08 ` [PATCH v2 net-next 4/6] net: phy: realtek: allow CLKOUT to be disabled on RTL8211F(D)(I)-VD-CG Vladimir Oltean
2025-11-07 13:29 ` Andrew Lunn
2025-11-07 11:08 ` [PATCH v2 net-next 5/6] net: phy: realtek: eliminate priv->phycr1 variable Vladimir Oltean
2025-11-07 13:30 ` Andrew Lunn
2025-11-07 11:08 ` [PATCH v2 net-next 6/6] net: phy: realtek: create rtl8211f_config_phy_eee() helper Vladimir Oltean
2025-11-07 13:34 ` Andrew Lunn
2025-11-07 14:32 ` Vladimir Oltean
2025-11-07 16:18 ` Andrew Lunn
2025-11-13 12:13 ` Vladimir Oltean
2025-11-13 14:03 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ad7418-7043-4968-b34a-6fa9142e85ea@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox