[PATCH] sis900: increment revision number

[PATCH] sis900: increment revision number

[Sergej Benilov]

Increment revision number to 1.08.11 (TX completion fix).

Signed-off-by: Sergej Benilov <sergej.benilov@googlemail.com>
---
 drivers/net/ethernet/sis/sis900.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index abb9b42e..09b4e1c5 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -1,6 +1,6 @@
 /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
    Copyright 1999 Silicon Integrated System Corporation
-   Revision:	1.08.10 Apr. 2 2006
+   Revision:	1.08.11 Jun. 23 2019
 
    Modified from the driver which is originally written by Donald Becker.
 
@@ -16,7 +16,8 @@
    preliminary Rev. 1.0 Nov. 10, 1998
    SiS 7014 Single Chip 100BASE-TX/10BASE-T Physical Layer Solution,
    preliminary Rev. 1.0 Jan. 18, 1998
-
+   
+   Rev 1.08.11 Jun. 23 2019 Sergej Benilov TX completion fix
    Rev 1.08.10 Apr.  2 2006 Daniele Venzano add vlan (jumbo packets) support
    Rev 1.08.09 Sep. 19 2005 Daniele Venzano add Wake on LAN support
    Rev 1.08.08 Jan. 22 2005 Daniele Venzano use netif_msg for debugging messages
@@ -79,7 +80,7 @@
 #include "sis900.h"
 
 #define SIS900_MODULE_NAME "sis900"
-#define SIS900_DRV_VERSION "v1.08.10 Apr. 2 2006"
+#define SIS900_DRV_VERSION "v1.08.11 Jun. 23 2019"
 
 static const char version[] =
 	KERN_INFO "sis900.c: " SIS900_DRV_VERSION "\n";
-- 
2.17.1

Re: [PATCH] sis900: increment revision number

[Daniele Venzano]

Sorry to be late in replying, I am ok also with the previous changes.

Signed-off-by: Daniele Venzano <venza@brownhat.org>

On 23/06/2019 09:47, Sergej Benilov wrote:
> Increment revision number to 1.08.11 (TX completion fix).
>
> Signed-off-by: Sergej Benilov <sergej.benilov@googlemail.com>
> ---
>   drivers/net/ethernet/sis/sis900.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
> index abb9b42e..09b4e1c5 100644
> --- a/drivers/net/ethernet/sis/sis900.c
> +++ b/drivers/net/ethernet/sis/sis900.c
> @@ -1,6 +1,6 @@
>   /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
>      Copyright 1999 Silicon Integrated System Corporation
> -   Revision:	1.08.10 Apr. 2 2006
> +   Revision:	1.08.11 Jun. 23 2019
>   
>      Modified from the driver which is originally written by Donald Becker.
>   
> @@ -16,7 +16,8 @@
>      preliminary Rev. 1.0 Nov. 10, 1998
>      SiS 7014 Single Chip 100BASE-TX/10BASE-T Physical Layer Solution,
>      preliminary Rev. 1.0 Jan. 18, 1998
> -
> +
> +   Rev 1.08.11 Jun. 23 2019 Sergej Benilov TX completion fix
>      Rev 1.08.10 Apr.  2 2006 Daniele Venzano add vlan (jumbo packets) support
>      Rev 1.08.09 Sep. 19 2005 Daniele Venzano add Wake on LAN support
>      Rev 1.08.08 Jan. 22 2005 Daniele Venzano use netif_msg for debugging messages
> @@ -79,7 +80,7 @@
>   #include "sis900.h"
>   
>   #define SIS900_MODULE_NAME "sis900"
> -#define SIS900_DRV_VERSION "v1.08.10 Apr. 2 2006"
> +#define SIS900_DRV_VERSION "v1.08.11 Jun. 23 2019"
>   
>   static const char version[] =
>   	KERN_INFO "sis900.c: " SIS900_DRV_VERSION "\n";

Re: [PATCH] sis900: increment revision number

[Joe Perches]

On Sun, 2019-06-23 at 09:47 +0200, Sergej Benilov wrote:
> Increment revision number to 1.08.11 (TX completion fix).

Better not to bother as the last increment was in 2006.
The driver version gets the kernel version in any case.

> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
[]
> @@ -1,6 +1,6 @@
>  /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
>     Copyright 1999 Silicon Integrated System Corporation
> -   Revision:	1.08.10 Apr. 2 2006
> +   Revision:	1.08.11 Jun. 23 2019

etc...

Re: [PATCH] sis900: increment revision number

[Daniele Venzano]

Hello,

I think it is good to know just by looking at the sources that the 
driver is still kept up-to-date, so I am in favor of this patch.

Daniele

On 23/06/2019 11:10, Joe Perches wrote:
> On Sun, 2019-06-23 at 09:47 +0200, Sergej Benilov wrote:
>> Increment revision number to 1.08.11 (TX completion fix).
> Better not to bother as the last increment was in 2006.
> The driver version gets the kernel version in any case.
>
>> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
> []
>> @@ -1,6 +1,6 @@
>>   /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
>>      Copyright 1999 Silicon Integrated System Corporation
>> -   Revision:	1.08.10 Apr. 2 2006
>> +   Revision:	1.08.11 Jun. 23 2019
> etc...
>
>

Re: [PATCH] sis900: increment revision number

[David Miller]

From: Daniele Venzano <venza@brownhat.org>
Date: Sun, 23 Jun 2019 11:13:28 +0200

> Hello,
> 
> I think it is good to know just by looking at the sources that the
> driver is still kept up-to-date, so I am in favor of this patch.

I absolutely, strongly, disagree.

These are pointless.

Re: [PATCH] sis900: increment revision number

[Joe Perches]

On Sun, 2019-06-23 at 08:37 -0700, David Miller wrote:
> From: Daniele Venzano <venza@brownhat.org>
> Date: Sun, 23 Jun 2019 11:13:28 +0200
> 
> > Hello,
> > 
> > I think it is good to know just by looking at the sources that the
> > driver is still kept up-to-date, so I am in favor of this patch.
> 
> I absolutely, strongly, disagree.
> 
> These are pointless.

Perhaps (most)? all the .get_drvinfo function calls where the
driver version is returned should use the default release.

This is similar to net/wireless/ethtool.c

Maybe:
---
 net/core/ethtool.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 4d1011b2e24f..644a2043714c 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -23,6 +23,7 @@
 #include <linux/rtnetlink.h>
 #include <linux/sched/signal.h>
 #include <linux/net.h>
+#include <linux/utsname.h>
 #include <net/devlink.h>
 #include <net/xdp_sock.h>
 #include <net/flow_offload.h>
@@ -806,6 +807,8 @@ static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev,
 		devlink_compat_running_version(dev, info.fw_version,
 					       sizeof(info.fw_version));
 
+	strlcpy(info.version, init_utsname()->release, sizeof(info.version));
+
 	if (copy_to_user(useraddr, &info, sizeof(info)))
 		return -EFAULT;
 	return 0;

Re: [PATCH] sis900: increment revision number

[David Miller]

From: Sergej Benilov <sergej.benilov@googlemail.com>
Date: Sun, 23 Jun 2019 09:47:07 +0200

> Increment revision number to 1.08.11 (TX completion fix).
> 
> Signed-off-by: Sergej Benilov <sergej.benilov@googlemail.com>

These are useless, really...

People are going to backport the TX completion fix all by itself
and not this change if I were to merge it.

I really want to heavily discourage these kinds of things, sorry.
Code is code, the fix is there or it isn't.