[PATCH net-next] sfc: add missing prototypes for ef10 helper functions

[PATCH net-next] sfc: add missing prototypes for ef10 helper functions

[Chen Aibing]

From: chenaibing <chenaibing@cmss.chinamobile.com>

Fix the following W=1 warnings when building with -Wmissing-prototypes:

  drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
  'efx_ef10_vadaptor_query' [-Wmissing-prototypes]
  drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
  'efx_ef10_vadaptor_alloc' [-Wmissing-prototypes]
  drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
  'efx_ef10_vadaptor_free' [-Wmissing-prototypes]
  drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
  'efx_ef10_vport_add_mac' [-Wmissing-prototypes]
  drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
  'efx_ef10_vport_del_mac' [-Wmissing-prototypes]
  drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
  'efx_ef10_tx_tso_desc' [-Wmissing-prototypes]

These non-static functions are defined in ef10.c and called from
ef10_sriov.c, but have no declaration in any shared header.
Add the missing prototypes to efx.h.

Signed-off-by: chenaibing <chenaibing@cmss.chinamobile.com>
---
 drivers/net/ethernet/sfc/efx.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/ethernet/sfc/efx.h b/drivers/net/ethernet/sfc/efx.h
index 1234567890ab..abcdef123456 100644
--- a/drivers/net/ethernet/sfc/efx.h
+++ b/drivers/net/ethernet/sfc/efx.h
@@ -209,6 +209,18 @@ int efx_xdp_tx_buffers(struct efx_nic *efx, int n, struct xdp_frame **xdpfs,
 		       bool flush);
 
+/* ef10.c: exported helpers also used by ef10_sriov.c */
+int efx_ef10_vadaptor_query(struct efx_nic *efx, unsigned int port_id,
+			    u32 *port_flags, u32 *vadaptor_flags,
+			    unsigned int *vlan_tags);
+int efx_ef10_vadaptor_alloc(struct efx_nic *efx, unsigned int port_id);
+int efx_ef10_vadaptor_free(struct efx_nic *efx, unsigned int port_id);
+int efx_ef10_vport_add_mac(struct efx_nic *efx,
+			   unsigned int port_id, const u8 *mac);
+int efx_ef10_vport_del_mac(struct efx_nic *efx,
+			   unsigned int port_id, const u8 *mac);
+int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb,
+			 bool *data_mapped);
+
 #endif /* EFX_EFX_H */
-- 
2.39.0

Re: [PATCH net-next] sfc: add missing prototypes for ef10 helper functions

[Austin, Alex (DCCG)]

On 12/11/2026 03:44, 陈爱兵 wrote:
> 
> From: chenaibing <chenaibing@cmss.chinamobile.com>
> 
> Fix the following W=1 warnings when building with -Wmissing-prototypes:
> 
>   drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
>   'efx_ef10_vadaptor_query' [-Wmissing-prototypes]
>   drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
>   'efx_ef10_vadaptor_alloc' [-Wmissing-prototypes]
>   drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
>   'efx_ef10_vadaptor_free' [-Wmissing-prototypes]
>   drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
>   'efx_ef10_vport_add_mac' [-Wmissing-prototypes]
>   drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
>   'efx_ef10_vport_del_mac' [-Wmissing-prototypes]
>   drivers/net/ethernet/sfc/ef10.c: warning: no previous prototype for
>   'efx_ef10_tx_tso_desc' [-Wmissing-prototypes]
> 
> These non-static functions are defined in ef10.c and called from
> ef10_sriov.c, but have no declaration in any shared header.
> Add the missing prototypes to efx.h.
> 
> Signed-off-by: chenaibing <chenaibing@cmss.chinamobile.com>
> ---
>  drivers/net/ethernet/sfc/efx.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.h b/drivers/net/ethernet/sfc/efx.h
> index 1234567890ab..abcdef123456 100644
> --- a/drivers/net/ethernet/sfc/efx.h
> +++ b/drivers/net/ethernet/sfc/efx.h
> @@ -209,6 +209,18 @@ int efx_xdp_tx_buffers(struct efx_nic *efx, int n, struct xdp_frame **xdpfs,
>                 bool flush);
> 
> +/* ef10.c: exported helpers also used by ef10_sriov.c */
> +int efx_ef10_vadaptor_query(struct efx_nic *efx, unsigned int port_id,
> +                u32 *port_flags, u32 *vadaptor_flags,
> +                unsigned int *vlan_tags);
> +int efx_ef10_vadaptor_alloc(struct efx_nic *efx, unsigned int port_id);
> +int efx_ef10_vadaptor_free(struct efx_nic *efx, unsigned int port_id);
> +int efx_ef10_vport_add_mac(struct efx_nic *efx,
> +               unsigned int port_id, const u8 *mac);
> +int efx_ef10_vport_del_mac(struct efx_nic *efx,
> +               unsigned int port_id, const u8 *mac);
> +int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb,
> +             bool *data_mapped);
> +
>  #endif /* EFX_EFX_H */
> --
> 2.39.0

These declarations already exist in ef10_sriov.h and nic.h. Does this
patch apply to net-next?