Re: [PATCH net-next v3 0/6] pds_core: Add PLDM firmware update and host backed memory support

["Rao, Nikhil" <nikhirao@amd.com>]

On 6/13/2026 1:58 PM, Jakub Kicinski wrote:
> On Thu, 11 Jun 2026 11:53:13 -0700 Jacob Keller wrote:
>> On 6/11/2026 10:15 AM, Rao, Nikhil wrote:
>>>> The preference is to use generic names when possible/feasible. I think
>>>> at least some of your name choices could align with the generic ones.
>>>>
>>>> Could you explain why fw.mainfw was selected and fw.mgmt was deemed not
>>>> suitable?
>>>
>>> This component handles both control and data path, so fw.mgmt didn't
>>> feel right since devlink-info.rst explicitly excludes data path from
>>> that definition. We went with fw.mainfw to indicate it's the primary
>>> firmware component
>>
>> It might make sense to extend or add a new definition in this case.
>> Technically you could also report both fw.mgmt and fw.app together, but
>> I think that would be more confusing.
>>
>> Perhaps Jakub has a suggestion on the name or policy here. The
>> maintainer preference has generally been to use or extend standardized
>> names first unless the name or component is clearly unique to the device.
> 
> If it covers both datapath and mgmt then shouldn't it be just "fw" ?
> Right now driver reports something "running"-only as "fw", looks off

Will change the PLDM component from "fw.mainfw" to just "fw".

For identity version 2+, the PLDM code reports both running and stored 
versions. For version 1 (no PLDM), will retain the dev_info.fw_version 
running-only report.

Thanks,
Nikhil