Re: [PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC

[Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>]

Hi Andrew,

On Tue, 2026-07-07 at 14:42 +0200, Andrew Lunn wrote:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - mediatek,mt8189-gmac
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: MAC Main clock
> > +            - description: PTP clock
> > +            - description: RMII reference clock provided by MAC
> 
> Since this is a MAC, it sounds like it is consuming its own clock?

In the driver ([1]), this clock is described as being only used and
needed in RMII when MAC provides the reference clock, and useless
otherwise (RGMII/MII or RMII when PHY provides the reference clock).

Its use and configuration also depends on the "mediatek,rmii-clk-from-
mac" vendor property ([2]) presence in devicetree.

Do you wish this clock description be reworded in the dt-bindings for
both occurrences?

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c#n480
[2]:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml#n108

Regards,
Louis-Alexis
> 
> 	Andrew