[PATCH net-next 0/2] rust: net: Use kernel style vertical imports

[PATCH net-next 0/2] rust: net: Use kernel style vertical imports

[Guru Das Srinagesh]

Came across a recent commit bc58905eb07 ("samples: rust_misc_device: use
vertical import style") and found a few more locations that could
benefit from this cleanup. No functional changes.

Separating out patches per-subsystem as per the review feedback in [0].

Tested via:

    $ make LLVM=1 rustfmtcheck || echo "fail"
    $

[0]: https://lore.kernel.org/lkml/20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev/

Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
---
Guru Das Srinagesh (2):
      net: phy: ax88796b: Use vertical import style
      net: phy: qt2025: Use vertical import style

 drivers/net/phy/ax88796b_rust.rs |  7 ++++++-
 drivers/net/phy/qt2025.rs        | 10 ++++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)
---
base-commit: b73bc9ca3686b78b642fb35dcc1fdf874ecb74a1
change-id: 20260705-net-vert-imp-25c62f823db3

Best regards,
--  
Guru Das Srinagesh <linux@gurudas.dev>

[PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style

[Guru Das Srinagesh]

Convert `use` imports to vertical layout for better readability and
maintainability.

Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
---
 drivers/net/phy/ax88796b_rust.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/ax88796b_rust.rs b/drivers/net/phy/ax88796b_rust.rs
index 2d24628a4e58..5a21fe09bd62 100644
--- a/drivers/net/phy/ax88796b_rust.rs
+++ b/drivers/net/phy/ax88796b_rust.rs
@@ -5,7 +5,12 @@
 //!
 //! C version of this driver: [`drivers/net/phy/ax88796b.c`](./ax88796b.c)
 use kernel::{
-    net::phy::{self, reg::C22, DeviceId, Driver},
+    net::phy::{
+        self,
+        reg::C22,
+        DeviceId,
+        Driver, //
+    },
     prelude::*,
     uapi,
 };

-- 
2.54.0

Re: [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style

[Andrew Lunn]

On Sun, Jul 05, 2026 at 10:38:40PM -0700, Guru Das Srinagesh wrote:
> Convert `use` imports to vertical layout for better readability and
> maintainability.
> 
> Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> ---
>  drivers/net/phy/ax88796b_rust.rs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/ax88796b_rust.rs b/drivers/net/phy/ax88796b_rust.rs
> index 2d24628a4e58..5a21fe09bd62 100644
> --- a/drivers/net/phy/ax88796b_rust.rs
> +++ b/drivers/net/phy/ax88796b_rust.rs
> @@ -5,7 +5,12 @@
>  //!
>  //! C version of this driver: [`drivers/net/phy/ax88796b.c`](./ax88796b.c)
>  use kernel::{
> -    net::phy::{self, reg::C22, DeviceId, Driver},
> +    net::phy::{
> +        self,
> +        reg::C22,
> +        DeviceId,
> +        Driver, //
> +    },

A question from somebody who does not know rust. Does the order of the
elements in the list matter?

Linux has a pattern of sorting multi line lists, because it reduces
merge conflicts. Can this list be sorted?

      Andrew

Re: [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style

[Gary Guo]

On Mon Jul 6, 2026 at 2:05 PM BST, Andrew Lunn wrote:
> On Sun, Jul 05, 2026 at 10:38:40PM -0700, Guru Das Srinagesh wrote:
>> Convert `use` imports to vertical layout for better readability and
>> maintainability.
>> 
>> Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
>> ---
>>  drivers/net/phy/ax88796b_rust.rs | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/phy/ax88796b_rust.rs b/drivers/net/phy/ax88796b_rust.rs
>> index 2d24628a4e58..5a21fe09bd62 100644
>> --- a/drivers/net/phy/ax88796b_rust.rs
>> +++ b/drivers/net/phy/ax88796b_rust.rs
>> @@ -5,7 +5,12 @@
>>  //!
>>  //! C version of this driver: [`drivers/net/phy/ax88796b.c`](./ax88796b.c)
>>  use kernel::{
>> -    net::phy::{self, reg::C22, DeviceId, Driver},
>> +    net::phy::{
>> +        self,
>> +        reg::C22,
>> +        DeviceId,
>> +        Driver, //
>> +    },
>
> A question from somebody who does not know rust. Does the order of the
> elements in the list matter?
>
> Linux has a pattern of sorting multi line lists, because it reduces
> merge conflicts. Can this list be sorted?
>
>       Andrew

This is sorted list, albeit in ASCIIbetical order instead of alphabetical. The
order is enforced by rustfmt. This is not optimal so in Rust style edition 2024
it is actually recommended to use alphabetical instead, however we haven't opted
into that style edition yet.

Best,
Gary

Re: [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style

[Andrew Lunn]

> This is sorted list, albeit in ASCIIbetical order instead of alphabetical.

Ah, O.K. To avoid merge conflicts, the actual sorting scheme does not
matter, it just needs to be sorted, so inserts are more likely to be
spread across the list rather than appended at the end.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style

[Alice Ryhl]

On Mon, Jul 6, 2026 at 3:17 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Sun, Jul 05, 2026 at 10:38:40PM -0700, Guru Das Srinagesh wrote:
> > Convert `use` imports to vertical layout for better readability and
> > maintainability.
> >
> > Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> > ---
> >  drivers/net/phy/ax88796b_rust.rs | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/ax88796b_rust.rs b/drivers/net/phy/ax88796b_rust.rs
> > index 2d24628a4e58..5a21fe09bd62 100644
> > --- a/drivers/net/phy/ax88796b_rust.rs
> > +++ b/drivers/net/phy/ax88796b_rust.rs
> > @@ -5,7 +5,12 @@
> >  //!
> >  //! C version of this driver: [`drivers/net/phy/ax88796b.c`](./ax88796b.c)
> >  use kernel::{
> > -    net::phy::{self, reg::C22, DeviceId, Driver},
> > +    net::phy::{
> > +        self,
> > +        reg::C22,
> > +        DeviceId,
> > +        Driver, //
> > +    },
>
> A question from somebody who does not know rust. Does the order of the
> elements in the list matter?
>
> Linux has a pattern of sorting multi line lists, because it reduces
> merge conflicts. Can this list be sorted?

No, the order does not matter. But rustfmt will complain if it's not
sorted. Note that rustfmt prefers ordering lower-case before
upper-case so it is currently sorted in the order preferred by the tool.


Alice

[PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Guru Das Srinagesh]

Convert `use` imports to vertical layout for better readability and
maintainability.

Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
---
 drivers/net/phy/qt2025.rs | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
index 470d89a0ac00..efde3f909367 100644
--- a/drivers/net/phy/qt2025.rs
+++ b/drivers/net/phy/qt2025.rs
@@ -14,11 +14,17 @@
 use kernel::io::poll::read_poll_timeout;
 use kernel::net::phy::{
     self,
-    reg::{Mmd, C45},
+    reg::{
+        Mmd,
+        C45, //
+    },
     Driver,
 };
 use kernel::prelude::*;
-use kernel::sizes::{SZ_16K, SZ_8K};
+use kernel::sizes::{
+    SZ_16K,
+    SZ_8K, //
+};
 use kernel::time::Delta;
 
 kernel::module_phy_driver! {

-- 
2.54.0

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Andrew Lunn]

On Sun, Jul 05, 2026 at 10:38:41PM -0700, Guru Das Srinagesh wrote:
> Convert `use` imports to vertical layout for better readability and
> maintainability.
> 
> Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> ---
>  drivers/net/phy/qt2025.rs | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
> index 470d89a0ac00..efde3f909367 100644
> --- a/drivers/net/phy/qt2025.rs
> +++ b/drivers/net/phy/qt2025.rs
> @@ -14,11 +14,17 @@
>  use kernel::io::poll::read_poll_timeout;
>  use kernel::net::phy::{
>      self,
> -    reg::{Mmd, C45},
> +    reg::{
> +        Mmd,
> +        C45, //
> +    },

Given the comment this should be sorted in 'ASCIIbetical order',
isn't this wrong, C comes before M? 

	Andrew

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Gary Guo]

On Mon Jul 6, 2026 at 2:58 PM BST, Andrew Lunn wrote:
> On Sun, Jul 05, 2026 at 10:38:41PM -0700, Guru Das Srinagesh wrote:
>> Convert `use` imports to vertical layout for better readability and
>> maintainability.
>> 
>> Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
>> ---
>>  drivers/net/phy/qt2025.rs | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
>> index 470d89a0ac00..efde3f909367 100644
>> --- a/drivers/net/phy/qt2025.rs
>> +++ b/drivers/net/phy/qt2025.rs
>> @@ -14,11 +14,17 @@
>>  use kernel::io::poll::read_poll_timeout;
>>  use kernel::net::phy::{
>>      self,
>> -    reg::{Mmd, C45},
>> +    reg::{
>> +        Mmd,
>> +        C45, //
>> +    },
>
> Given the comment this should be sorted in 'ASCIIbetical order',
> isn't this wrong, C comes before M? 
>
> 	Andrew

This is one of the quirks of rustfmt. Before style edition 2024, if an
identifier is all caps, it sorts it after non-all-caps identifiers. The
motivation was to ensure constants are ordered after types, however for things
like C45 it is actually a type, causing this weirdness.

Miguel, do you think it's worth moving to Rust style edition 2024 before we
switch the lang edition?

Best,
Gary

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Miguel Ojeda]

On Mon, Jul 6, 2026 at 5:16 PM Gary Guo <gary@garyguo.net> wrote:
>
> Miguel, do you think it's worth moving to Rust style edition 2024 before we
> switch the lang edition?

Maybe -- we could easily do it when we remove the `//` comments, i.e.
we could have a couple automated commits applied at once by Linus
before an -rc1.

Cheers,
Miguel

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Andrew Lunn]

> This is one of the quirks of rustfmt. Before style edition 2024, if an
> identifier is all caps, it sorts it after non-all-caps identifiers. The
> motivation was to ensure constants are ordered after types, however for things
> like C45 it is actually a type, causing this weirdness.

How often does the style edition change? Is there a 2026? How much
changes in each one?

At least in netdev, we tend to reject checkpatch.pl patches, which are
mostly about style, unless they are part of a patchset adding new
features. Style patches are mostly a waste of reviewer/maintainer
time, because some actually break stuff, so need to be reviewed just
as much as code adding new features. But style changes have a low ROI.

So while there is currently not much rust code in the kernel, making
style changes is not wasting too much reviewer/maintainer time, but as
the amount of rust code goes up, you might see some subsystems
rejecting such changes, or wanting to pin to a specific style edition,
to reduce churn.

     Andrew

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Miguel Ojeda]

On Mon, Jul 6, 2026 at 5:51 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> How often does the style edition change? Is there a 2026? How much
> changes in each one?

Every 3 years or so. For 2024, not much changes -- you can easily try
yourself passing the `--style-edition` flag. From a quick look, it is
almost all just the import sorting:

  https://doc.rust-lang.org/style-guide/editions.html

> features. Style patches are mostly a waste of reviewer/maintainer
> time, because some actually break stuff, so need to be reviewed just

Yes, we don't particularly like those either, but this is not like
those: it is not a manual process, and very, very unlikely to
functionally break anything (and trivially reviewed, from my
inspection above).

Just to clarify further: if we decided to do this, which is not a
given, this would be a treewide change done at once (because
formatting is enforced treewide), and nothing you would need to
review.

Cheers,
Miguel

Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

[Gary Guo]

On Mon Jul 6, 2026 at 4:51 PM BST, Andrew Lunn wrote:
>> This is one of the quirks of rustfmt. Before style edition 2024, if an
>> identifier is all caps, it sorts it after non-all-caps identifiers. The
>> motivation was to ensure constants are ordered after types, however for things
>> like C45 it is actually a type, causing this weirdness.
>
> How often does the style edition change? Is there a 2026? How much
> changes in each one?

So far it has only changed once, with the only major change being the identifier
sorting that we discussed.

Rustfmt has quite strict backward compatibility, so misformatted code stays
misformatted. They use editions as boundaries to do bugfixes/improvements that
can re-format previously badly formatted code. There'll be new editions coming
but I don't expect it to be as major as 2026.

> At least in netdev, we tend to reject checkpatch.pl patches, which are
> mostly about style, unless they are part of a patchset adding new
> features. Style patches are mostly a waste of reviewer/maintainer
> time, because some actually break stuff, so need to be reviewed just
> as much as code adding new features. But style changes have a low ROI.
>
> So while there is currently not much rust code in the kernel, making
> style changes is not wasting too much reviewer/maintainer time, but as
> the amount of rust code goes up, you might see some subsystems
> rejecting such changes, or wanting to pin to a specific style edition,
> to reduce churn.

We can control what edition of rustfmt we use (even per subsystem level). So
there's no obligation to bump edition unless we want to do it (e.g. it formats
certain code better).

That said, like Miguel said, this can be pretty trivially reformatted treewide.

Best,
Gary