* [net, 2/6] net: korina: define NAPI_WEIGHT
@ 2017-01-17 17:32 Roman Yeryomin
2017-01-17 17:40 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Roman Yeryomin @ 2017-01-17 17:32 UTC (permalink / raw)
To: netdev
Signed-off-by: Roman Yeryomin <roman@advem.lv>
---
drivers/net/ethernet/korina.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index 9bc375d..45bd617 100644
--- a/drivers/net/ethernet/korina.c
+++ b/drivers/net/ethernet/korina.c
@@ -77,6 +77,8 @@
#define MII_CLOCK 1250000 /* no more than 2.5MHz */
+#define NAPI_WEIGHT 64
+
/* the following must be powers of two */
#define KORINA_NUM_RDS 64 /* number of receive descriptors */
#define KORINA_NUM_TDS 64 /* number of transmit descriptors */
@@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
dev->netdev_ops = &korina_netdev_ops;
dev->ethtool_ops = &netdev_ethtool_ops;
dev->watchdog_timeo = TX_TIMEOUT;
- netif_napi_add(dev, &lp->napi, korina_poll, 64);
+ netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
lp->phy_addr = (((lp->rx_irq == 0x2c? 1:0) << 8) | 0x05);
lp->mii_if.dev = dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [net, 2/6] net: korina: define NAPI_WEIGHT
2017-01-17 17:32 [net, 2/6] net: korina: define NAPI_WEIGHT Roman Yeryomin
@ 2017-01-17 17:40 ` David Miller
2017-01-17 18:30 ` Roman Yeryomin
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2017-01-17 17:40 UTC (permalink / raw)
To: leroi.lists; +Cc: netdev
From: Roman Yeryomin <leroi.lists@gmail.com>
Date: Tue, 17 Jan 2017 19:32:22 +0200
> @@ -77,6 +77,8 @@
>
> #define MII_CLOCK 1250000 /* no more than 2.5MHz */
>
> +#define NAPI_WEIGHT 64
> +
> /* the following must be powers of two */
> #define KORINA_NUM_RDS 64 /* number of receive descriptors */
> #define KORINA_NUM_TDS 64 /* number of transmit descriptors */
> @@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
> dev->netdev_ops = &korina_netdev_ops;
> dev->ethtool_ops = &netdev_ethtool_ops;
> dev->watchdog_timeo = TX_TIMEOUT;
> - netif_napi_add(dev, &lp->napi, korina_poll, 64);
> + netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
Please use NAPI_POLL_WEIGHT from linux/netdevice.h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net, 2/6] net: korina: define NAPI_WEIGHT
2017-01-17 17:40 ` David Miller
@ 2017-01-17 18:30 ` Roman Yeryomin
2017-01-17 18:32 ` Florian Fainelli
2017-01-17 19:08 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Roman Yeryomin @ 2017-01-17 18:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On 17 January 2017 at 19:40, David Miller <davem@davemloft.net> wrote:
> From: Roman Yeryomin <leroi.lists@gmail.com>
> Date: Tue, 17 Jan 2017 19:32:22 +0200
>
>> @@ -77,6 +77,8 @@
>>
>> #define MII_CLOCK 1250000 /* no more than 2.5MHz */
>>
>> +#define NAPI_WEIGHT 64
>> +
>> /* the following must be powers of two */
>> #define KORINA_NUM_RDS 64 /* number of receive descriptors */
>> #define KORINA_NUM_TDS 64 /* number of transmit descriptors */
>> @@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
>> dev->netdev_ops = &korina_netdev_ops;
>> dev->ethtool_ops = &netdev_ethtool_ops;
>> dev->watchdog_timeo = TX_TIMEOUT;
>> - netif_napi_add(dev, &lp->napi, korina_poll, 64);
>> + netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
>
> Please use NAPI_POLL_WEIGHT from linux/netdevice.h
OK, should I resend the whole set or just this one and dependant?
Regards,
Roman
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net, 2/6] net: korina: define NAPI_WEIGHT
2017-01-17 18:30 ` Roman Yeryomin
@ 2017-01-17 18:32 ` Florian Fainelli
2017-01-17 19:08 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2017-01-17 18:32 UTC (permalink / raw)
To: Roman Yeryomin, David Miller; +Cc: netdev
On 01/17/2017 10:30 AM, Roman Yeryomin wrote:
> On 17 January 2017 at 19:40, David Miller <davem@davemloft.net> wrote:
>> From: Roman Yeryomin <leroi.lists@gmail.com>
>> Date: Tue, 17 Jan 2017 19:32:22 +0200
>>
>>> @@ -77,6 +77,8 @@
>>>
>>> #define MII_CLOCK 1250000 /* no more than 2.5MHz */
>>>
>>> +#define NAPI_WEIGHT 64
>>> +
>>> /* the following must be powers of two */
>>> #define KORINA_NUM_RDS 64 /* number of receive descriptors */
>>> #define KORINA_NUM_TDS 64 /* number of transmit descriptors */
>>> @@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
>>> dev->netdev_ops = &korina_netdev_ops;
>>> dev->ethtool_ops = &netdev_ethtool_ops;
>>> dev->watchdog_timeo = TX_TIMEOUT;
>>> - netif_napi_add(dev, &lp->napi, korina_poll, 64);
>>> + netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
>>
>> Please use NAPI_POLL_WEIGHT from linux/netdevice.h
>
> OK, should I resend the whole set or just this one and dependant?
You need to resend everything and please also provide a cover letter,
and a proper patch subject (e.g: git format-patch --cover-letter
--subject="PATCH net-next v2" a..b)
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net, 2/6] net: korina: define NAPI_WEIGHT
2017-01-17 18:30 ` Roman Yeryomin
2017-01-17 18:32 ` Florian Fainelli
@ 2017-01-17 19:08 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2017-01-17 19:08 UTC (permalink / raw)
To: leroi.lists; +Cc: netdev
From: Roman Yeryomin <leroi.lists@gmail.com>
Date: Tue, 17 Jan 2017 20:30:44 +0200
> On 17 January 2017 at 19:40, David Miller <davem@davemloft.net> wrote:
>> From: Roman Yeryomin <leroi.lists@gmail.com>
>> Date: Tue, 17 Jan 2017 19:32:22 +0200
>>
>>> @@ -77,6 +77,8 @@
>>>
>>> #define MII_CLOCK 1250000 /* no more than 2.5MHz */
>>>
>>> +#define NAPI_WEIGHT 64
>>> +
>>> /* the following must be powers of two */
>>> #define KORINA_NUM_RDS 64 /* number of receive descriptors */
>>> #define KORINA_NUM_TDS 64 /* number of transmit descriptors */
>>> @@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
>>> dev->netdev_ops = &korina_netdev_ops;
>>> dev->ethtool_ops = &netdev_ethtool_ops;
>>> dev->watchdog_timeo = TX_TIMEOUT;
>>> - netif_napi_add(dev, &lp->napi, korina_poll, 64);
>>> + netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
>>
>> Please use NAPI_POLL_WEIGHT from linux/netdevice.h
>
> OK, should I resend the whole set or just this one and dependant?
You always must do this for any change whatsoever, a full respin of a
series is always required on any modification whatsoever to any patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-17 19:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 17:32 [net, 2/6] net: korina: define NAPI_WEIGHT Roman Yeryomin
2017-01-17 17:40 ` David Miller
2017-01-17 18:30 ` Roman Yeryomin
2017-01-17 18:32 ` Florian Fainelli
2017-01-17 19:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox