[PATCH iproute2] vxlan: Allow setting unicast address to the group address

[PATCH iproute2] vxlan: Allow setting unicast address to the group address

[Atzm Watanabe]

This patch allows setting unicast address to the VXLAN group address.
It allows that VXLAN can be used as peer-to-peer tunnel without
multicast.

Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
---
 ip/iplink_vxlan.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
index 1025326..cfe324c 100644
--- a/ip/iplink_vxlan.c
+++ b/ip/iplink_vxlan.c
@@ -66,9 +66,6 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
 		} else if (!matches(*argv, "group")) {
 			NEXT_ARG();
 			gaddr = get_addr32(*argv);
-
-			if (!IN_MULTICAST(ntohl(gaddr)))
-				invarg("invald group address", *argv);
 		} else if (!matches(*argv, "local")) {
 			NEXT_ARG();
 			if (strcmp(*argv, "any"))
-- 
1.8.1.5

Re: [PATCH iproute2] vxlan: Allow setting unicast address to the group address

[Stephen Hemminger]

On Wed, 10 Apr 2013 17:52:05 +0900
Atzm Watanabe <atzm@stratosphere.co.jp> wrote:

> This patch allows setting unicast address to the VXLAN group address.
> It allows that VXLAN can be used as peer-to-peer tunnel without
> multicast.
> 
> Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
> ---
>  ip/iplink_vxlan.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> index 1025326..cfe324c 100644
> --- a/ip/iplink_vxlan.c
> +++ b/ip/iplink_vxlan.c
> @@ -66,9 +66,6 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
>  		} else if (!matches(*argv, "group")) {
>  			NEXT_ARG();
>  			gaddr = get_addr32(*argv);
> -
> -			if (!IN_MULTICAST(ntohl(gaddr)))
> -				invarg("invald group address", *argv);
>  		} else if (!matches(*argv, "local")) {
>  			NEXT_ARG();
>  			if (strcmp(*argv, "any"))

Could you use another name or argument to express the different intended behavior.

Re: [PATCH iproute2] vxlan: Allow setting unicast address to the group address

[Atzm Watanabe]

At Wed, 10 Apr 2013 09:46:39 -0700,
Stephen Hemminger wrote:
> 
> On Wed, 10 Apr 2013 17:52:05 +0900
> Atzm Watanabe <atzm@stratosphere.co.jp> wrote:
> 
> > This patch allows setting unicast address to the VXLAN group address.
> > It allows that VXLAN can be used as peer-to-peer tunnel without
> > multicast.
> > 
> > Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
> > ---
> >  ip/iplink_vxlan.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> > index 1025326..cfe324c 100644
> > --- a/ip/iplink_vxlan.c
> > +++ b/ip/iplink_vxlan.c
> > @@ -66,9 +66,6 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
> >  		} else if (!matches(*argv, "group")) {
> >  			NEXT_ARG();
> >  			gaddr = get_addr32(*argv);
> > -
> > -			if (!IN_MULTICAST(ntohl(gaddr)))
> > -				invarg("invald group address", *argv);
> >  		} else if (!matches(*argv, "local")) {
> >  			NEXT_ARG();
> >  			if (strcmp(*argv, "any"))
> 
> Could you use another name or argument to express the different intended behavior.

OK, I agreed.

But simply adding another name and argument also means that a VXLAN
interface can have multiple "last resort".
So I'll try to fix as below:

   1) Add "remote" apart from "group".
   2) But specifying both arguments at a time will fail.

If you have other better ideas, please let me know.

Thanks.