* [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3_offload.c.
@ 2007-07-08 9:39 Robert P. J. Day
2007-07-08 10:08 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2007-07-08 9:39 UTC (permalink / raw)
To: netdev
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
diff --git a/drivers/net/cxgb3/cxgb3_offload.c b/drivers/net/cxgb3/cxgb3_offload.c
index ebcf35e..999bc41 100644
--- a/drivers/net/cxgb3/cxgb3_offload.c
+++ b/drivers/net/cxgb3/cxgb3_offload.c
@@ -1105,7 +1105,7 @@ int cxgb3_offload_activate(struct adapter *adapter)
struct mtutab mtutab;
unsigned int l2t_capacity;
- t = kcalloc(1, sizeof(*t), GFP_KERNEL);
+ t = kcalloc(sizeof(*t), GFP_KERNEL);
if (!t)
return -ENOMEM;
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3_offload.c.
2007-07-08 9:39 [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3_offload.c Robert P. J. Day
@ 2007-07-08 10:08 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2007-07-08 10:08 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Sun, 2007-07-08 at 05:39 -0400, Robert P. J. Day wrote:
> - t = kcalloc(1, sizeof(*t), GFP_KERNEL);
> + t = kcalloc(sizeof(*t), GFP_KERNEL);
^
I don't think that's going to work, and shouldn't it probably use
kzalloc instead of kmalloc (as you wrote in subject)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-08 10:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-08 9:39 [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3_offload.c Robert P. J. Day
2007-07-08 10:08 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox