[PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err

[PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err

[Zhengchao Shao]

The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 net/ipv6/raw.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 03dbb874c363..479c4c2c1785 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -288,8 +288,7 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
 }
 
 static void rawv6_err(struct sock *sk, struct sk_buff *skb,
-	       struct inet6_skb_parm *opt,
-	       u8 type, u8 code, int offset, __be32 info)
+		      u8 type, u8 code, int offset, __be32 info)
 {
 	bool recverr = inet6_test_bit(RECVERR6, sk);
 	struct ipv6_pinfo *np = inet6_sk(sk);
@@ -344,7 +343,7 @@ void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 		if (!raw_v6_match(net, sk, nexthdr, &ip6h->saddr, &ip6h->daddr,
 				  inet6_iif(skb), inet6_iif(skb)))
 			continue;
-		rawv6_err(sk, skb, NULL, type, code, inner_offset, info);
+		rawv6_err(sk, skb, type, code, inner_offset, info);
 	}
 	rcu_read_unlock();
 }
-- 
2.34.1

Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err

[Eric Dumazet]

On Sat, Feb 24, 2024 at 9:33 AM Zhengchao Shao <shaozhengchao@huawei.com> wrote:
>
> The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>

Reviewed-by: Eric Dumazet <edumazet@google.com>

Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err

[Jiri Pirko]

Sat, Feb 24, 2024 at 09:41:21AM CET, shaozhengchao@huawei.com wrote:
>The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
>
>Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 24 Feb 2024 16:41:21 +0800 you wrote:
> The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>  net/ipv6/raw.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Here is the summary with links:
  - [net-next] ipv6: raw: remove useless input parameter in rawv6_err
    https://git.kernel.org/netdev/net-next/c/d75fe63a0708

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html