* [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err
@ 2024-02-24 8:41 Zhengchao Shao
2024-02-24 8:50 ` Eric Dumazet
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhengchao Shao @ 2024-02-24 8:41 UTC (permalink / raw)
To: netdev, davem, dsahern, edumazet, kuba, pabeni
Cc: weiyongjun1, yuehaibing, shaozhengchao
The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
net/ipv6/raw.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 03dbb874c363..479c4c2c1785 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -288,8 +288,7 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
}
static void rawv6_err(struct sock *sk, struct sk_buff *skb,
- struct inet6_skb_parm *opt,
- u8 type, u8 code, int offset, __be32 info)
+ u8 type, u8 code, int offset, __be32 info)
{
bool recverr = inet6_test_bit(RECVERR6, sk);
struct ipv6_pinfo *np = inet6_sk(sk);
@@ -344,7 +343,7 @@ void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
if (!raw_v6_match(net, sk, nexthdr, &ip6h->saddr, &ip6h->daddr,
inet6_iif(skb), inet6_iif(skb)))
continue;
- rawv6_err(sk, skb, NULL, type, code, inner_offset, info);
+ rawv6_err(sk, skb, type, code, inner_offset, info);
}
rcu_read_unlock();
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err
2024-02-24 8:41 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err Zhengchao Shao
@ 2024-02-24 8:50 ` Eric Dumazet
2024-02-26 9:26 ` Jiri Pirko
2024-02-28 2:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2024-02-24 8:50 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, dsahern, kuba, pabeni, weiyongjun1, yuehaibing
On Sat, Feb 24, 2024 at 9:33 AM Zhengchao Shao <shaozhengchao@huawei.com> wrote:
>
> The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err
2024-02-24 8:41 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err Zhengchao Shao
2024-02-24 8:50 ` Eric Dumazet
@ 2024-02-26 9:26 ` Jiri Pirko
2024-02-28 2:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2024-02-26 9:26 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, dsahern, edumazet, kuba, pabeni, weiyongjun1,
yuehaibing
Sat, Feb 24, 2024 at 09:41:21AM CET, shaozhengchao@huawei.com wrote:
>The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
>
>Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err
2024-02-24 8:41 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err Zhengchao Shao
2024-02-24 8:50 ` Eric Dumazet
2024-02-26 9:26 ` Jiri Pirko
@ 2024-02-28 2:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-28 2:10 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, dsahern, edumazet, kuba, pabeni, weiyongjun1,
yuehaibing
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 24 Feb 2024 16:41:21 +0800 you wrote:
> The input parameter 'opt' in rawv6_err() is not used. Therefore, remove it.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> net/ipv6/raw.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] ipv6: raw: remove useless input parameter in rawv6_err
https://git.kernel.org/netdev/net-next/c/d75fe63a0708
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-28 2:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 8:41 [PATCH net-next] ipv6: raw: remove useless input parameter in rawv6_err Zhengchao Shao
2024-02-24 8:50 ` Eric Dumazet
2024-02-26 9:26 ` Jiri Pirko
2024-02-28 2:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox