* [PATCH net-next] net: sun3lance: Remove redundant assignment
@ 2024-06-14 14:52 Kamal Heib
2024-06-14 17:01 ` Joe Damato
2024-06-18 1:00 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Heib @ 2024-06-14 14:52 UTC (permalink / raw)
To: netdev; +Cc: David S . Miller, Jakub Kicinski, Paolo Abeni, Kamal Heib
There is no point in initializing an ndo to NULL, therefore the
assignment is redundant and can be removed.
Signed-off-by: Kamal Heib <kheib@redhat.com>
---
drivers/net/ethernet/amd/sun3lance.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/sun3lance.c b/drivers/net/ethernet/amd/sun3lance.c
index 246f34c43765..fe12051d8471 100644
--- a/drivers/net/ethernet/amd/sun3lance.c
+++ b/drivers/net/ethernet/amd/sun3lance.c
@@ -296,7 +296,6 @@ static const struct net_device_ops lance_netdev_ops = {
.ndo_stop = lance_close,
.ndo_start_xmit = lance_start_xmit,
.ndo_set_rx_mode = set_multicast_list,
- .ndo_set_mac_address = NULL,
.ndo_validate_addr = eth_validate_addr,
};
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: sun3lance: Remove redundant assignment
2024-06-14 14:52 [PATCH net-next] net: sun3lance: Remove redundant assignment Kamal Heib
@ 2024-06-14 17:01 ` Joe Damato
2024-06-18 1:00 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Joe Damato @ 2024-06-14 17:01 UTC (permalink / raw)
To: Kamal Heib; +Cc: netdev, David S . Miller, Jakub Kicinski, Paolo Abeni
On Fri, Jun 14, 2024 at 10:52:31AM -0400, Kamal Heib wrote:
> There is no point in initializing an ndo to NULL, therefore the
> assignment is redundant and can be removed.
>
> Signed-off-by: Kamal Heib <kheib@redhat.com>
> ---
> drivers/net/ethernet/amd/sun3lance.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sun3lance: Remove redundant assignment
2024-06-14 14:52 [PATCH net-next] net: sun3lance: Remove redundant assignment Kamal Heib
2024-06-14 17:01 ` Joe Damato
@ 2024-06-18 1:00 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-06-18 1:00 UTC (permalink / raw)
To: Kamal Heib; +Cc: netdev, David S . Miller, Paolo Abeni
On Fri, 14 Jun 2024 10:52:31 -0400 Kamal Heib wrote:
> There is no point in initializing an ndo to NULL, therefore the
> assignment is redundant and can be removed.
>
> Signed-off-by: Kamal Heib <kheib@redhat.com>
> ---
> drivers/net/ethernet/amd/sun3lance.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/sun3lance.c b/drivers/net/ethernet/amd/sun3lance.c
> index 246f34c43765..fe12051d8471 100644
> --- a/drivers/net/ethernet/amd/sun3lance.c
> +++ b/drivers/net/ethernet/amd/sun3lance.c
> @@ -296,7 +296,6 @@ static const struct net_device_ops lance_netdev_ops = {
> .ndo_stop = lance_close,
> .ndo_start_xmit = lance_start_xmit,
> .ndo_set_rx_mode = set_multicast_list,
> - .ndo_set_mac_address = NULL,
> .ndo_validate_addr = eth_validate_addr,
> };
>
We seem to have a lot of these:
$ git grep -E '^[[:space:]]\.[a-z_]*[[:space:]]*= NULL,' -- drivers/net/
| wc -l
287
and we try to discourage folks from sending cleanup patches to
very old device drivers. So, unfortunately, I'd prefer to leave
this code as is.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-18 1:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-14 14:52 [PATCH net-next] net: sun3lance: Remove redundant assignment Kamal Heib
2024-06-14 17:01 ` Joe Damato
2024-06-18 1:00 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox