* [PATCH] pktgen: Use seq_putc() in pktgen_if_show()
@ 2024-07-14 18:34 Markus Elfring
2024-07-16 13:29 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2024-07-14 18:34 UTC (permalink / raw)
To: netdev, kernel-janitors, Andreas Gruenbacher, Benjamin Poirier,
David S. Miller, Eric Dumazet, Gavrilov Ilia, Jakub Kicinski,
Kevin Hao, Liang Chen, Paolo Abeni
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 14 Jul 2024 20:23:49 +0200
Single line breaks should be put into a sequence.
Thus use the corresponding function “seq_putc”.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
net/core/pktgen.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index ea55a758a475..441e058d6726 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -577,7 +577,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v)
pkt_dev->imix_entries[i].size,
pkt_dev->imix_entries[i].weight);
}
- seq_puts(seq, "\n");
+ seq_putc(seq, '\n');
}
seq_printf(seq,
@@ -685,7 +685,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v)
}
}
- seq_puts(seq, "\n");
+ seq_putc(seq, '\n');
/* not really stopped, more like last-running-at */
stopped = pkt_dev->running ? ktime_get() : pkt_dev->stopped_at;
@@ -706,7 +706,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v)
pkt_dev->imix_entries[i].size,
pkt_dev->imix_entries[i].count_so_far);
}
- seq_puts(seq, "\n");
+ seq_putc(seq, '\n');
}
seq_printf(seq,
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pktgen: Use seq_putc() in pktgen_if_show()
2024-07-14 18:34 [PATCH] pktgen: Use seq_putc() in pktgen_if_show() Markus Elfring
@ 2024-07-16 13:29 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2024-07-16 13:29 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, kernel-janitors, Andreas Gruenbacher, Benjamin Poirier,
David S. Miller, Eric Dumazet, Gavrilov Ilia, Jakub Kicinski,
Kevin Hao, Liang Chen, Paolo Abeni, LKML
Sun, Jul 14, 2024 at 08:34:14PM CEST, Markus.Elfring@web.de wrote:
>From: Markus Elfring <elfring@users.sourceforge.net>
>Date: Sun, 14 Jul 2024 20:23:49 +0200
>
>Single line breaks should be put into a sequence.
>Thus use the corresponding function “seq_putc”.
>
>This issue was transformed by using the Coccinelle software.
>
>Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-16 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-14 18:34 [PATCH] pktgen: Use seq_putc() in pktgen_if_show() Markus Elfring
2024-07-16 13:29 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox