From: Guenter Roeck <linux@roeck-us.net>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
alexei.starovoitov@gmail.com, daniel@iogearbox.net
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC
Date: Fri, 13 Jul 2018 19:26:48 -0700 [thread overview]
Message-ID: <a41c96c0-b561-9a85-45a6-84471e3489ff@roeck-us.net> (raw)
In-Reply-To: <20180714020859.11306-1-jakub.kicinski@netronome.com>
On 07/13/2018 07:08 PM, Jakub Kicinski wrote:
> perf propagates its feature check results to libbpf. This means
> features for which perf probes must be a superset of libbpf's
> required features. perf depends on FEATURE_TESTS_BASIC for its list
> of features.
>
> commit 531b014e7a2f ("tools: bpf: make use of reallocarray") added
> reallocarray use to libbpf, make perf also perform the reallocarray
> feature check.
>
> Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> tools/build/Makefile.feature | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 5b6dda3b1ca8..f216b2f5c3d7 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -57,6 +57,7 @@ FEATURE_TESTS_BASIC := \
> libunwind-aarch64 \
> pthread-attr-setaffinity-np \
> pthread-barrier \
> + reallocarray \
> stackprotector-all \
> timerfd \
> libdw-dwarf-unwind \
>
next prev parent reply other threads:[~2018-07-14 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 2:08 [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC Jakub Kicinski
2018-07-14 2:26 ` Guenter Roeck [this message]
2018-07-14 8:40 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a41c96c0-b561-9a85-45a6-84471e3489ff@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox