* [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC
@ 2018-07-14 2:08 Jakub Kicinski
2018-07-14 2:26 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2018-07-14 2:08 UTC (permalink / raw)
To: alexei.starovoitov, daniel; +Cc: linux, oss-drivers, netdev, Jakub Kicinski
perf propagates its feature check results to libbpf. This means
features for which perf probes must be a superset of libbpf's
required features. perf depends on FEATURE_TESTS_BASIC for its list
of features.
commit 531b014e7a2f ("tools: bpf: make use of reallocarray") added
reallocarray use to libbpf, make perf also perform the reallocarray
feature check.
Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
tools/build/Makefile.feature | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index 5b6dda3b1ca8..f216b2f5c3d7 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -57,6 +57,7 @@ FEATURE_TESTS_BASIC := \
libunwind-aarch64 \
pthread-attr-setaffinity-np \
pthread-barrier \
+ reallocarray \
stackprotector-all \
timerfd \
libdw-dwarf-unwind \
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC
2018-07-14 2:08 [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC Jakub Kicinski
@ 2018-07-14 2:26 ` Guenter Roeck
2018-07-14 8:40 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2018-07-14 2:26 UTC (permalink / raw)
To: Jakub Kicinski, alexei.starovoitov, daniel; +Cc: oss-drivers, netdev
On 07/13/2018 07:08 PM, Jakub Kicinski wrote:
> perf propagates its feature check results to libbpf. This means
> features for which perf probes must be a superset of libbpf's
> required features. perf depends on FEATURE_TESTS_BASIC for its list
> of features.
>
> commit 531b014e7a2f ("tools: bpf: make use of reallocarray") added
> reallocarray use to libbpf, make perf also perform the reallocarray
> feature check.
>
> Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> tools/build/Makefile.feature | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 5b6dda3b1ca8..f216b2f5c3d7 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -57,6 +57,7 @@ FEATURE_TESTS_BASIC := \
> libunwind-aarch64 \
> pthread-attr-setaffinity-np \
> pthread-barrier \
> + reallocarray \
> stackprotector-all \
> timerfd \
> libdw-dwarf-unwind \
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC
2018-07-14 2:26 ` Guenter Roeck
@ 2018-07-14 8:40 ` Daniel Borkmann
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2018-07-14 8:40 UTC (permalink / raw)
To: Guenter Roeck, Jakub Kicinski, alexei.starovoitov; +Cc: oss-drivers, netdev
On 07/14/2018 04:26 AM, Guenter Roeck wrote:
> On 07/13/2018 07:08 PM, Jakub Kicinski wrote:
>> perf propagates its feature check results to libbpf. This means
>> features for which perf probes must be a superset of libbpf's
>> required features. perf depends on FEATURE_TESTS_BASIC for its list
>> of features.
>>
>> commit 531b014e7a2f ("tools: bpf: make use of reallocarray") added
>> reallocarray use to libbpf, make perf also perform the reallocarray
>> feature check.
>>
>> Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Applied to bpf-next, thanks everyone!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-14 8:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-14 2:08 [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC Jakub Kicinski
2018-07-14 2:26 ` Guenter Roeck
2018-07-14 8:40 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox