* Re: [PATCH net] selftests/bpf: fix broken build due to types.h
[not found] <20170516184634.2803675-1-yhs@fb.com>
@ 2017-05-16 19:18 ` David Miller
2017-05-16 23:16 ` Yonghong Song
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2017-05-16 19:18 UTC (permalink / raw)
To: yhs; +Cc: daniel, netdev, kernel-team
Please correct the address of the netdev list (it is just plain
'netdev' not 'linux-netdev').
Secondly, __always_inline should not be defined by types.h
That has to come from linux/compiler.h which we have no reason
to define a private version of for eBPF clang compilation.
The problem is that via several layers of indirection, linux/types.h
eventually includes linux/compiler.h and that is probably the more
appropriate thing for you to do.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net] selftests/bpf: fix broken build due to types.h
2017-05-16 19:18 ` [PATCH net] selftests/bpf: fix broken build due to types.h David Miller
@ 2017-05-16 23:16 ` Yonghong Song
0 siblings, 0 replies; 2+ messages in thread
From: Yonghong Song @ 2017-05-16 23:16 UTC (permalink / raw)
To: David Miller; +Cc: daniel, netdev, kernel-team
On 5/16/17 12:18 PM, David Miller wrote:
>
> Please correct the address of the netdev list (it is just plain
> 'netdev' not 'linux-netdev').
Thanks. Shortly after my first email, I sent a corrected submit as well.
Sorry for the spam.
>
> Secondly, __always_inline should not be defined by types.h
>
> That has to come from linux/compiler.h which we have no reason
> to define a private version of for eBPF clang compilation.
>
> The problem is that via several layers of indirection, linux/types.h
> eventually includes linux/compiler.h and that is probably the more
> appropriate thing for you to do.
Right. I found out simply including string.h will eventually include
linux/compiler.h so that I do not need explicitly defining
__always_inline.
Will send a revised patch soon.
Thanks,
Yonghong
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-16 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170516184634.2803675-1-yhs@fb.com>
2017-05-16 19:18 ` [PATCH net] selftests/bpf: fix broken build due to types.h David Miller
2017-05-16 23:16 ` Yonghong Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox