[PATCH v2] net: switchdev: fix duplicate word in documentation

[PATCH v2] net: switchdev: fix duplicate word in documentation

[Wang Zihan]

Remove duplicate "in" word.

Signed-off-by: Wang Zihan <jiyu03@qq.com>
---
 Documentation/networking/switchdev.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
index 2966b7122..948bce44c 100644
--- a/Documentation/networking/switchdev.rst
+++ b/Documentation/networking/switchdev.rst
@@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
 monitoring NETDEV_CHANGEUPPER notifications.  For example, a port moved into a
 bond will see its upper master change.  If that bond is moved into a bridge,
 the bond's upper master will change.  And so on.  The driver will track such
-movements to know what position a port is in in the overall topology by
+movements to know what position a port is in the overall topology by
 registering for netdevice events and acting on NETDEV_CHANGEUPPER.
 
 L2 Forwarding Offload
-- 
2.54.0

Re: [PATCH v2] net: switchdev: fix duplicate word in documentation

[Björn Persson]

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

Wang Zihan wrote:
> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
>  monitoring NETDEV_CHANGEUPPER notifications.  For example, a port moved into a
>  bond will see its upper master change.  If that bond is moved into a bridge,
>  the bond's upper master will change.  And so on.  The driver will track such
> -movements to know what position a port is in in the overall topology by
> +movements to know what position a port is in the overall topology by
>  registering for netdevice events and acting on NETDEV_CHANGEUPPER.
>  
>  L2 Forwarding Offload

This change claims that a port is a position. The preceding sentences,
talking about "a particular port's position" and a port being moved,
make it clear that a port is *in* a position *in* the topology. The
port is not itself a position.

Björn Persson

[-- Attachment #2: OpenPGP digital signatur --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] net: switchdev: fix duplicate word in documentation

[Andrew Lunn]

On Sat, May 02, 2026 at 01:24:46PM +0200, Björn Persson wrote:
> Wang Zihan wrote:
> > @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
> >  monitoring NETDEV_CHANGEUPPER notifications.  For example, a port moved into a
> >  bond will see its upper master change.  If that bond is moved into a bridge,
> >  the bond's upper master will change.  And so on.  The driver will track such
> > -movements to know what position a port is in in the overall topology by
> > +movements to know what position a port is in the overall topology by
> >  registering for netdevice events and acting on NETDEV_CHANGEUPPER.
> >  
> >  L2 Forwarding Offload
> 
> This change claims that a port is a position. The preceding sentences,
> talking about "a particular port's position" and a port being moved,
> make it clear that a port is *in* a position *in* the topology. The
> port is not itself a position.

I assume this is a fix to make a bot happy, without actually checking
if the bot is correct.

Maybe to prevent a recurrence of the bot driver not validating the bot
output, a ',' should be added?

    Andrew

---
pw-bot: cr

Re: [PATCH v2] net: switchdev: fix duplicate word in documentation

[Jonas Gorski]

On 02/05/2026 16:09, Andrew Lunn wrote:
> On Sat, May 02, 2026 at 01:24:46PM +0200, Björn Persson wrote:
>> Wang Zihan wrote:
>>> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
>>>  monitoring NETDEV_CHANGEUPPER notifications.  For example, a port moved into a
>>>  bond will see its upper master change.  If that bond is moved into a bridge,
>>>  the bond's upper master will change.  And so on.  The driver will track such
>>> -movements to know what position a port is in in the overall topology by
>>> +movements to know what position a port is in the overall topology by
>>>  registering for netdevice events and acting on NETDEV_CHANGEUPPER.
>>>  
>>>  L2 Forwarding Offload
>>
>> This change claims that a port is a position. The preceding sentences,
>> talking about "a particular port's position" and a port being moved,
>> make it clear that a port is *in* a position *in* the topology. The
>> port is not itself a position.
> 
> I assume this is a fix to make a bot happy, without actually checking
> if the bot is correct.
> 
> Maybe to prevent a recurrence of the bot driver not validating the bot
> output, a ',' should be added?

I'm not a native speaker, but I think moving the first "in" would also
work:

"... to know in what position a port is in the overall topology ..."

Best regards,
Jonas