Re: [RFC PATCH net-next 09/10] net: hibmcge: Add a Makefile and update Kconfig for hibmcge

[Andrew Lunn <andrew@lunn.ch>]

On Thu, Aug 01, 2024 at 08:15:43PM +0800, Jijie Shao wrote:
> 
> on 2024/8/1 9:13, Andrew Lunn wrote:
> > On Wed, Jul 31, 2024 at 05:42:44PM +0800, Jijie Shao wrote:
> > > Add a Makefile and update Kconfig to build hibmcge driver.
> > > 
> > > Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> > > ---
> > >   drivers/net/ethernet/hisilicon/Kconfig          | 17 ++++++++++++++++-
> > >   drivers/net/ethernet/hisilicon/Makefile         |  1 +
> > >   drivers/net/ethernet/hisilicon/hibmcge/Makefile | 10 ++++++++++
> > >   3 files changed, 27 insertions(+), 1 deletion(-)
> > >   create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/Makefile
> > > 
> > > diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
> > > index 3312e1d93c3b..372854d15481 100644
> > > --- a/drivers/net/ethernet/hisilicon/Kconfig
> > > +++ b/drivers/net/ethernet/hisilicon/Kconfig
> > > @@ -7,7 +7,7 @@ config NET_VENDOR_HISILICON
> > >   	bool "Hisilicon devices"
> > >   	default y
> > >   	depends on OF || ACPI
> > > -	depends on ARM || ARM64 || COMPILE_TEST
> > > +	depends on ARM || ARM64 || COMPILE_TEST || X86_64
> > It is normal to have COMPILE_TEST last.
> 
> ok，
> 
> > 
> > Any reason this won't work on S390, PowerPC etc?
> 
> I have only compiled and tested on arm or x86.
> I can't ensure that compile or work ok on other platforms.

It is a sign of quality if it compiles on other platforms. The kernel
APIs should hide away all the differences, if you are using them
correctly. So i would take away all the platform depends at this
level. Toolchains are easy to install apt-get
c-compiler-s390x-linux-gnu etc. And 0-day will build it for you after
a while on various platforms.


> 
> > 
> > > +if ARM || ARM64 || COMPILE_TEST
> > > +
> > You would normally express this with a depends on.
> 
> Sorry, I can't understand how to convert if to depends on?

Kconfig is not my speciality, but cannot you using

	depends on ARM || ARM64 || COMPILE_TEST

inside the symbol?

	Andrew