* Re: [PATCH net-next v2] net: airoha: add ethtool priv_flags support for LAN/WAN and GDM2 loopback [not found] <20260607-airoha-ethtool-priv_flags-v2-1-742c7aa1e182@kernel.org> @ 2026-06-07 17:59 ` Andrew Lunn 2026-06-07 18:07 ` Lorenzo Bianconi 0 siblings, 1 reply; 3+ messages in thread From: Andrew Lunn @ 2026-06-07 17:59 UTC (permalink / raw) To: Lorenzo Bianconi Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-arm-kernel, linux-mediatek, netdev, Madhur Agrawal > When a GDM3/GDM4 port is set to WAN mode, enable GDM2 loopback to > support hardware QoS. Conversely, when switching back to LAN mode, > disable the GDM2 loopback and restore the default forwarding > configuration. Why not just use the presence of an off loadable qdisc as the indicator to change mode? Andrew ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] net: airoha: add ethtool priv_flags support for LAN/WAN and GDM2 loopback 2026-06-07 17:59 ` [PATCH net-next v2] net: airoha: add ethtool priv_flags support for LAN/WAN and GDM2 loopback Andrew Lunn @ 2026-06-07 18:07 ` Lorenzo Bianconi 2026-06-07 18:48 ` Andrew Lunn 0 siblings, 1 reply; 3+ messages in thread From: Lorenzo Bianconi @ 2026-06-07 18:07 UTC (permalink / raw) To: Andrew Lunn Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-arm-kernel, linux-mediatek, netdev, Madhur Agrawal [-- Attachment #1: Type: text/plain, Size: 449 bytes --] > > When a GDM3/GDM4 port is set to WAN mode, enable GDM2 loopback to > > support hardware QoS. Conversely, when switching back to LAN mode, > > disable the GDM2 loopback and restore the default forwarding > > configuration. > > Why not just use the presence of an off loadable qdisc as the > indicator to change mode? Hi Andrew, Interesting, can you please provide more details about you mean? Regards, Lorenzo > > Andrew [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] net: airoha: add ethtool priv_flags support for LAN/WAN and GDM2 loopback 2026-06-07 18:07 ` Lorenzo Bianconi @ 2026-06-07 18:48 ` Andrew Lunn 0 siblings, 0 replies; 3+ messages in thread From: Andrew Lunn @ 2026-06-07 18:48 UTC (permalink / raw) To: Lorenzo Bianconi Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-arm-kernel, linux-mediatek, netdev, Madhur Agrawal On Sun, Jun 07, 2026 at 08:07:37PM +0200, Lorenzo Bianconi wrote: > > > When a GDM3/GDM4 port is set to WAN mode, enable GDM2 loopback to > > > support hardware QoS. Conversely, when switching back to LAN mode, > > > disable the GDM2 loopback and restore the default forwarding > > > configuration. > > > > Why not just use the presence of an off loadable qdisc as the > > indicator to change mode? > > Hi Andrew, > > Interesting, can you please provide more details about you mean? You say you need it to be in loopback mode in order to support hardware QoS. You configure QoS by using a qdisc, and something like mqprio, tcf etc. So when the user configures QoS, you can see if the hardware supports the request QoS. If so, swap to loopback mode and offload the QoS function to the hardware. If the hardware does not support the requested QoS, leave it in software and keep with LAN mode. Andrew ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-07 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260607-airoha-ethtool-priv_flags-v2-1-742c7aa1e182@kernel.org>
2026-06-07 17:59 ` [PATCH net-next v2] net: airoha: add ethtool priv_flags support for LAN/WAN and GDM2 loopback Andrew Lunn
2026-06-07 18:07 ` Lorenzo Bianconi
2026-06-07 18:48 ` Andrew Lunn
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox