* [PATCH] VSOCK: fix returnvar.cocci warnings
@ 2015-12-06 5:56 Julia Lawall
2015-12-07 1:50 ` Stefan Hajnoczi
2015-12-07 3:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2015-12-06 5:56 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Stefan Hajnoczi, kvm, Michael S. Tsirkin, netdev, virtualization,
kbuild-all, Matt Benjamin, Asias He, Christoffer Dall, matt.ma
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
CC: Asias He <asias@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
vsock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -56,8 +56,7 @@ struct vhost_vsock {
static u32 vhost_transport_get_local_cid(void)
{
- u32 cid = VHOST_VSOCK_DEFAULT_HOST_CID;
- return cid;
+ return VHOST_VSOCK_DEFAULT_HOST_CID;
}
static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] VSOCK: fix returnvar.cocci warnings
2015-12-06 5:56 [PATCH] VSOCK: fix returnvar.cocci warnings Julia Lawall
@ 2015-12-07 1:50 ` Stefan Hajnoczi
2015-12-07 3:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-12-07 1:50 UTC (permalink / raw)
To: Julia Lawall
Cc: kvm, Michael S. Tsirkin, netdev, virtualization, kbuild-all,
Matt Benjamin, Asias He, Christoffer Dall, matt.ma
[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]
On Sun, Dec 06, 2015 at 06:56:23AM +0100, Julia Lawall wrote:
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Asias He <asias@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
> ---
>
> vsock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -56,8 +56,7 @@ struct vhost_vsock {
>
> static u32 vhost_transport_get_local_cid(void)
> {
> - u32 cid = VHOST_VSOCK_DEFAULT_HOST_CID;
> - return cid;
> + return VHOST_VSOCK_DEFAULT_HOST_CID;
> }
>
> static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] VSOCK: fix returnvar.cocci warnings
2015-12-06 5:56 [PATCH] VSOCK: fix returnvar.cocci warnings Julia Lawall
2015-12-07 1:50 ` Stefan Hajnoczi
@ 2015-12-07 3:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-12-07 3:38 UTC (permalink / raw)
To: julia.lawall
Cc: stefanha, kbuild-all, kvm, mbenjamin, christoffer.dall, netdev,
mst, matt.ma, virtualization, asias
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Sun, 6 Dec 2015 06:56:23 +0100 (CET)
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Asias He <asias@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-07 3:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-06 5:56 [PATCH] VSOCK: fix returnvar.cocci warnings Julia Lawall
2015-12-07 1:50 ` Stefan Hajnoczi
2015-12-07 3:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox