Re: [PATCH rdma-next 06/23] RDMA/mlx5: Require IB_QPT_DRIVER for the DC vendor QP types

[Yishai Hadas <yishaih@nvidia.com>]

On 07/11/2026 22:24, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] The commit "RDMA/mlx5: Require IB_QPT_DRIVER for the DC vendor
>    QP types" fixes a regression that userspace can trigger, but its…
> 
> --
> 
> RDMA/mlx5: Require IB_QPT_DRIVER for the DC vendor QP types
> 
> This patch changes process_vendor_flags() in drivers/infiniband/hw/mlx5/qp.c
> so that it rejects MLX5_QP_FLAG_TYPE_DCI and MLX5_QP_FLAG_TYPE_DCT unless
> the QP was requested as IB_QPT_DRIVER. Without this check, an RC/UC/UD QP
> that carries a DC flag becomes a DC QP and skips the dct capability check
> in check_qp_type().
> 
>> Accept the DC type flags only on IB_QPT_DRIVER, the type userspace
>> uses to create DC QPs.
>>
>> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> 
> [Severity: Medium]
> Should this patch carry a Fixes: tag and Cc: stable? Userspace can reach
> the behavior it fixes, and nothing in the message tells stable maintainers
> to pick it up.

Right, V1 will add the Fixes line.

Yishai