Re: [PATCH v2 04/10] dt-bindings: net: pcs: add rockchip,rk3568-xpcs binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/08/2026 19:20, Coia Prant wrote:
> Hi Krzysztof,
> 
> Thanks for the detailed review. Here's my response to each point:
> 
>>> +title: Rockchip RK3568 Synopsys DesignWare Ethernet PCS
>>> +
>>> +maintainers:
>>> +  - Coia Prant <coiaprant@gmail.com>
>>> +
>>> +description: |
>>> +  Rockchip RK3568 SoC integrates a Synopsys DesignWare Ethernet Physical
>>> +  Coding Sublayer (XPCS).
>>> +  The PCS provides an interface between the Media Access Control (MAC)
>>> +  and the Physical Medium Attachment (PMA) sublayer through a Media
>>> +  Independent Interface (GMII).
>>> +
>>> +  The XPCS is accessed over the APB3 bus and internally connected to a
>>> +  Naneng Combo SerDes PHY.
>>> +  It supports 1000BASE-X, SGMII and QSGMII modes.
>>> +
>>> +  The block contains four MII ports (pcs-mii@0..3) that can be
>>> +  individually enabled and routed to one of the Ethernet GMAC controllers
>>> +  via the pcs-handle property in the MAC device tree node.
> 
> 1. Commit message: I'll drop the redundant description paragraph and keep
>    only the essential information.
> 
> 2. Subject: I'll drop the redundant "binding" word.
> 
>> +properties:
>> +  compatible:
>> +    const: rockchip,rk3568-xpcs
>> +
>> +  '#address-cells':
>> +    const: 1
>> +
>> +  '#size-cells':
>> +    const: 0
> 
> 3. reg order: I'll move reg to the second property (after compatible).
> 
> 4. Quotes: I'll use consistent quoting style throughout.
> 
>> +  reg:
>> +    description: |
>> +      Base address and size of the XPCS register space mapped over the
>> +      APB3 bus.
> 
> 5. reg description: I'll drop it as redundant.
> 
>> +  clocks:
>> +    description: |
>> +      Clock sources for the XPCS:
>> +      - csr: APB3 bus interface clock (clk_csr_i), required for register
>> +        access.
>> +      - eee: EEE clock (clk_eee_i), required for Energy Efficient
>> +        Ethernet (EEE) operation.
>> +    minItems: 2
>> +    maxItems: 2
> 
> 6. clocks: I'll change to items with descriptions instead of min/maxItems.
> 
>> +  clock-names:
>> +    items:
>> +      - const: csr
>> +      - const: eee
>> +
>> +  phys:
>> +    description: |
> 
> 7. description formatting: I'll remove unnecessary '|' where not needed.
> 
>> +  power-domains:
>> +    description: |
>> +      Power domain for the XPCS.
> 
> 8. power-domains description: I'll drop the redundant part.

I don't understand any of these. There are none of my quotes. I don't
get what you are referring to.


Best regards,
Krzysztof