Re: [PATCH net-next 3/3] netlink: specs: dpll: drop the reference to DPLL_MODE_DETACHED

[Ivan Vecera <ivecera@redhat.com>]

On 9/25/26 1:12 AM, Jakub Kicinski wrote:
> The lock-status doc tells userspace that DPLL_LOCK_STATUS_UNLOCKED
> can be forced by setting DPLL_A_MODE to DPLL_MODE_DETACHED.
> But no such value has been defined so far. enum dpll_mode has only
> MANUAL and AUTOMATIC. Let's make sure the doc reflects current
> reality.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>   Documentation/netlink/specs/dpll.yaml | 3 +--
>   include/uapi/linux/dpll.h             | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index 7009a64473b1..8fa789a50273 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -31,8 +31,7 @@ doc: DPLL subsystem.
>         -
>           name: unlocked
>           doc: |
> -          dpll was not yet locked to any valid input (or forced by setting
> -          DPLL_A_MODE to DPLL_MODE_DETACHED)
> +          dpll was not yet locked to any valid input
>           value: 1
>         -
>           name: locked
> diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h
> index 85b898b1db5e..8c71fc3f9863 100644
> --- a/include/uapi/linux/dpll.h
> +++ b/include/uapi/linux/dpll.h
> @@ -29,8 +29,7 @@ enum dpll_mode {
>   /**
>    * enum dpll_lock_status - provides information of dpll device lock status,
>    *   valid values for DPLL_A_LOCK_STATUS attribute
> - * @DPLL_LOCK_STATUS_UNLOCKED: dpll was not yet locked to any valid input (or
> - *   forced by setting DPLL_A_MODE to DPLL_MODE_DETACHED)
> + * @DPLL_LOCK_STATUS_UNLOCKED: dpll was not yet locked to any valid input
>    * @DPLL_LOCK_STATUS_LOCKED: dpll is locked to a valid signal, but no holdover
>    *   available
>    * @DPLL_LOCK_STATUS_LOCKED_HO_ACQ: dpll is locked and holdover acquired

Reviewed-by: Ivan Vecera <ivecera@redhat.com>