Netdev List
 help / color / mirror / Atom feed
From: Ivan Vecera <ivecera@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	vadim.fedorenko@linux.dev, arkadiusz.kubalewski@intel.com,
	jiri@resnulli.us, donald.hunter@gmail.com
Subject: Re: [PATCH net-next 2/3] netlink: specs: dpll: declare pad in the nests which carry 64-bit values
Date: Fri, 25 Sep 2026 20:00:07 +0200	[thread overview]
Message-ID: <d7c2c701-cfca-4d97-bee7-757b6f31f0d8@redhat.com> (raw)
In-Reply-To: <20260924231211.568213-3-kuba@kernel.org>



On 9/25/26 1:12 AM, Jakub Kicinski wrote:
> Pads need to be propagated to subsets if they are used.
> Otherwise Python YNL can fail with:
> 
>    YnlException: Space 'frequency-range' has no attribute with value '4'
> 
> This affects only platforms which care about alignment
> so not much real impact.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>   Documentation/netlink/specs/dpll.yaml | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index e2ca4df5699a..7009a64473b1 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -550,6 +550,8 @@ doc: DPLL subsystem.
>       attributes:
>         -
>           name: parent-id
> +      -
> +        name: pad
>         -
>           name: direction
>         -
> @@ -576,6 +578,8 @@ doc: DPLL subsystem.
>       name: frequency-range
>       subset-of: pin
>       attributes:
> +      -
> +        name: pad
>         -
>           name: frequency-min
>         -

Reviewed-by: Ivan Vecera <ivecera@redhat.com>


  reply	other threads:[~2026-09-25 18:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 23:12 [PATCH net-next 0/3] dpll: fix LLM nit picks from the spec scan Jakub Kicinski
2026-09-24 23:12 ` [PATCH net-next 1/3] dpll: do not truncate the requested pin frequency before checking it Jakub Kicinski
2026-09-25 17:59   ` Ivan Vecera
2026-09-24 23:12 ` [PATCH net-next 2/3] netlink: specs: dpll: declare pad in the nests which carry 64-bit values Jakub Kicinski
2026-09-25 18:00   ` Ivan Vecera [this message]
2026-09-24 23:12 ` [PATCH net-next 3/3] netlink: specs: dpll: drop the reference to DPLL_MODE_DETACHED Jakub Kicinski
2026-09-25 18:00   ` Ivan Vecera
2026-09-26  1:20 ` [PATCH net-next 0/3] dpll: fix LLM nit picks from the spec scan patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7c2c701-cfca-4d97-bee7-757b6f31f0d8@redhat.com \
    --to=ivecera@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox